Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   25 Feb 2019 10:18:06 +0900
Message-ID: <87a7ik3cea.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc:     <twischer@de.adit-jv.com>, <patch@alsa-project.org>,
        <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
        Jiada Wang <jiada_wang@mentor.com>
Subject: Re: [PATCH] ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address
In-Reply-To: <87bm303cie.wl-kuninori.morimoto.gx@renesas.com>
References: <1550823803-32446-1-git-send-email-twischer@de.adit-jv.com>
        <87bm303cie.wl-kuninori.morimoto.gx@renesas.com>
User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Jiada, again

> > Currently each SSI unit 's busif dma address is calculated by
> > following calculation formulation:
> > 0xec540000 + 0x1000 * id + busif / 4 * 0xA000 + busif % 4 * 0x400
> > 
> > But according to user manual 41.1.4 Register Configuration
> > ssi9 4/5/6/7 busif data register address
> > (SSI9_4_BUSIF/SSI9_5_BUSIF/SSI9_6_BUSIF/SSI9_7_BUSIF)
> > are out of this rule.
> > 
> > This patch updates the calculation formulation to correct
> > ssi9 4/5/6/7 busif data register address
> > 
> > Fixes: commit 5e45a6fab3b9 ("ASoc: rsnd: dma: Calculate dma address with consider of BUSIF")
> > Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> > Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>
> > ---
> 
> We don't need below anymore by this patch ?
> 
> 	--- dma.c ----
> 	/*
> 	 * FIXME
> 	 *
> 	 * We can't support SSI9-4/5/6/7, because its address is
> 	 * out of calculation rule
> 	 */
> 	if ((id == 9) && (busif >= 4))
> 		dev_err(dev, "This driver doesn't support SSI%d-%d, so far",
> 			id, busif);

Oops, next patch is removing this.
Please ignore this mail.