Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <3d1f18412a927f69c733b6ed31659b7770610442.1550062410.git.baolin.wang@linaro.org>
In-Reply-To: <3d1f18412a927f69c733b6ed31659b7770610442.1550062410.git.baolin.wang@linaro.org>
From:   Baolin Wang <baolin.wang@linaro.org>
Date:   Mon, 25 Feb 2019 10:22:26 +0800
Message-ID: <CAMz4kuLqjqF3LCYKH1_BjQPnikNe6pd2T3HmgpBwoR0nYP=Wqg@mail.gmail.com>
Subject: Re: [PATCH] mfd: sc27xx: Use SoC compatible string for PMIC devices
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Lee,

On Wed, 13 Feb 2019 at 20:57, Baolin Wang <baolin.wang@linaro.org> wrote:
>
> We should use SoC compatible string in stead of wildcard string for
> PMIC child devices.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---

Could you apply this patch if you have no other issues? Thanks.

>  drivers/mfd/sprd-sc27xx-spi.c |   42 ++++++++++++++++++++---------------------
>  1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> index 69df277..43ac716 100644
> --- a/drivers/mfd/sprd-sc27xx-spi.c
> +++ b/drivers/mfd/sprd-sc27xx-spi.c
> @@ -53,67 +53,67 @@ struct sprd_pmic_data {
>  static const struct mfd_cell sprd_pmic_devs[] = {
>         {
>                 .name = "sc27xx-wdt",
> -               .of_compatible = "sprd,sc27xx-wdt",
> +               .of_compatible = "sprd,sc2731-wdt",
>         }, {
>                 .name = "sc27xx-rtc",
> -               .of_compatible = "sprd,sc27xx-rtc",
> +               .of_compatible = "sprd,sc2731-rtc",
>         }, {
>                 .name = "sc27xx-charger",
> -               .of_compatible = "sprd,sc27xx-charger",
> +               .of_compatible = "sprd,sc2731-charger",
>         }, {
>                 .name = "sc27xx-chg-timer",
> -               .of_compatible = "sprd,sc27xx-chg-timer",
> +               .of_compatible = "sprd,sc2731-chg-timer",
>         }, {
>                 .name = "sc27xx-fast-chg",
> -               .of_compatible = "sprd,sc27xx-fast-chg",
> +               .of_compatible = "sprd,sc2731-fast-chg",
>         }, {
>                 .name = "sc27xx-chg-wdt",
> -               .of_compatible = "sprd,sc27xx-chg-wdt",
> +               .of_compatible = "sprd,sc2731-chg-wdt",
>         }, {
>                 .name = "sc27xx-typec",
> -               .of_compatible = "sprd,sc27xx-typec",
> +               .of_compatible = "sprd,sc2731-typec",
>         }, {
>                 .name = "sc27xx-flash",
> -               .of_compatible = "sprd,sc27xx-flash",
> +               .of_compatible = "sprd,sc2731-flash",
>         }, {
>                 .name = "sc27xx-eic",
> -               .of_compatible = "sprd,sc27xx-eic",
> +               .of_compatible = "sprd,sc2731-eic",
>         }, {
>                 .name = "sc27xx-efuse",
> -               .of_compatible = "sprd,sc27xx-efuse",
> +               .of_compatible = "sprd,sc2731-efuse",
>         }, {
>                 .name = "sc27xx-thermal",
> -               .of_compatible = "sprd,sc27xx-thermal",
> +               .of_compatible = "sprd,sc2731-thermal",
>         }, {
>                 .name = "sc27xx-adc",
> -               .of_compatible = "sprd,sc27xx-adc",
> +               .of_compatible = "sprd,sc2731-adc",
>         }, {
>                 .name = "sc27xx-audio-codec",
> -               .of_compatible = "sprd,sc27xx-audio-codec",
> +               .of_compatible = "sprd,sc2731-audio-codec",
>         }, {
>                 .name = "sc27xx-regulator",
> -               .of_compatible = "sprd,sc27xx-regulator",
> +               .of_compatible = "sprd,sc2731-regulator",
>         }, {
>                 .name = "sc27xx-vibrator",
> -               .of_compatible = "sprd,sc27xx-vibrator",
> +               .of_compatible = "sprd,sc2731-vibrator",
>         }, {
>                 .name = "sc27xx-keypad-led",
> -               .of_compatible = "sprd,sc27xx-keypad-led",
> +               .of_compatible = "sprd,sc2731-keypad-led",
>         }, {
>                 .name = "sc27xx-bltc",
> -               .of_compatible = "sprd,sc27xx-bltc",
> +               .of_compatible = "sprd,sc2731-bltc",
>         }, {
>                 .name = "sc27xx-fgu",
> -               .of_compatible = "sprd,sc27xx-fgu",
> +               .of_compatible = "sprd,sc2731-fgu",
>         }, {
>                 .name = "sc27xx-7sreset",
> -               .of_compatible = "sprd,sc27xx-7sreset",
> +               .of_compatible = "sprd,sc2731-7sreset",
>         }, {
>                 .name = "sc27xx-poweroff",
> -               .of_compatible = "sprd,sc27xx-poweroff",
> +               .of_compatible = "sprd,sc2731-poweroff",
>         }, {
>                 .name = "sc27xx-syscon",
> -               .of_compatible = "sprd,sc27xx-syscon",
> +               .of_compatible = "sprd,sc2731-syscon",
>         },
>  };
>
> --
> 1.7.9.5
>


-- 
Baolin Wang
Best Regards