Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Feb 2019 01:28:05 -0700
From:   Jerry Hoemann <jerry.hoemann@hpe.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Matt Hsiao <matt.hsiao@hpe.com>, linux-kernel@vger.kernel.org,
        arnd@arndb.de, david.altobelli@hpe.com, mark.rusk@hpe.com
Subject: Re: [PATCH 4/4] misc: hpilo: Update driver version
Message-ID: <20190225082805.GA10062@anatevka>
Reply-To: Jerry.Hoemann@hpe.com
References: <1550736282-25416-1-git-send-email-matt.hsiao@hpe.com>
 <1550736282-25416-5-git-send-email-matt.hsiao@hpe.com>
 <20190221083256.GA6397@kroah.com>
 <20190222041111.GB31132@anatevka>
 <20190222064928.GA15860@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190222064928.GA15860@kroah.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Feb 22, 2019 at 07:49:28AM +0100, Greg KH wrote:
> On Thu, Feb 21, 2019 at 09:11:11PM -0700, Jerry Hoemann wrote:
> 
> > Our primary means of supporting Linux to our customers is via our
> > distro partners.  While we prefer to use in distro drivers, HPE does
> > from time to time deliver driver updates via the "Service Pack for
> > Proliants" -- The SPP. 
> 
> That's fine, but again, does not matter to the in-kernel driver at all.

Your point?  No one claimed that changing the version number
of the module changes its functionality.  We're changing the driver
version number to reflect that the driver's functionality changed.

We do this to help determine the version running on a system
in the event we have problems.  It's a support issue.

> I understand that in your viewpoint, your driver's version means
> something.  But in reality, it's only the kernel's version that means
> something because your driver is just part of the overall kernel, it
> does not stand alone.

I never claimed a driver stood alone.  jeezz.

When you say kernel "version", are you trying to say that the version
string printed by the kernel determines the source of the drivers?
(I ask, because I have heard other maintainers make this claim.)

The kernel version string only reliably determines the base kernel build.
Modules can be unloaded and replaced by totally new versions drastically
different from the version that existed at the time of the base kernel build.

The delivery of drivers updates independent of base kernel was old
practice when I started Unix development 30 years ago.  It was not unique
to HPE then or now.  I don't see it stopping.

So while Linux delivers drivers built to a baseline kernel build, we
cannot rely that the bits being used on a system still reflect that initial
install.  We can't just assume a driver version.  And without knowing
the driver version, it makes support more difficult.

If you're trying to be profound, the "version" of the OS running is
more than just the base kernel.  That is only the beginning.
We then have to consider the modules loaded and the order that they're
loaded.  This sequence is unbounded as modules can be repeatedly loaded
and unloaded.  When you know that, then you know the "version" of the kernel
running.

But that isn't what the kernel version string gives you.  So why have it/print it?
By your reasoning it's meaningless. It should be tossed.  We have it because
it gives us info, but it is only a start.


-----------------------------------------------------------------------------
Jerry Hoemann                  Software Engineer   Hewlett Packard Enterprise
-----------------------------------------------------------------------------