Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp4267014imc; Mon, 25 Feb 2019 01:40:38 -0800 (PST) X-Google-Smtp-Source: AHgI3IYoxzcNsn8sHKGcu5J4FcO7wkJ5wFz/AwSSbaJ3b/4+5rTnic+OUKoOvvFAJQioUythwOXK X-Received: by 2002:a62:59d0:: with SMTP id k77mr19395363pfj.211.1551087638243; Mon, 25 Feb 2019 01:40:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551087638; cv=none; d=google.com; s=arc-20160816; b=dj96lWU+6skOCqkMPqVcOIr5f3h7tvzf7N95nyQbhUfZ+O/j1YuEkNJWSMwgjAYKHP 1E0joKJZE7x37JVnM9e1fvTb8b/fw4UEECByX8N3g7V9DVIViLiLy8FhLYIRayp91Tk1 1kFBenm3hVqdL6BML5m/Y+2d6xa1a0rdipsrgWBRLZAQszV22tlv9MrgqQWGUAKY4TbR QBUzZAYWC1fWURCssrK0fjThcxrMYAHTbuCriHt7Zs7Gk/U0U54ZOd8eKAXU2yXYcAdn +VfB4yd5deYxNwikhW8xJuAtty/EQbZeU+wzV2pHsuiRPLMD8h4l/Bk73QsG3zPD9AWk rwEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2P4wfZlstgqqSw7lga+yhXzHy19NN3IOgak9to2Nwbs=; b=MKekiarQDAllNdojj9h6/QoA/le/nDWETCVnu4DEeoNO2FyTdR9AXEbOJyxD7sy2cs Z3EDkmtoK9ZYTYCfcLx1m8djiIfeilmO9yIkvmQR3LkydHq/mAn1zoapJXr6nAcljE6g ZPMvOZmNMbfyFAT/avucYv07CJgErrqDXSQ3cGCcpn1UUP34CuOwSGgPVFOenNIgVWoR +kpbVLJ0UtFCfcZJmsI+VqEcseQoWWCTf83Hy7Q3lYCOn8T9M6iHyd4Zv9XELfzfs+rM zpwreeJ0eT5/LKryTI70JGPmDtCJDD3xhtC8eiFnmnEtUKX1cwQLbsnmDiyi7kqGO9HY kQEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=ETRk3QL9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 88si9585543plb.288.2019.02.25.01.40.22; Mon, 25 Feb 2019 01:40:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=ETRk3QL9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726559AbfBYJjz (ORCPT + 99 others); Mon, 25 Feb 2019 04:39:55 -0500 Received: from mail.skyhub.de ([5.9.137.197]:35630 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726374AbfBYJjz (ORCPT ); Mon, 25 Feb 2019 04:39:55 -0500 Received: from zn.tnic (p200300EC2BC68000F50265612EF4EB95.dip0.t-ipconnect.de [IPv6:2003:ec:2bc6:8000:f502:6561:2ef4:eb95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 338D61EC0253; Mon, 25 Feb 2019 10:39:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1551087594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=2P4wfZlstgqqSw7lga+yhXzHy19NN3IOgak9to2Nwbs=; b=ETRk3QL9P10ZnXhhUl/wkevLTH3HVeiaVKBz3SzeU8YokiyrECFRdb1pA3jNleHTHrWaOE l2tx238ovYgvuAUkhf5BWSim6uvrMHKd3aqelFVAeFgR3hom78z1Di1obzQZ+AiE6GLgWn TrbpRIFlINEnlZj2pZmTV/dqZKT0xHo= Date: Mon, 25 Feb 2019 10:39:51 +0100 From: Borislav Petkov To: Pingfan Liu Cc: Joerg Roedel , Dave Young , Baoquan He , Jerry Hoemann , x86@kernel.org, Randy Dunlap , kexec@lists.infradead.org, LKML , Mike Rapoport , Andrew Morton , Yinghai Lu , vgoyal@redhat.com, iommu@lists.linux-foundation.org, konrad.wilk@oracle.com Subject: Re: [PATCHv7] x86/kdump: bugfix, make the behavior of crashkernel=X consistent with kaslr Message-ID: <20190225093950.GB26145@zn.tnic> References: <20190211204816.GB21473@dhcp-128-65.nay.redhat.com> <20190215102458.GD10433@zn.tnic> <20190218014820.GA10711@dhcp-128-65.nay.redhat.com> <20190220083241.GA3447@zn.tnic> <20190220094146.GA8597@dhcp-128-65.nay.redhat.com> <20190221171321.GD12997@zn.tnic> <20190222021101.GA11654@dhcp-128-65.nay.redhat.com> <20190222084241.GC8380@suse.de> <20190222130026.GA30766@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 24, 2019 at 09:25:18PM +0800, Pingfan Liu wrote: > Maybe I misunderstood you, but does "requested range failed" mean that > user specify the range? If yes, then it should be the duty of user as > you said later, not the duty of kernel" No, it should say that it selected a different range only when the user didn't specify it. Which would mean that the user didn't care about the range - she/he only wanted to have *any* crashkernel range reserved. I.e., crashkernel=X invocation. > We do not know the memory layout of a system, maybe a system with > memory less than 4GB. So it is better to try all the range of system > memory. Ok. If 4G fails, you set high and then try again. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.