Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp4602877imc; Mon, 25 Feb 2019 07:45:14 -0800 (PST) X-Google-Smtp-Source: AHgI3IbOg7cqYyDsOrSt8TkTqIxmp88SN3abDn/MCySLRpMi4wIOnIXS3aJzlAyTRvCJK8l4EvZX X-Received: by 2002:a17:902:8f82:: with SMTP id z2mr21139387plo.163.1551109514313; Mon, 25 Feb 2019 07:45:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551109514; cv=none; d=google.com; s=arc-20160816; b=FYCzNZKiMQPihZW6nMP4DVsZuBMCtJGNZ40gTHG9n1r8G8cEMB59mXKYZGFdKxBpaD T8vE9+5WGH4Idazd97tocmRfU2p6IUVe+pxArKYRY9XJQ/Cfvg++quIbnPf2Ja2H0+Oq WEM3CgyuYfwk/0Y/2EK5invUSM7E0S+O93RghTyg0xSc9kx4QoaQ1D4Qauw0MC69Owj2 lX7GwHBLNbpHKhuvwxbcQTQVVXHt1liJvlxIDnoHmQRyYIOSMix4LeQ8T30x1IGNlCwJ 3Y2ydLCl/HpngZvgVN54kqzQjCmuBZ5FRHVK8fcvPAYPwuHOtZmAy2s2+8QVptuIeFOf OplQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=YJQpovYpYRbsFnvx1dAg4PkTk45HQ4Ul9jQiHG64c50=; b=omYXV/jPMOWKa12ENgjXyCSvFS5Wdb61QE5c3N9ssTn30Cadzpl/Cepmm/Lw71zN5j BO3dvCnT46LmX0y536QrGWJpUSJTaukni/WMQnEa8oQDQTVOjnImmMLRNhpPDSF0eCXs 8SYJ85QgE6jRFR/PV3mFNJ9USR+1MwLvFH7WQvF9nBsQMVB+dn7heeIBRmyvwUnuMDi4 PxrX8Zwe7G6tWD7UpiLrUWBvtFrpH+4qdF4tuGaiYFCSW2EUltL2vDdNZ4cI3qidmyjZ pg/viQssSyks3tGKIgsh/P4DGrzmoqyvVZMROQGKReSmHFiOm3eRrJNl3J5I79mB3wR3 P7pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amacapital-net.20150623.gappssmtp.com header.s=20150623 header.b=c43DKEGC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a10si9220063pgt.357.2019.02.25.07.44.58; Mon, 25 Feb 2019 07:45:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amacapital-net.20150623.gappssmtp.com header.s=20150623 header.b=c43DKEGC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727768AbfBYPoH (ORCPT + 99 others); Mon, 25 Feb 2019 10:44:07 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34419 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727638AbfBYPoH (ORCPT ); Mon, 25 Feb 2019 10:44:07 -0500 Received: by mail-wr1-f68.google.com with SMTP id f14so10489639wrg.1 for ; Mon, 25 Feb 2019 07:44:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amacapital-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YJQpovYpYRbsFnvx1dAg4PkTk45HQ4Ul9jQiHG64c50=; b=c43DKEGCylJL46UktKQRNoH6z6yH5V0QWaFCNjdm0RKCQ5y4y1TbvGfhzozgKp1fKn y+05ZBZGThNkIC+o3wBZWNB/H1LDCsJA/5KL9tQKKNYeiwf6pFGZQ+VLeL8EztVDfAzp xul+sKPXurtXE68AP2noLHiH7YMo5i7F6pdlY7G8Ye8uws2h5e7xUlgexg4MWcx81ZVc f4kBsbG7iaeOyPjfjlpaGvNqmV5zaqw0unnaYqOQPhkhm75vz5Px5bXk5EzCvvW5CtNG xxhwpXFpLhBHUR27KPZhnXogXtPwYvEH79P1QDvuzg8NmMdnq5sTEGFi4J+TmBuMM3j4 jffw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YJQpovYpYRbsFnvx1dAg4PkTk45HQ4Ul9jQiHG64c50=; b=jf5VfTTDfZwlxTjD0ho90MiDTqS+OBZzbC/VfZ2Y1iy7a6iCYULXLNru0LxYSaZ4bQ sDXOr6Zdm1hyC8OyGXaLYMZJZrq8c8K4Khdbr22IkCNpYutn3yzVMUUN+THSL4uv6JhO UI74oyO+X8oxCfwAb3duxKJUxQyEBSL2LVqCd0ZYkwzRSMAWadXtvCHE4KLhnQGPySnp ejtb2zyN/pdnoo/50L8gRzRvvjlaZ4WaMPkCU3VP2baldRxuMggtU6guOos7tPEmN9xs Obysuq8vzml5r3Aim63+VxZ9+3VLXmSdlMFtHfLv99/SR1cIgbOR0QI1KzCidyUUrXD4 +Ngg== X-Gm-Message-State: AHQUAuaH9LjgkMvC1D4UfDWm7C7wA14Q0CWr6Iw6oW/b+2BgdeDLAnu5 Z1I5OM7NRmMtom/beDySfTjtuEBAKW1unJXvWN8XhA== X-Received: by 2002:adf:e58f:: with SMTP id l15mr11932590wrm.309.1551109445605; Mon, 25 Feb 2019 07:44:05 -0800 (PST) MIME-Version: 1.0 References: <20190225124330.613028745@infradead.org> <20190225125231.845656645@infradead.org> In-Reply-To: <20190225125231.845656645@infradead.org> From: Andy Lutomirski Date: Mon, 25 Feb 2019 07:43:53 -0800 Message-ID: Subject: Re: [PATCH 1/6] x86/uaccess: Dont evaluate argument inside AC region To: Peter Zijlstra Cc: Linus Torvalds , Thomas Gleixner , "H. Peter Anvin" , Julien Thierry , Will Deacon , Ingo Molnar , Catalin Marinas , James Morse , valentin.schneider@arm.com, Brian Gerst , Josh Poimboeuf , Andrew Lutomirski , Borislav Petkov , Denys Vlasenko , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 25, 2019 at 4:53 AM Peter Zijlstra wrote: > > AC regions are special, make sure we don't do possibly complex > evaluations there. > > Probably-Signed-off-by: Andy Lutomirski I put a slightly fancier version here last night so that the 0day bot could chew on it: https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/fixes&id=b294da548d92320f194172272dda1f734e51013d want to snarf it up? It's the same thing except that I added Linus' suggested change, found the offending patch that broke it (hi Linus!) and added a bit more changelog :)