Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v1 1/3] ARM: dts: stm32: Add Vivante GPU support on
 STM32MP157c
To:     Lucas Stach <l.stach@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@st.com>
CC:     <devicetree@vger.kernel.org>,
        Philippe Cornu <philippe.cornu@st.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>
References: <1550246316-9747-1-git-send-email-pierre-yves.mordret@st.com>
 <1550246316-9747-2-git-send-email-pierre-yves.mordret@st.com>
 <1550247118.2546.56.camel@pengutronix.de>
From:   Pierre Yves MORDRET <pierre-yves.mordret@st.com>
Message-ID: <44bb72aa-8e49-4ec5-dd9a-5fce6f0bce29@st.com>
Date:   Mon, 25 Feb 2019 16:48:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <1550247118.2546.56.camel@pengutronix.de>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Lucas

sorry for the delay : winter season :)

On 2/15/19 5:11 PM, Lucas Stach wrote:
> Hi Pierre-Yves,
> 
> Am Freitag, den 15.02.2019, 16:58 +0100 schrieb Pierre-Yves MORDRET:
>> Append Vivante GPU DT configuration.
>>
>> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
>> ---
>>  arch/arm/boot/dts/stm32mp157c.dtsi | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
>> index f8bbfff..29540bc 100644
>> --- a/arch/arm/boot/dts/stm32mp157c.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi
>> @@ -1106,6 +1106,16 @@
>>>  			status = "disabled";
>>>  		};
>>  
>> +		gpu: gpu@59000000 {
>> +			compatible = "vivante,gc";
>> +			reg = <0x59000000 0x800>;
>> +			interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
>> +			clocks = <&rcc GPU>, <&rcc GPU_K>;
>> +			clock-names = "bus" ,"core";
> 
> Is this a 2D only core? If it is also 3D capable the binding says you
> need to specify the shader clock (may be the same clock feeding the
> core).

Yes, this is a 3D core.
As for "shader" clock both "core" and "shader" are connected internally. This is
why no "shader" input clock is seen.
Nonetheless we may add it for bindings compliance but from STM32MP1 pov this
won't make any changes.

Hope it clarifies.

Regards
> 
> Regards,
> Lucas
> 
>> +			resets = <&rcc GPU_R>;
>> +			status = "disabled";
>> +		};
>> +
>>  		dsi: dsi@5a000000 {
>>  			compatible = "st,stm32-dsi";
>>  			reg = <0x5a000000 0x800>;