Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp4620659imc; Mon, 25 Feb 2019 08:03:48 -0800 (PST) X-Google-Smtp-Source: AHgI3Iaym0PasXFkgCFsGla3WScN8ZCwJciiOoJKh2zdSKweOAC8+YPNuoeErGWfv9T6JuGTeO/+ X-Received: by 2002:a17:902:b486:: with SMTP id y6mr14181351plr.104.1551110628192; Mon, 25 Feb 2019 08:03:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551110628; cv=none; d=google.com; s=arc-20160816; b=WrFibn5RU7f9ndchGP/2hM/dNQKKCmHGvEneeNGwHaySkI6IVEMtZQpeZW7gOMDw6u whsD5j727c8V4Y5rCkMTGOCnbuWaEG/6hZSFZAvQE9dGnxnNNXZP7aGw6TjDn+mz0ZUK nbbR0SC5PYMsyAOR2EyjM32vaN1MftImH0OOT4y4TSZzqDvLn8K9P+XF2ZsDIF3PTLkm TfyP+SYxZpcBOBKUcDazz5zgY/+ruh/dAAKHwsZWQddk+pIHs/PTD9MaLotE6S0bIuzM HRS3pPR0fa3xZbzDf3H701ZCrlA2RsHgy+0QbUD8romU6O4zEuuj+G7EL1XOBPrikNj0 juDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=66YT2ZgedMRxeKmlzocG77g0pVreYAX15nL55pvCTdw=; b=RzSkzft8xI5nx+qFEYIHPBOtuaxyfhJiRr6lbJ9xKzkUb+fZbq/XXqsCEx8VO/0K9/ YXBD8CijXjG9t2qfMmx1ytMKjiCpCwuZ2Hi2En5fmomAv2p9SLlynXKjOQmGBcy3QqnY +kN9QR6YUWPENCiyEOdmmg8z28EqOSECMTrGn5xZLVkw2UTyFofj849qJm++q4tbp5JE gRbZg0XVMN7pf/UFsdz+r0EA9WT7w8nyGWDG8jZSWXgc1WPGH8MS6eRJjR+W0M6Izop5 OEpjHCXrHxjfjbWj/FV+IA3yRFb7uKDuSBfPE8RTk90FhYnkp76t5GRpm6TZJayz9mXs JUiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Hb2CwwPF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7si3752948pgs.155.2019.02.25.08.03.32; Mon, 25 Feb 2019 08:03:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Hb2CwwPF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727998AbfBYQCf (ORCPT + 99 others); Mon, 25 Feb 2019 11:02:35 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:44794 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727731AbfBYQCe (ORCPT ); Mon, 25 Feb 2019 11:02:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=66YT2ZgedMRxeKmlzocG77g0pVreYAX15nL55pvCTdw=; b=Hb2CwwPFr9gn1yTtE3yqDXUt7 jysuWTuQfHiXzP3wst55xdjPb8b7SAXiaBQkZYdTt5aehaJjLvpOrs8LlqwTSZ/uGAPyaEmt8MA+J 4Vq6xAdn1vSUteFz6OM9I+2UFnKVMJl52Lr/8Sy58zU+HcftnBqoCVwUs8vKQGiHl9ESumETHDMrg F84tSasbmooQz0rnC1I/oAcZsK6S+2lpaSAGSfVkE7a7bC99NgT3otV/u4RjUWzqsLppzMt1po/u2 CfbMl60afHxFhzCEJKGBcWXu6/pNJgPXl89g0AojHyuZQQNUIBK4UpRvRAalMM1cFL2xneTVpWNjV pjhMQo02A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gyIi2-0007jh-1q; Mon, 25 Feb 2019 16:02:26 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 3E40220277F84; Mon, 25 Feb 2019 17:02:23 +0100 (CET) Date: Mon, 25 Feb 2019 17:02:23 +0100 From: Peter Zijlstra To: Andy Lutomirski Cc: Linus Torvalds , Thomas Gleixner , "H. Peter Anvin" , Julien Thierry , Will Deacon , Ingo Molnar , Catalin Marinas , James Morse , valentin.schneider@arm.com, Brian Gerst , Josh Poimboeuf , Andrew Lutomirski , Borislav Petkov , Denys Vlasenko , LKML Subject: Re: [PATCH 1/6] x86/uaccess: Dont evaluate argument inside AC region Message-ID: <20190225160223.GK32477@hirez.programming.kicks-ass.net> References: <20190225124330.613028745@infradead.org> <20190225125231.845656645@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 25, 2019 at 07:43:53AM -0800, Andy Lutomirski wrote: > On Mon, Feb 25, 2019 at 4:53 AM Peter Zijlstra wrote: > > > > AC regions are special, make sure we don't do possibly complex > > evaluations there. > > > > Probably-Signed-off-by: Andy Lutomirski > > I put a slightly fancier version here last night so that the 0day bot > could chew on it: > > https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/fixes&id=b294da548d92320f194172272dda1f734e51013d > > want to snarf it up? It's the same thing except that I added Linus' > suggested change, found the offending patch that broke it (hi Linus!) > and added a bit more changelog :) Sure; I'll take that one.