Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp4633613imc; Mon, 25 Feb 2019 08:15:13 -0800 (PST) X-Google-Smtp-Source: AHgI3IYdBni1URaiKkj0lQrF4A/pJILsuTO5RN70IMUqB5OdVhWw42whCwubATtlt58rQi27taFd X-Received: by 2002:a17:902:6a3:: with SMTP id 32mr21172005plh.319.1551111313722; Mon, 25 Feb 2019 08:15:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551111313; cv=none; d=google.com; s=arc-20160816; b=J1LdwCCn9gS8RJmhDtPvbNOeBCwZENfGW+1XErAARFMDAttznkUqPXuVr1ISUAvqJz 0nFAFZAufftiP47vRPTVdc7a9rA9Teimdj6c9VmIG1Sp+A4najChduwbHXssG/3ksAqZ NJk56TPdpDv8JG3vk91uw8VDcHCqFldsm45OYB48hlJfRcKxBNB7Ntg91ovju2PJvxoZ mGRjk8jFQe7o1nzKYXH6k09VEFoUBiUriOV+e7sRhwC4zpS3sp94QmMe8l9JMD2QgcKk zvr9JrllC4NU2wi3vFTfw6GaUL2eZNghrdJUG/H4mwUKE7AMZHZzPApMJhATu8VtgbDP ktVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=H7FW9aQ5NIrue77h+rjmC/NP6QR53Fgh7Cpg21nDWZs=; b=H0+m2EysUI0PygPpTQWlPHTFpEgD6C5mEXLinWKLVCUwq5zTjckCnpSBzDQIdS1l9X A64DudVqWhHWFWUvQ/4de3kKLKukHOy7IITNbUBFncjqkFyvABMrnIZaTp2LrQ6qwDa2 JYMZdpgFrYSPh1HJ70iwsanSNSSNW8DvzxVrT/7xbt3YogvttRDnbeqo7zTHOeHhMf1V MdHu25B8O/MFjjRqYAm9OU/AUBe49JPpYDJQcuUJIfk2+qwz3DQA+INkVHnO4Z9Zyrvw yu19XlPnEylkT4Ys+XAXrvOiM8e3LhuIziRtRJ1nPB8Hy425kq7xg/kijB8Bt3n1r/6t GJMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j16si9577739pfe.152.2019.02.25.08.14.58; Mon, 25 Feb 2019 08:15:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728086AbfBYQOT (ORCPT + 99 others); Mon, 25 Feb 2019 11:14:19 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:57589 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727661AbfBYQOR (ORCPT ); Mon, 25 Feb 2019 11:14:17 -0500 X-Originating-IP: 90.88.23.190 Received: from mc-bl-xps13.lan (aaubervilliers-681-1-81-190.w90-88.abo.wanadoo.fr [90.88.23.190]) (Authenticated sender: maxime.chevallier@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 9D69CE001B; Mon, 25 Feb 2019 16:14:13 +0000 (UTC) From: Maxime Chevallier To: davem@davemloft.net Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Antoine Tenart , thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com Subject: [PATCH net-next 1/2] net: phy: marvell10g: Let genphy_c45_pma_read_abilities set Aneg bit Date: Mon, 25 Feb 2019 17:14:06 +0100 Message-Id: <20190225161407.19510-2-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190225161407.19510-1-maxime.chevallier@bootlin.com> References: <20190225161407.19510-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The genphy_c45_pma_read_abilities helper now sets the Autoneg ability in phydev->supported according to what the AN MMD reports. We therefore don't need to manually do that in mv3310_get_features(). Signed-off-by: Maxime Chevallier Suggested-by: Heiner Kallweit --- drivers/net/phy/marvell10g.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c index 580e91deadbc..ab71da55c1e0 100644 --- a/drivers/net/phy/marvell10g.c +++ b/drivers/net/phy/marvell10g.c @@ -268,16 +268,6 @@ static int mv3310_get_features(struct phy_device *phydev) { int ret, val; - if (phydev->c45_ids.devices_in_package & MDIO_DEVS_AN) { - val = phy_read_mmd(phydev, MDIO_MMD_AN, MDIO_STAT1); - if (val < 0) - return val; - - if (val & MDIO_AN_STAT1_ABLE) - linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, - phydev->supported); - } - ret = genphy_c45_pma_read_abilities(phydev); if (ret) return ret; -- 2.19.2