Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp4680764imc; Mon, 25 Feb 2019 09:04:08 -0800 (PST) X-Google-Smtp-Source: AHgI3IZuQNVbBAkvj65iqQcfc3xo2ovZubMyTtSkiXYxtRcKi8H0Ay7WSN4XApCaNdBDSbhm3fcE X-Received: by 2002:a63:4d4f:: with SMTP id n15mr20050990pgl.327.1551114248008; Mon, 25 Feb 2019 09:04:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551114247; cv=none; d=google.com; s=arc-20160816; b=C+SkhdAU3ER6vavyL0vZu9oZMQAvjuKfbiuBZ9JLbZe18piWlPAoaIZ7WU3OplT/Sw zOoyoxqN/Ns0kIVpmZF6g+RF38DDX8WHWhQfY6eTlWOcpDUaRGXzvn3+GkgUxP72HcqV 1spp9lqLXvjK7NsY9l0tqIvh76kYDbZLo1BT7NVWqp+QchRZ6nCSSInCaviVDLh2PLOP 08HmMoS1kIqu2NVHaRUhCBUJpTyj9a9hgEuQehGLnRwS67rCKd0NTRbOsPngm7ykZf6p gKFeCJNxxZkUXW3Sm5n6bJhhgSaIQepb2V+Um4jV5UxP37I/6ZHMjSmiQitrixPf6yV8 7cLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=UR8hfqhE4aa8jApKoRXT6gMsPJFMDg+eI2NHscJ5iVQ=; b=mrWoDhD/wIueIWj/KIp9V/82mI7KFwZJPR1CIJpigzDaW2qMOsiwQ4Tf1UZRY6MJgv 7mmg9Dhs2xulsgqiYVDywrWZtofeXBAX5CKZNtN6pyVfCBvQ1UwWzlG3Mkk8iUZgjJqk 47By/HXdjZ7Xm+BDpSPilExSB7EkhEX7TVXuhmablZLi9gt4zgFxgDN032CxaKRlMJlv hSskk20yK2QSjh3qR9tE6AehrbLlpinzA8UCAU68t/g9wha03kc8hYwUj4aHs6QoD7Nz eE0Au3kgpbDBGElbqUj9FbjdnAm1ov1QYAO09fhlrD2cqumpdVjnOXNfhzRziDXdCfhP qzbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=M2qt0utX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i10si10339384pfj.186.2019.02.25.09.03.51; Mon, 25 Feb 2019 09:04:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=M2qt0utX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728428AbfBYRD3 (ORCPT + 99 others); Mon, 25 Feb 2019 12:03:29 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:39619 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728028AbfBYRD3 (ORCPT ); Mon, 25 Feb 2019 12:03:29 -0500 Received: by mail-pf1-f193.google.com with SMTP id i20so4775149pfo.6; Mon, 25 Feb 2019 09:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UR8hfqhE4aa8jApKoRXT6gMsPJFMDg+eI2NHscJ5iVQ=; b=M2qt0utX7Mwshpou2a29cxE1aaGT+Ynknk8VxiA60rMahoVY19SRKzCGtmqNHFqKg9 +P0N9EA4HY38uStBFF+NpBjDd+z0VET+f7VaBncmRWakrPTWaImJxlmJvoLiExvML+sH y8dH6Hm/4FoAZHZ2oW817hPibSTfdIoLdcG5Yd5GQ/7iiefCrPIHF9+46o1QsEI0Aadp PRsmAvk8f+x+e3IRXKomlGj/O2nTrTTQFtxgKOaJvJgMLGbv7LmxWbMavIMRKa+3dHg/ qiM74p/Gs80GtkAGA6fNn/tWfFLSGi0eCRSKJ0bIMdlZIGfoIfI6WQpkDIIcLffnWbZ7 eqFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UR8hfqhE4aa8jApKoRXT6gMsPJFMDg+eI2NHscJ5iVQ=; b=n0WJxIjKMEz/hrV7cUBuzPacguzq6eK5DbmeemBuYphnc6oNT6kvPBlat2TtdNe+r9 PR66cddL7odPAHPMcpkmUWLZI3qD3Hf+c8i3yuEUmTWI/aEoPgdAJMkKExMEefbmjmNM PN2Uz8cZGWnYqEcg1JgHdPr5Q9ar7yzrkNluO4irEKxlJaLT20vnK5BpeeVmVnBJMHca kLn2C9YyoO/nkRHr6XErM8F0x1Uvrj4bCIl3cnq/Xgggsa8aF6aOyKGBbPyxK0YUxcXk BBrkZh7WGUuSyEJy3f+zgBbDlGEIHbDc3F4SxhOn4wlyhUeguNBD+XYamxOKzPQf5Qs1 02yQ== X-Gm-Message-State: AHQUAubIHVA1Ojacec0dVt2pAhtVUBf96UXW07eW61aBYaHrG+vGom0h +PQODLrH9V+vLCVFe/cRTZM= X-Received: by 2002:a63:c745:: with SMTP id v5mr20182029pgg.261.1551114208326; Mon, 25 Feb 2019 09:03:28 -0800 (PST) Received: from bharath12345-Inspiron-5559 ([103.110.42.32]) by smtp.gmail.com with ESMTPSA id k17sm32038782pfj.92.2019.02.25.09.03.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 09:03:27 -0800 (PST) Date: Mon, 25 Feb 2019 22:33:22 +0530 From: Bharath Vedartham To: Richard Weinberger Cc: Jens Axboe , linux-block@vger.kernel.org, LKML Subject: Re: [PATCH] badblocks: Prefer unsigned int over unsigned Message-ID: <20190225170322.GA10453@bharath12345-Inspiron-5559> References: <20190224141952.GA3653@bharath12345-Inspiron-5559> <20190224153712.GA11981@bharath12345-Inspiron-5559> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 24, 2019 at 04:50:51PM +0100, Richard Weinberger wrote: > On Sun, Feb 24, 2019 at 4:38 PM Bharath Vedartham wrote: > > I understand. I am starting out kernel hacking. I have been working on > > fixing checkpatch.pl warnings. If you have any tasks for me in the > > kernel, it would be great. > > > > I have also noticed a lot of warnings to replace printk with subsystem > > specific warning functions. Is that a valuable change? > > This is a very good start: > https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html > > Happy hacking and welcome! :-) > > -- > Thanks, > //richard Hey! Thanks for the link Richard! I have read it and clearly understood the message. I will work on understanding the kernel and writing my own code for my own personal learning before jumping into tasks! Thanks for your time! Bharath