Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Feb 2019 18:15:31 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Andy Lutomirski <luto@amacapital.net>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Julien Thierry <julien.thierry@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Ingo Molnar <mingo@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        James Morse <james.morse@arm.com>, valentin.schneider@arm.com,
        Brian Gerst <brgerst@gmail.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Andrew Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] objtool: Add UACCESS validation
Message-ID: <20190225171531.GD32534@hirez.programming.kicks-ass.net>
References: <20190225124330.613028745@infradead.org>
 <20190225125232.191698923@infradead.org>
 <CALCETrW1_r=Qgbpiq8PsYYD11W7CwAS-UCAxzvvubJnMAHH2Dg@mail.gmail.com>
 <20190225161234.GM32477@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190225161234.GM32477@hirez.programming.kicks-ass.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 25, 2019 at 05:12:34PM +0100, Peter Zijlstra wrote:
> On Mon, Feb 25, 2019 at 07:53:01AM -0800, Andy Lutomirski wrote:
> > On Mon, Feb 25, 2019 at 4:53 AM Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > > +#define UACCESS_SAFE(func)                                             \
> > > +       asm (".pushsection .discard.uaccess_safe_strtab, \"S\", @3\n\t" \
> > > +            "999: .ascii \"" #func "\"\n\t"                            \
> > > +            "     .byte 0\n\t"                                         \
> > > +            ".popsection\n\t"                                          \
> > > +            ".pushsection .discard.uaccess_safe\n\t"                   \
> > > +            ".long 999b - .\n\t"                                       \
> > > +            ".popsection")
> > 
> > Minor nit: using big numbers like 999: like this always bugs me.  It
> > relies on there not being a macro nested inside or outside this that
> > uses the same number.  My general preference is to do something like
> > .Ldescription_\@ instead.
> > 
> > Otherwise this looks conceptually good :)
> 
> I seem to remember here being an issue with the \@ thing. Notably we're
> not using it in nospsec-branch.h.
> 
> I'll see if I can dig up why we decided not to use it there.

Ah, so the thing we need for inline-asm is %=, but Linus didn't like it:

  https://lkml.kernel.org/r/20180111175626.GJ6176@hirez.programming.kicks-ass.net

Also, I think at the time we didn't use it because backporting efforts.

I can't really find what happened between:

  https://lkml.kernel.org/r/1515508997-6154-2-git-send-email-dwmw@amazon.co.uk

and

  https://lkml.kernel.org/r/1515707194-20531-4-git-send-email-dwmw@amazon.co.uk

But the %= thing went away.