Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp4914446imc; Mon, 25 Feb 2019 13:32:00 -0800 (PST) X-Google-Smtp-Source: AHgI3Iaqs64rFafaVpbLte9rWv5dmm1gJMVxBFq2nGt/cssHN9mC9E2GtqGDw9MdsSpNoDTRouK6 X-Received: by 2002:a17:902:28e6:: with SMTP id f93mr12592954plb.264.1551130320405; Mon, 25 Feb 2019 13:32:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551130320; cv=none; d=google.com; s=arc-20160816; b=igRpeQieJN++zUApIZtjeG2eCnuQCeDJP4z3ImrVNTEtb0tU8Yy5K68yfbt9JGIW4u JdhD4yo/6Umr2ClnxCxhWSi1Yz84cdwWteYp8OkNU7e35U9pLnDWkwrx3bfZa8QIHmCR F3YcOr2wNU+ti456SfIVVjJI9Q7195VGy0DPr1ubiLGeeJvfNK/Xy2LUmdf2PGUuh6gQ M1uwWfGD5P45QnzcyrjhplIpjCArIExAWYUv1nZJsJxxD5CcAIceAFxaCAP62pc3ZPEJ ZpFP2di41TC/UFdb/o4VOsr6EkKJGErIsQuqQbQArpCCiboIb/d2oXJTzqPeNottwE0P QWmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=msjKfcQMozH8vHEE4X7S6NY/FqhvkgDgVvh5KSaN+VE=; b=vEuMyu351UE7RVZilZMBypC166fRp1xm+vim8tiiEB9yhTFlCFw9XAp6zULNB7DL4P N+PQIHHSLwkxM0o75U8bAQh++j1k+iDihDEUP5p3szEyHRWbdIxm0RC28mYcmSIQnOTa Itu5EaSvK7jf5vXYS6E5gf9rdSCuUqySfk2IENDq9k7a48TucKLOZoDnPerDpdYE4Dn8 GiB+1/RxmMusmDpymueCLGgxIAT5vg81Zaz3knwc45rYUgRG5TjNu6d08fcDMvohefBg /YKzHpiOhVB2J1zTkaEIEzGnNxW0AjdsuOu8mGeAsd3pCsdbQX07lmfGBO2a00hRxpJ3 mS8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1C2altXI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o26si5666345pfi.141.2019.02.25.13.31.44; Mon, 25 Feb 2019 13:32:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1C2altXI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732307AbfBYVbZ (ORCPT + 99 others); Mon, 25 Feb 2019 16:31:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:36992 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732298AbfBYVbY (ORCPT ); Mon, 25 Feb 2019 16:31:24 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D25021841; Mon, 25 Feb 2019 21:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551130284; bh=gq0Oi9dpBb95GHO+PIQ9WbH7wlt021Rvv4MROolwgEU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1C2altXINAt5NC+yt4loLnC7YW+HXCWC1jK4HpPhILnXiwy4NLhjIKqsWngCExXZs jir0FsoGtoVvFnDXjf3bK8hCVzhIxLr2RXBU5h+47wmOeF5Med453kSIwHOdupQA/b AQMJiXs4n9GkSkNly/ZU0FlA77CR8ddvE+mxpaJ0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joao Pinto , "David S. Miller" , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Sasha Levin Subject: [PATCH 4.20 073/183] net: stmmac: Check if CBS is supported before configuring Date: Mon, 25 Feb 2019 22:10:46 +0100 Message-Id: <20190225195106.768318391@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225195054.748060397@linuxfoundation.org> References: <20190225195054.748060397@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 0650d4017f4d2eee67230a02285a7ae5204240c2 ] Check if CBS is currently supported before trying to configure it in HW. Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Signed-off-by: Jose Abreu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c index 531294f4978bc..58ea18af9813a 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c @@ -301,6 +301,8 @@ static int tc_setup_cbs(struct stmmac_priv *priv, /* Queue 0 is not AVB capable */ if (queue <= 0 || queue >= tx_queues_count) return -EINVAL; + if (!priv->dma_cap.av) + return -EOPNOTSUPP; if (priv->speed != SPEED_100 && priv->speed != SPEED_1000) return -EOPNOTSUPP; -- 2.19.1