Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp4917686imc; Mon, 25 Feb 2019 13:36:00 -0800 (PST) X-Google-Smtp-Source: AHgI3IZLiLr3UlCoJljvoSAWmoZYexTJDuQer4e3soSoVw/OQrsHz8u3IT4mSCmb4ypT/h9asifL X-Received: by 2002:a17:902:59c3:: with SMTP id d3mr22494044plj.214.1551130560335; Mon, 25 Feb 2019 13:36:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551130560; cv=none; d=google.com; s=arc-20160816; b=jLnZ+4J+HDxBm8z23p8vloKjr1/tbzeL89UdVhzx4c4jQS+uVWJO+islXerRwWQMUh qN2Wxs/tTbZXzZ7zYNbRF/2egCr3WSaleCdwPVavbDGr0j7v/7kFyHwbP4aJq4FWH/Zg D4LjoZCICw/2FggXExqKcH0196tCqYAJGVtO4D12GrCg4fsZdc1Ae/AWyRjA8PlSQsxh Khns3S2twXm05JKXy5GnWnB+wgCelqCi3DyNRiH4vbaD8jCwxYczRa7Mv5ou0BV8Lkpo KIAZs6MC6+10FagJNGUxw99h/4YE8I/OQPNy90hU8K/0uGrwKIGXlt8avVJtFoVTrFq2 KltA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nrCPXTg5xFOIoqers0yDmCVy7KTCqPUxhddaF6JBsaw=; b=h17wM3ugVrPGgXzXGp2Cs8YTrKO/xNFwYtdFGrCs13RWWt1qjN+VvuXNk/u6cApimk jsBNSw4O+bwQwpEhSn/uMo2nEWGtiuYEwdhah3AUp2CN2Y9N9DRBYKnU+mEIPmsomi9y GXfQUCuKWFpBmzDS3VbJBYkdJRBniWFFgS9BgSpll9wYH8ILWUgKBNrgIKFn8zvPuIRH 9VxAeS/yFag05Ss1qNh8h0HsLVu3znhOvwmGJRvWlY9qtc5PPq6t2PJs1OdpJYjlO6fd G1jqW8eBQGeNPDVl+wc6meX+jDpxg+2R9UjNSvw6aja8ZJjLDNpxtq5fiSnx7LsGcR8s 53KA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GnMozycT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o26si5666345pfi.141.2019.02.25.13.35.45; Mon, 25 Feb 2019 13:36:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GnMozycT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732959AbfBYVfT (ORCPT + 99 others); Mon, 25 Feb 2019 16:35:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:41430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732346AbfBYVfT (ORCPT ); Mon, 25 Feb 2019 16:35:19 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B5B602184E; Mon, 25 Feb 2019 21:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551130518; bh=jqSnSB2+atjEKcucQcy7bRPfc4Q3HmgOGugg54JuQeU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GnMozycTSj2oZnZa+ZlI30Rh4e5GF6+mi2hyo+95ccYjnlwmCAcMzWX8dvosi2VCS zLqXhWU4TeoYV/3oSw0grD84beyW5rA/1EFq/z9LomlBx9N9PLmh6ovTP3oMbnOLGB NxlK1AS0U0nvMT6EgqlgVibpJJO6oE1fawR+lh7U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tony Lindgren , Heiner Kallweit , Sekhar Nori , Florian Fainelli , "David S. Miller" , Sasha Levin Subject: [PATCH 4.20 098/183] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031 Date: Mon, 25 Feb 2019 22:11:11 +0100 Message-Id: <20190225195111.191415397@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225195054.748060397@linuxfoundation.org> References: <20190225195054.748060397@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 1d16073a326891c2a964e4cb95bc18fbcafb5f74 ] So far genphy_soft_reset was used automatically if the PHY driver didn't implement the soft_reset callback. This changed with the mentioned commit and broke KSZ9031. To fix this configure the KSZ9031 PHY driver to use genphy_soft_reset. Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") Reported-by: Tony Lindgren Signed-off-by: Heiner Kallweit Tested-by: Tony Lindgren Tested-by: Sekhar Nori Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/phy/micrel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 51611c7a23d1c..22dfbd4c6aaf4 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -1076,6 +1076,7 @@ static struct phy_driver ksphy_driver[] = { .driver_data = &ksz9021_type, .probe = kszphy_probe, .config_init = ksz9031_config_init, + .soft_reset = genphy_soft_reset, .read_status = ksz9031_read_status, .ack_interrupt = kszphy_ack_interrupt, .config_intr = kszphy_config_intr, -- 2.19.1