Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261674AbUCPNsu (ORCPT ); Tue, 16 Mar 2004 08:48:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261685AbUCPNsu (ORCPT ); Tue, 16 Mar 2004 08:48:50 -0500 Received: from delerium.kernelslacker.org ([81.187.208.145]:6533 "EHLO delerium.codemonkey.org.uk") by vger.kernel.org with ESMTP id S261674AbUCPNsr (ORCPT ); Tue, 16 Mar 2004 08:48:47 -0500 Date: Tue, 16 Mar 2004 13:46:13 +0000 From: Dave Jones To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org, akpm@osdl.org, jgarzik@pobox.com Subject: Re: [3C509] Fix sysfs leak. Message-ID: <20040316134613.GA15600@redhat.com> Mail-Followup-To: Dave Jones , Marc Zyngier , linux-kernel@vger.kernel.org, torvalds@osdl.org, akpm@osdl.org, jgarzik@pobox.com References: <200403152147.i2FLl09s002942@delerium.codemonkey.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 21 On Tue, Mar 16, 2004 at 11:56:37AM +0100, Marc Zyngier wrote: > >>>>> "davej" == davej writes: > > davej> #ifdef CONFIG_EISA > davej> - if (eisa_driver_register (&el3_eisa_driver) < 0) { > davej> + if (eisa_driver_register (&el3_eisa_driver) <= 0) { > davej> eisa_driver_unregister (&el3_eisa_driver); > davej> } > davej> #endif > > This is bogus. eisa_driver_register returns 0 when it *succeeds*. Then the probing routine is bogus, it returns 0 when it fails too. Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/