Received: by 2002:ac0:b08d:0:0:0:0:0 with SMTP id l13csp4922996imc; Mon, 25 Feb 2019 13:43:23 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ8DNaIgxFNy5vhe7heLGXXj6RMu6AHaxSlVUk00T258ejKKYzPMKtA23cMIn51VQEKGaDj X-Received: by 2002:a62:4684:: with SMTP id o4mr1343381pfi.254.1551131003257; Mon, 25 Feb 2019 13:43:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551131003; cv=none; d=google.com; s=arc-20160816; b=wxylZTRM3nJQEkNuUGJRWfF0rVHrQvys02ITeLejgGmDPVxINXVC3q2D2iGrXQjeD9 OrEprvfDHdZ11GnVpjcipqtPHlahQhQpb0D9ZaVyvsHdZ1DCRlf8uqu22Qz/KiW6eCwH DPa1Aj2DFnQZ7M5eK5/ax9as+u75+XlGjBhArdNTzb+/KA/ACj5H/8wOqDx4zsMsvh0U 9W5ct7OimWM0o51SQ/yKMuyH1hTFeje4K5kCtq2j91VnBKA0Pnb+v+w6ibpkcP3eWTU5 8V37yYCblyDPuVB1AEY8IETussNiJV2AX81WatOfqavgVly6fPSRUreyt4CMVetjCxke FxuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6SUxe1OpvdF55ec4FKUdxcjYB6nBqIjgvEhApYrUzMQ=; b=MAw2Is+9LDyQ09geyZUVYv49Hx7afhdrSO9gwOi/lWzxsPB0vu2he55uBydH8yh8Us XyY36kJyZnl0SXWu68/PUdk1zvkmfMZpWto72fm9VBm0O/7pHv0QOU034deCnR+sAqZw drx295A7iJCAbZhBWv1mvK5KLDG0sOnc2GwenQBNh2wqFGeMszReaRFr1ZfiNXfU7aCg wUozgwmKBzlha9rwHd9BPtK1+YyoY4DWl+psxR6Pvh5znWiICw6oflO8VDyO7pfbArQq V8zwTPS6PMVJaqv24ihkuukpm+Y7ssRzoCD18h38HiZ/RwBbUqDJOqOcOXimVBAZQYRD yhFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wus8h0ty; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r12si9680233pgv.293.2019.02.25.13.43.08; Mon, 25 Feb 2019 13:43:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wus8h0ty; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732657AbfBYVdW (ORCPT + 99 others); Mon, 25 Feb 2019 16:33:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:39566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732637AbfBYVdR (ORCPT ); Mon, 25 Feb 2019 16:33:17 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8772121841; Mon, 25 Feb 2019 21:33:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551130397; bh=B0ZcRM1IIUrceEwHc1FGtvEPKBefZtz5FJBOQ7JAa4A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wus8h0tymYfmbaSjXzRAUWx4ySC2xaQWdyjhCPsnwksj0rFAMEqPyZhzarpfc9y/r cySgHWKyoriInXezBul9BaULvqACqPT9VuXzGVjSOB7nPSJriFOKks1bqoWyuQjtv/ Cy9lG4omZeiCpxLDpIIEAiXWpruODfwyiW8QFX4w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , "David S. Miller" , Sasha Levin Subject: [PATCH 4.20 109/183] atm: he: fix sign-extension overflow on large shift Date: Mon, 25 Feb 2019 22:11:22 +0100 Message-Id: <20190225195113.066837128@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225195054.748060397@linuxfoundation.org> References: <20190225195054.748060397@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit cb12d72b27a6f41325ae23a11033cf5fedfa1b97 ] Shifting the 1 by exp by an int can lead to sign-extension overlow when exp is 31 since 1 is an signed int and sign-extending this result to an unsigned long long will set the upper 32 bits. Fix this by shifting an unsigned long. Detected by cppcheck: (warning) Shifting signed 32-bit value by 31 bits is undefined behaviour Signed-off-by: Colin Ian King Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/atm/he.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/he.c b/drivers/atm/he.c index 29f102dcfec49..329ce9072ee9f 100644 --- a/drivers/atm/he.c +++ b/drivers/atm/he.c @@ -717,7 +717,7 @@ static int he_init_cs_block_rcm(struct he_dev *he_dev) instead of '/ 512', use '>> 9' to prevent a call to divdu3 on x86 platforms */ - rate_cps = (unsigned long long) (1 << exp) * (man + 512) >> 9; + rate_cps = (unsigned long long) (1UL << exp) * (man + 512) >> 9; if (rate_cps < 10) rate_cps = 10; /* 2.2.1 minimum payload rate is 10 cps */ -- 2.19.1