Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To:     Spyridon Papageorgiou <spapageorgiou@de.adit-jv.com>,
        "mathias.nyman@intel.com" <mathias.nyman@intel.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "yasano@jp.adit-jv.com" <yasano@jp.adit-jv.com>,
        "REE erosca@DE.ADIT-JV.COM" <erosca@DE.ADIT-JV.COM>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: host: xhci-rcar: Add XHCI_TRUST_TX_LENGTH quirk
Thread-Topic: [PATCH] usb: host: xhci-rcar: Add XHCI_TRUST_TX_LENGTH quirk
Thread-Index: AQHUx3V44GG2oJMDgkW3P8w4U6w2ZKXxzycQ
Date:   Tue, 26 Feb 2019 08:47:37 +0000
Message-ID: <TY2PR01MB481290611E1686E51697FCFFD87B0@TY2PR01MB4812.jpnprd01.prod.outlook.com>
References: <20190218102633.11738-1-spapageorgiou@de.adit-jv.com>
In-Reply-To: <20190218102633.11738-1-spapageorgiou@de.adit-jv.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
received-spf: None (protection.outlook.com: renesas.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 45470d44-47d5-407e-5091-08d69bc70f6e
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2019 08:47:37.6897
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB3515
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

> From: Spyridon Papageorgiou, Sent: Monday, February 18, 2019 7:27 PM
> To: mathias.nyman@intel.com
> Cc: gregkh@linuxfoundation.org; yasano@jp.adit-jv.com; REE erosca@DE.ADIT=
-JV.COM <erosca@DE.ADIT-JV.COM>;
> linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] usb: host: xhci-rcar: Add XHCI_TRUST_TX_LENGTH quirk
>=20
> From: Yasushi Asano <yasano@jp.adit-jv.com>
>=20
> When plugging BUFFALO LUA4-U3-AGT USB3.0 to Gigabit Ethernet LAN
> Adapter, warning messages filled up dmesg.
>=20
> [  101.098287] xhci-hcd ee000000.usb: WARN Successful completion on short=
 TX for slot 1 ep 4: needs XHCI_TRUST_TX_LENGTH
> quirk?
> [  101.117463] xhci-hcd ee000000.usb: WARN Successful completion on short=
 TX for slot 1 ep 4: needs XHCI_TRUST_TX_LENGTH
> quirk?
> [  101.136513] xhci-hcd ee000000.usb: WARN Successful completion on short=
 TX for slot 1 ep 4: needs XHCI_TRUST_TX_LENGTH
> quirk?
>=20
> Adding the XHCI_TRUST_TX_LENGTH quirk resolves the issue.
>=20
> Signed-off-by: Yasushi Asano <yasano@jp.adit-jv.com>
> Signed-off-by: Spyridon Papageorgiou <spapageorgiou@de.adit-jv.com>

Thank you for the patch!

I don't know why R-Car xHCI needs this quirk though...
However, other xHCI controllers [1] also seem unclear why this quirk needs.
So,

Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

[1]
---
commit da99706689481717998d1d48edd389f339eea979
Author: Daniel Thompson <daniel.thompson@linaro.org>
Date:   Thu Dec 21 15:06:15 2017 +0200

    usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201
---
commit d2f48f05cd2a2a0a708fbfa45f1a00a87660d937
Author: Corentin Labbe <clabbe.montjoie@gmail.com>
Date:   Fri Jun 9 14:48:41 2017 +0300

    usb: xhci: ASMedia ASM1042A chipset need shorts TX quirk
---
commit 2597fe99bb0259387111d0431691f5daac84f5a5
Author: Huang Rui <ray.huang@amd.com>
Date:   Tue Aug 19 15:17:57 2014 +0300

    usb: xhci: amd chipset also needs short TX quirk
---

> ---
>  drivers/usb/host/xhci-rcar.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/usb/host/xhci-rcar.c b/drivers/usb/host/xhci-rcar.c
> index a6e463715779..671bce18782c 100644
> --- a/drivers/usb/host/xhci-rcar.c
> +++ b/drivers/usb/host/xhci-rcar.c
> @@ -246,6 +246,7 @@ int xhci_rcar_init_quirk(struct usb_hcd *hcd)
>  	if (!xhci_rcar_wait_for_pll_active(hcd))
>  		return -ETIMEDOUT;
>=20
> +	xhci->quirks |=3D XHCI_TRUST_TX_LENGTH;
>  	return xhci_rcar_download_firmware(hcd);
>  }
>=20
> --
> 2.20.1