Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 26 Feb 2019 10:01:04 +0100 (CET)
From:   Julia Lawall <julia.lawall@lip6.fr>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
cc:     Julia Lawall <julia.lawall@lip6.fr>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        "Sergei Shtylyov (sergei.shtylyov@cogentembedded.com)" 
        <sergei.shtylyov@cogentembedded.com>
Subject: RE: question about drivers/phy/renesas/phy-rcar-gen2.c
In-Reply-To:   <TY2PR01MB4812FA6549BA23233D9670CBD87B0@TY2PR01MB4812.jpnprd01.prod.outlook.com>
Message-ID: <alpine.DEB.2.20.1902261000420.3499@hadrien>
References: <alpine.DEB.2.21.1902030759010.19281@hadrien>   <TY2PR01MB4812FA6549BA23233D9670CBD87B0@TY2PR01MB4812.jpnprd01.prod.outlook.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Tue, 26 Feb 2019, Yoshihiro Shimoda wrote:

> Hello,
> (Sergei made this code, so I added his email as CC)
>
> I'm sorry for the delayed response.
>
> > From: Julia Lawall, Sent: Sunday, February 3, 2019 4:03 PM
> >
> > Hello,
> >
> > I was wondering whether phy-rcar-gen2.c would use dynamically allocated
> > device nodes?
>
> I'm sorry, but what is "dynamically allocated device nodes"?

Device nodes for which there will be a meor leak if one doesn't put
of_node_put.

julia

>
> Best regards,
> Yoshihiro Shimoda
>
> >  If so, it looks like the following code could cause a
> > use-after-free, due to not incrementing th reference count:
> >
> > 	for_each_child_of_node(dev->of_node, np) {
> > 		struct rcar_gen2_channel *channel = drv->channels + i;
> > 		u32 channel_num;
> > 		int error, n;
> >
> > 		channel->of_node = np;
> > 		...
> > 	}
> >
> > On the other hand, if the reference cound it incrememnted, preventing
> > memory leaks in the case where the probe function fails would entail some
> > complex rewriting of the code, so I thought it would be better to ask
> > first.
> >
> > thanks,
> > julia
>