Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp470036img; Tue, 26 Feb 2019 03:21:14 -0800 (PST) X-Google-Smtp-Source: AHgI3Ibkc51CPoNgBj6MdSCM1DZ9dOHk4CdM9GEH1iN1ddrz+2PGgcK5/A//WiyHHxqcvJna02As X-Received: by 2002:a63:1105:: with SMTP id g5mr23955694pgl.322.1551180074221; Tue, 26 Feb 2019 03:21:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551180074; cv=none; d=google.com; s=arc-20160816; b=QKXcBLRr1EitvwljJVktrmW+6Oqwf+afcwNzgrDdep2TlpbqQ4ima+UOfSVjddOYPV 6kEvzubRWhlHoEQ/IfPX3ky5+cErDll2xUHWlTwPGpZQjHXYbphFMcqnVnxHLEC6kT9w WYBlTtCwd0a/mIvQRuA7pKzowhvCneyHyqAulPURD9SV+FPf/3thsd4trwU0S+NODr6r pptioI92qSwynkAKffwPnSB+2U6zObrSw4Zwkre8mg2/kxUNjJXcHcLAydTJK0+SR94y WnSTXfvg9mrQNLyHZ0ZOZzWgOsCl9Cdpu6QUIuBPHaDYVHVkQ5E7Nh10fUS1LTeC9Uwl MRUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=OaodC76JALXtUIjuRuHGDUJvDecMTTCb7+hqp1t28UM=; b=yZp1SfWumMoYo1aNxwYPWBXRCrwUlvwmym7UkUz2aasRJ8kPfLQwKRYl3lWirhfeKa n86jj5rHo7Ah7D7MBbqH4M3iP+j8drTnIz3c3dH5267OFu/6dryhuYRXCnx4VJVemA29 i9la/GsBFrm5awV3q3nOjFL1sM04bxlr/o2/wjXluERpvPrFifxvgiNuu5sOSdP0cjvh DLSf+7fZpFZLSGWN+fwTB3KbhLAZ7mvteZ8x6j2mycxk8AZRWQa7fOCgPZqSoH2+VkrM mNbLiVhY3HgRUlHCjZ3lnocvx6YAslF0qC16qZivg7S5N0uVLGIy+N0twrl8kXkVZmnJ F3rQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OwPJGm6w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d62si12601139pfg.160.2019.02.26.03.20.58; Tue, 26 Feb 2019 03:21:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OwPJGm6w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727643AbfBZLUg (ORCPT + 99 others); Tue, 26 Feb 2019 06:20:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:52080 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbfBZLUg (ORCPT ); Tue, 26 Feb 2019 06:20:36 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16983206B8; Tue, 26 Feb 2019 11:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551180035; bh=FcRxEM0Yzwi9u5pEgsiYMNy/dyfF27NhAUCiHa/VuFE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OwPJGm6wyVjbTPz2tKRUHGe1fh2a0X0DIeU115eUH82uswmUXoTGuv2DbdUWj8RjO MtXyIo6uFiknwgqagL9+6MtEjlonk6eWutOTuNhKIdY/hzuN8MNBmPvi64QMNY9Oov a+OEFVx9ap1WjXTjyEP926FHwgadVguE7pzDZI7I= Date: Tue, 26 Feb 2019 12:20:33 +0100 From: Greg Kroah-Hartman To: liaoweixiong Cc: Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Mauro Carvalho Chehab , "David S. Miller" , Nicolas Ferre , Arnd Bergmann , Rob Herring , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v10 0/4] pstore/block: new support logger for block devices Message-ID: <20190226112033.GA16900@kroah.com> References: <1551162825-28943-1-git-send-email-liaoweixiong@allwinnertech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1551162825-28943-1-git-send-email-liaoweixiong@allwinnertech.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 26, 2019 at 02:33:41PM +0800, liaoweixiong wrote: > Why should we need pstore_block? > 1. Most embedded intelligent equipment have no persistent ram, which > increases costs. We perfer to cheaper solutions, like block devices. > In fast, there is already a sample for block device logger in driver > MTD (drivers/mtd/mtdoops.c). > 2. Do not any equipment have battery, which means that it lost all data > on general ram if power failure. Pstore has little to do for these > equipments. > > [PATCH v10] Why are you still labeling these as "RFC"? No one should actually be applying a Request For Comments patchset, as you obviously are not thinking it is ready to be merged :( After 10 revisions, I hope you are confident in this patchset :) thanks, greg k-h