Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp513202img; Tue, 26 Feb 2019 04:08:57 -0800 (PST) X-Google-Smtp-Source: AHgI3IaXtv3Fv+JzfXKXhwgP5bpYefWLIgCL1arUqKgkJPm/meMKRsXl47mKMOI/XZTGxFyJ59AT X-Received: by 2002:a63:2c8b:: with SMTP id s133mr3602014pgs.448.1551182937209; Tue, 26 Feb 2019 04:08:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551182937; cv=none; d=google.com; s=arc-20160816; b=q+UOSo3c2rXAsIPP2nnb45FIA943aNj82UQtchBU2Cji64Uhu381HE/ZLUXGZ1Ow3r fHmOVnbslDQcidVOAHx0yKjc1jxF2OG+L+Ge9P9Jg6d8NB8RZqrngdFPoPx4jvML1Sy9 XQsjsukTCwrjYn16jMzctpaPbbOrLdJmlihcQYuauZmRot3V17P/iekrW9gsq0oiy+Zq 0V9DhgIjQooJNKqelmyMm/0oITyTs8DeUnOC2y+VO4HLCUzBw4C9AU2Ln+q7R3o1xxaP Dlm/2pkB3/vysBxZA/cAk6e83Nz0mjXFs6FFJhBy4WDuqdPZz2bwuGUl98U4DubeLOH2 LkBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=8WwG5EpFMSrNgd78IwJZ3PTDDs6DXsAYPHWzueLYYsU=; b=FY33ss0TiPEvzoE8F9AYJa4kkiVPdoqvBei2qLD9PL/15hx4QOBSDOsPvZnRhrxCjp wBAEQNFZEwLZ9ggtC2AdLrJKQ/1PH85lAoVHWwPM/OpKhZ+qY6Rq5UbzA+Plr9z6EPHC llrsuCr85Fim6ljcv3o3Mw+gplsV5aWGSIzYmA08/dgHo4Sle5dp+DYuAK+6t0k1RUU0 TYWBvxeF+dlZvcFqSYrtaXDfCqp0YcPSRIiM9825REpbjHdRgh3A20QfXeDJwbv1iiGy 4bfBemBBIzQygPg9BxBtnieJ5DFv2dfSRyeV1FN+8bQFwLkSCO9uPvlvpn0A513J6EdU cNvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d14si11931611pgn.536.2019.02.26.04.08.42; Tue, 26 Feb 2019 04:08:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727133AbfBZMGw (ORCPT + 99 others); Tue, 26 Feb 2019 07:06:52 -0500 Received: from relay.sw.ru ([185.231.240.75]:56678 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727083AbfBZMGu (ORCPT ); Tue, 26 Feb 2019 07:06:50 -0500 Received: from [172.16.25.12] by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1gybVT-0007Vl-OC; Tue, 26 Feb 2019 15:06:43 +0300 Subject: Re: [PATCH 1/5] mm/workingset: remove unused @mapping argument in workingset_eviction() To: Vlastimil Babka , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Rik van Riel , Mel Gorman References: <20190222174337.26390-1-aryabinin@virtuozzo.com> From: Andrey Ryabinin Message-ID: <9c4d34b8-60b5-a05b-c196-b1cc4ecb235c@virtuozzo.com> Date: Tue, 26 Feb 2019 15:07:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/25/19 3:01 PM, Vlastimil Babka wrote: > On 2/22/19 6:43 PM, Andrey Ryabinin wrote: >> workingset_eviction() doesn't use and never did use the @mapping argument. >> Remove it. >> >> Signed-off-by: Andrey Ryabinin >> Cc: Johannes Weiner >> Cc: Michal Hocko >> Cc: Vlastimil Babka >> Cc: Rik van Riel >> Cc: Mel Gorman >> --- >> include/linux/swap.h | 2 +- >> mm/vmscan.c | 2 +- >> mm/workingset.c | 3 +-- >> 3 files changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/include/linux/swap.h b/include/linux/swap.h >> index 649529be91f2..fc50e21b3b88 100644 >> --- a/include/linux/swap.h >> +++ b/include/linux/swap.h >> @@ -307,7 +307,7 @@ struct vma_swap_readahead { >> }; >> >> /* linux/mm/workingset.c */ >> -void *workingset_eviction(struct address_space *mapping, struct page *page); >> +void *workingset_eviction(struct page *page); >> void workingset_refault(struct page *page, void *shadow); >> void workingset_activation(struct page *page); >> >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index ac4806f0f332..a9852ed7b97f 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -952,7 +952,7 @@ static int __remove_mapping(struct address_space *mapping, struct page *page, >> */ >> if (reclaimed && page_is_file_cache(page) && >> !mapping_exiting(mapping) && !dax_mapping(mapping)) >> - shadow = workingset_eviction(mapping, page); >> + shadow = workingset_eviction(page); >> __delete_from_page_cache(page, shadow); >> xa_unlock_irqrestore(&mapping->i_pages, flags); >> >> diff --git a/mm/workingset.c b/mm/workingset.c >> index dcb994f2acc2..0906137760c5 100644 >> --- a/mm/workingset.c >> +++ b/mm/workingset.c >> @@ -215,13 +215,12 @@ static void unpack_shadow(void *shadow, int *memcgidp, pg_data_t **pgdat, >> >> /** >> * workingset_eviction - note the eviction of a page from memory >> - * @mapping: address space the page was backing >> * @page: the page being evicted >> * >> * Returns a shadow entry to be stored in @mapping->i_pages in place > > The line above still references @mapping, I guess kerneldoc build will > complain? > Maybe. Will replace it with @page->mapping->i_pages