Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp561270img; Tue, 26 Feb 2019 05:00:59 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ9yTiGLKfhogDRslO9dK6gIfdjus7mjNxkODyzrz9xdvloJLpVkVWZyfmX5YZfeGncvoef X-Received: by 2002:a63:d70a:: with SMTP id d10mr24139134pgg.286.1551186059031; Tue, 26 Feb 2019 05:00:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551186059; cv=none; d=google.com; s=arc-20160816; b=N5EjaZg/f4Tq/5YR79DWnlWDqmi99M/dUzbUK/TrsROJENBXuj+503bj8ybxC8Sgt4 53Uh3Iyq0ZrhkuNV+1YIbtejKqoZTsJPQT7lzjzEV4HERT3yxt/5LHsi8llA6U4ljl9v BOS/sHLunY117BcPTw3ODrzh4ZkZFOgIKUW08zIufxkzFOctzvKGdVcdMH5TfCxc8/Y1 /3KTC/G302ehuOQwvRGeQmuEIj1H8n3rSj29xFvkHl53s92nUSFk+P+KUSwKvLHzISZO 7TCBhNuBBC4w7oxkOTp9H48U7A8l+5zbUPwOcz2MJbpuG0ng4eE1v9yhTGeo08CdJmEH 996w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=j8h6kEd36XZA0W1ta6d86WO4PPXq666Fw8Odg1HSHWE=; b=X7l3FQUDCQkLNFRn1sIDVAMT6+hiUiG5YGSRiK/swyqu5BEqDi1IsmqJzQy9piF1B4 A1ExfNGJNFcltTtEAqE7E9eKG2nu55SorDTvpt6LvCSEuzqaoZVc34mLd8ibsjhLqXs6 S3O3pOyeClSKGirW2YJmtiN/HTVS97WsfllIiNMTpLmhfnDhQQLodt3auHu7BrKIkJKG 6MkeU/Y5IM+XQ8JKhJarF5ZnKO/9ZSazbJ+NJ4RUh6Kt70Px+FuKTqpljcyMj8j+HyFu ej7LxPIEyrRi+C/1+RowzDSZ4eL8MTFYyC2136QwHewHFNyv64HlMQcw0BJgkf5MED8L Q4lA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iJj1haDe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j7si12853068plb.349.2019.02.26.05.00.43; Tue, 26 Feb 2019 05:00:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iJj1haDe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726903AbfBZNAP (ORCPT + 99 others); Tue, 26 Feb 2019 08:00:15 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:32827 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725954AbfBZNAP (ORCPT ); Tue, 26 Feb 2019 08:00:15 -0500 Received: by mail-pl1-f195.google.com with SMTP id y10so6242968plp.0; Tue, 26 Feb 2019 05:00:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j8h6kEd36XZA0W1ta6d86WO4PPXq666Fw8Odg1HSHWE=; b=iJj1haDeQ/N4knB6ZkfPIbBBikEijc4XMQEhvso+uGw3Gzonlx2LMHbxDNhxdOsLO5 9/RC7drvjRuaIn9F0S3cLM0+Nf2VDOHoOBcPVpE04JoO4DDFvYHnfNhs3GM3TDepBHHL x3uKoOE/K+vdpA+YGX5nfTLL8rGudeiuruGtiPzknZPEsi1M+w74lrRcVnhePEkZKzSm hnJ+9/urf6gLp/t3HOljNrg3FSXuSCHaFrniZmdn16YbkBYxmGnUX+M73aEZGT3um4Zl RvuLmLpg/dPuOkvCJnfMcBVQMFa+KO/Cdp+mtyFhSiUVeuti7z0gGmnmt7LRbfq0Bfzj OJTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j8h6kEd36XZA0W1ta6d86WO4PPXq666Fw8Odg1HSHWE=; b=Y0B8Z9vxtSHyJEzOBxcOwrGpIUKsegBzq6zVqhwfeomkhC77PVaPz/fzhImeXX35vU fZ6SZv2p5NSPUzbLaEEVA2mrnTsy57oGTvUKj3cbCilRF7ucehqiCM31mCASC9HpOLXm JBlCtz7iZ8amcxYaWq9PKwoD9GBzyNIeR1sx0ZH6SwIqJC6V9Yqh3t1IgXdRfgI/sp/E qvgmAHLO2h3GcB/mzBNSX1rEhsoZA7ShRQDLZn0STS4DIo5lPGujo7rCq+TkdswuTeyg dUwBFfqntpXh3K+SpmWbUFdxqW99WgEDg9uVJ+UuC4kNBJc2Z4aHHXSrPMpq7beFVoJU bUbw== X-Gm-Message-State: AHQUAubwimAGQzzEhklKuSaqSM7TRxa1+NRK/O8yY5CxtByMoCJvVcxP zdnjEzqb9KGEu8v4qb45DNJ2yjADyoVBBTEqvkU= X-Received: by 2002:a17:902:8b8b:: with SMTP id ay11mr26134560plb.162.1551186014272; Tue, 26 Feb 2019 05:00:14 -0800 (PST) MIME-Version: 1.0 References: <20190222150637.2337-1-Tianyu.Lan@microsoft.com> <20190222150637.2337-2-Tianyu.Lan@microsoft.com> In-Reply-To: From: Tianyu Lan Date: Tue, 26 Feb 2019 21:00:03 +0800 Message-ID: Subject: Re: [PATCH V3 1/10] X86/Hyper-V: Add parameter offset for hyperv_fill_flush_guest_mapping_list() To: Stephen Hemminger Cc: Tianyu Lan , "christoffer.dall@arm.com" , "marc.zyngier@arm.com" , "linux@armlinux.org.uk" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "jhogan@kernel.org" , "ralf@linux-mips.org" , "paul.burton@mips.com" , "paulus@ozlabs.org" , "benh@kernel.crashing.org" , "mpe@ellerman.id.au" , KY Srinivasan , Haiyang Zhang , "sashal@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "hpa@zytor.com" , "x86@kernel.org" , "pbonzini@redhat.com" , "rkrcmar@redhat.com" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "linux-kernel@vger.kernel.org" , "linux-mips@vger.kernel.org" , "kvm-ppc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "devel@linuxdriverproject.org" , "kvm@vger.kernel.org" , Michael Kelley , vkuznets Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen: Thanks for your review. On Sat, Feb 23, 2019 at 1:08 AM Stephen Hemminger wrote: > > int hyperv_fill_flush_guest_mapping_list( > struct hv_guest_mapping_flush_list *flush, > - u64 start_gfn, u64 pages) > + int offset, u64 start_gfn, u64 pages) > { > u64 cur = start_gfn; > u64 additional_pages; > - int gpa_n = 0; > + int gpa_n = offset; > > do { > /* > > Do you mean to support negative offsets here? Maybe unsigned would be better? Yes, this makes sense. Will update. Thanks. -- Best regards Tianyu Lan