Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp600855img; Tue, 26 Feb 2019 05:38:05 -0800 (PST) X-Google-Smtp-Source: AHgI3Ib9/bGU82HPPZ46ApHD5mK2bGVaEC+Guzz68zmyRFODtUX+GmB2bTErQUSQ0ZFAcMr6TIuT X-Received: by 2002:aa7:83ca:: with SMTP id j10mr18212333pfn.50.1551188285683; Tue, 26 Feb 2019 05:38:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551188285; cv=none; d=google.com; s=arc-20160816; b=EG9Mzpdk/DUvFx7BPyJh4k5BDzuumVqJaBtuiR+BMsmw71j/vdVndS672EMXkrZWgx DSnOBmxLinF8Dzt7KkVKbjl75cbOK0cUGZMGGChs9TyaQkS0xGttAYHyxKqgieBfshte 0SOsU+MqByCP7YK/XJGs4LWhMPdq+8lfljRfui+DioY9lXdF5D41swQNuGf5s5CmY07p NbbJviDmqJBvf1XmtgV0GRccMlSJW8ljbM7qJFn42YWajJ6jTZ5fLKVFQ48bXRNwM1hd fTlW0mXDjJLvZHSiewSzoNBvg5jBnw3u+0bjB8TQufef77K9pQnw5hI6JFHZetH/JDge 1VKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=JSjDv4hcZl88gGGx2mHdRSPb6viE4KjMCMgatmCI9xE=; b=coTb1viqhxRJbVTYhdGABllEzOBPC4x5IdGc4JVzPJQ9sqgdt82GVXhOJOasjkmh/N Rd97kFyf5rN2TMo5HfySnH0xgl/xYcruv8sdjc9VwsQShbJWA7HSaMoSWcGN6vfC0WRp F7mUMd4tBdfq1ZSehO+Mf9IPgNQmBE0hxyPhE0jNEZC40WQ9E+uwM4GqEfUDzTygkpw/ mP9SX6l0G6WdLHLMaXr++RKTpNgJB9h2OggujW9ljcDhxd3eaoBwkrtBPckZG5SW+syu 9FBT7Lfdq+QUpv6cvCuQ61uR7In0UFhPg+EUwRs7XwuL2wSWOBXHEogZDHS5Vqp9EZR6 3Mhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="fMMRqSk/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q4si11566765pgv.338.2019.02.26.05.37.50; Tue, 26 Feb 2019 05:38:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="fMMRqSk/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726553AbfBZNha (ORCPT + 99 others); Tue, 26 Feb 2019 08:37:30 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:39227 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725954AbfBZNha (ORCPT ); Tue, 26 Feb 2019 08:37:30 -0500 Received: by mail-oi1-f195.google.com with SMTP id b4so10313061oif.6 for ; Tue, 26 Feb 2019 05:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JSjDv4hcZl88gGGx2mHdRSPb6viE4KjMCMgatmCI9xE=; b=fMMRqSk/AjRdW1IzGTCaSeXiaEvT/z+oxDIeEb3SWbtdlVQvXoFHQYqLGPyRD2VI5B eqxgTkngbFipQJkrmsIfvink6ss6TS1jCWVd/V9abbs13mqFd4aL/uwfwEoQLu9vf/RI W/dMCI6Ud1A3wygCFvy6vwW+bld0nPjZxHv+68lyMCTszsdw5pTZ+7lSkDFTN18DBMOK DpTtRLbVPg46FBpKyYWOAXWZZXUmE4zR/ECoB7lcOwSwap/9qe/Ps/BpU1Rf4oHdIXQu XDzbKzlzYvqW5dEwwRpo7pxZhiEo54cU+imxUSfLg8OX/Pe0nNcgr8yQEZ2i84O//rlX yDjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JSjDv4hcZl88gGGx2mHdRSPb6viE4KjMCMgatmCI9xE=; b=BoJjLViUGGy1X/IrtTwaWSGmZ4MbXlcgy6LhGDz9EQiwUmkSgJLkexyxrNuZNepmjt WCOgBrfMCcFPOk/D5N3mXDCoC8GrrQXf9dLe8tVL7Yuh14blNCpudMcHayAleGlKEekt Rsxx5FGeO50VQldI3Vq6T8nSIUQ1aSPxTvAOhGa7ygI89OS/AoxWfyfgKZSZmh5ic2UI c+qC0KMWCcXWCV7qwotylPIzQ9ql2V+SNEgV5u4pQ/tHVFt8GS5y2xgPz9fwsF5Kk9cL RZyu17vlFEJcCn0BMVc72gkwtHHJhKpvEQGzsrqS7/VmPyouu9S3EiOc6/DHlncp7Gha gg/Q== X-Gm-Message-State: AHQUAubGrPGXmiFG7OyxYrAbijInlRKNvPVtNcAxEk254NibwywNKcVs 2ISgpZ7A/NtGDf5C7/Kg1InYTZ5WFYXyjX14z+I= X-Received: by 2002:aca:b5c1:: with SMTP id e184mr2359488oif.75.1551188249238; Tue, 26 Feb 2019 05:37:29 -0800 (PST) MIME-Version: 1.0 References: <1551178385-14572-1-git-send-email-abel.vesa@nxp.com> In-Reply-To: <1551178385-14572-1-git-send-email-abel.vesa@nxp.com> From: Fabio Estevam Date: Tue, 26 Feb 2019 10:37:18 -0300 Message-ID: Subject: Re: [PATCH v2] soc: imx: Add generic i.MX8 SoC driver To: Abel Vesa Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , Stefan Agner , Chris Spencer , Lucas Stach , Rob Herring , Abel Vesa , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 26, 2019 at 7:53 AM Abel Vesa wrote: > + magic = readl_relaxed(ocotp_base + IMX8MQ_SW_INFO_B1); > + if (magic == IMX8MQ_SW_MAGIC_B1) > + rev = REV_B1; Don't you mean rev == REV_B1; ?