Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1551178385-14572-1-git-send-email-abel.vesa@nxp.com> <CAOMZO5AmRAhxSw2KB-LBY68a+DvVSKPQ1ecAf_YPhQhBAdJ1UQ@mail.gmail.com>
In-Reply-To: <CAOMZO5AmRAhxSw2KB-LBY68a+DvVSKPQ1ecAf_YPhQhBAdJ1UQ@mail.gmail.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Tue, 26 Feb 2019 10:38:28 -0300
Message-ID: <CAOMZO5AC+Zna4oYTk7Er-2SpbQayhmeyrbhpZM-wFfO6axcFVQ@mail.gmail.com>
Subject: Re: [PATCH v2] soc: imx: Add generic i.MX8 SoC driver
To:     Abel Vesa <abel.vesa@nxp.com>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <kernel@pengutronix.de>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        Stefan Agner <stefan@agner.ch>,
        Chris Spencer <spencercw@gmail.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Rob Herring <robh@kernel.org>, Abel Vesa <abelvesa@linux.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 26, 2019 at 10:37 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Tue, Feb 26, 2019 at 7:53 AM Abel Vesa <abel.vesa@nxp.com> wrote:
>
> > +       magic = readl_relaxed(ocotp_base + IMX8MQ_SW_INFO_B1);
> > +       if (magic == IMX8MQ_SW_MAGIC_B1)
> > +               rev = REV_B1;
>
> Don't you mean rev == REV_B1; ?

Ops, was looking at the wrong line, sorry :-)