Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp654953img; Tue, 26 Feb 2019 06:30:02 -0800 (PST) X-Google-Smtp-Source: AHgI3IbzKWLGI5tEotkCy7GNb8N2Pl3zI0W/rIWxPNa9z+iSogRQXeZis6Frfwl4IBjJCk9KZl61 X-Received: by 2002:a17:902:284b:: with SMTP id e69mr25722083plb.11.1551191402926; Tue, 26 Feb 2019 06:30:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551191402; cv=none; d=google.com; s=arc-20160816; b=M6KXoVnpkI+TGdOphJjmZHs1ic4jAbAvx3f+dkup1YuuPWJITxAprUBUxgpN3h9jGp tFIbei4det5lsmUeD1RxHbmgYelepn+mIhxSE2jX7Ubm+Zjca8m7NJHD66dqs64Ps0o4 s3nLDvBrjx0TKtZ4lFxx1PChnnMUSnY2O5sW+qhIMfWYvbppbmRBkM++WQz+CzOFSltD oJ1a+mYrQwKJvDcDVOvt094JZoZ8ZaHgqGuL5C3NjOoUX24nQary0cqBViel9nS60bZS 4/KAMR5ecuSAW3MvvvPoWx0KpBbFjsRFkB1JACR2ATkqD4gaNFeup323JlEzE9nNevek Y/nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IPrTm242wR0IJ/SrRtjoA9/YK8tKTdVfJB2ouAVLDBs=; b=d/maOav9hwZvR7Of6ndJLBW34ChOaQtl2sFiUrK7pbRkvwZ2AA9aNUWKNOKt0oy1Rk jw91z88bFA7vfyfiPF19njSkWWHi8/qfkRh0nCMGGijgYkv0Tbwu8tlavx1DKqQpmfp0 bVnBTnEiy8nPBpCOG2G+a5da7c03LRevPZDMDnR79ztMD6XMjPptVhO6s3mJifcuKgyN YcvWlWze2fuvp9h222AqSyXtFhW3NToyl65qUlWyxLC7P+qReBhuokpYhxlbebpDH3d9 Cz6/52vBxoKuAoXhJW/lBuOX+jELwqyzPeTZ1Zex3ovf15JnK2ZIgF1MTS15oewCdr/1 LTYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aogqmpbv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y40si2691931pla.205.2019.02.26.06.29.47; Tue, 26 Feb 2019 06:30:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aogqmpbv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727406AbfBZO3W (ORCPT + 99 others); Tue, 26 Feb 2019 09:29:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:43558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbfBZO3W (ORCPT ); Tue, 26 Feb 2019 09:29:22 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3EBEE20863; Tue, 26 Feb 2019 14:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551191361; bh=nf1Wf0q7vxNMlqz95M/YOgQNPju9HwyB+Yok2j5G/Gc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aogqmpbvSbNh56S2pccExd7Wv9MqVAIgD5m5UJ9oxcCSz6U0lmXE7ajnIZ4cOYFqf sQbPjgP2izinYua7fsD8yw73Q69UZJdDfzZEpn7QqvAml2lejit8Pz0nPi1tn4ZP++ tHasKw5VgWxD3QRt10WJGJ0uMeAYLr9Pd5AskZbw= Date: Tue, 26 Feb 2019 09:29:19 -0500 From: Sasha Levin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Russell King , "David S. Miller" Subject: Re: [PATCH 4.20 129/183] net: sfp: do not probe SFP module before were attached Message-ID: <20190226142919.GG10616@sasha-vm> References: <20190225195054.748060397@linuxfoundation.org> <20190225195116.455060281@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190225195116.455060281@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 25, 2019 at 10:11:42PM +0100, Greg Kroah-Hartman wrote: >4.20-stable review patch. If anyone has any objections, please let me know. > >------------------ > >From: Russell King > >[ Upstream commit b5bfc21af5cb3d53f9cee0ef82eaa43762a90f81 ] > >When we probe a SFP module, we expect to be able to call the upstream >device's module_insert() function so that the upstream link can be >configured. However, when the upstream device is delayed, we currently >may end up probing the module before the upstream device is available, >and lose the module_insert() call. > >Avoid this by holding off probing the module until the SFP bus is >properly connected to both the SFP socket driver and the upstream >driver. > >Signed-off-by: Russell King >Signed-off-by: David S. Miller >Signed-off-by: Greg Kroah-Hartman This one got fixed by 87454b6edc1b0143fdb3d9853285477e95af74a4 . -- Thanks, Sasha