Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp668941img; Tue, 26 Feb 2019 06:43:40 -0800 (PST) X-Google-Smtp-Source: AHgI3IbLdR92zZP1zey+6p0P44JoHKMi9KGmkI55S0ZO8iVFRd5YK/v00S2xHsphTKfus8CyI/XG X-Received: by 2002:a62:4684:: with SMTP id o4mr5301623pfi.254.1551192220394; Tue, 26 Feb 2019 06:43:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551192220; cv=none; d=google.com; s=arc-20160816; b=E0kuVcV9tImVlRceLF446AodRya9g0x1MNafpoComq6jMF0tH94rONxVSvzTDp+1QP QY8ZmQmsSJEQULOcjgFTmsYKUCiFdkpNaUTZhKuPxcNqhWjsqh/ggmIOzCbUFV75wVah BpJBHFinQFW8NlWyQmUGPul0go6JlMnTFRYIkRkZoP+7ymPjEBSVez6kqEv3jKYWOgcv FXDs859u/lbyH+6C/9Rpg4y+xDo8r53/aX6WAsX4JEvIlv8SQ1drLFdtnOz3zLmkn8Fv RGhXcfmvz0gg5U/zcTReKk9I5KQ/2FqbbqrmhHXCO0IkWsAE5wOgBgmZp/Iyx+QV1uMk qDYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to:date :cc:to:from:subject:message-id; bh=M+j68POGamg6UGMdkb4TuBEO8+FAMEX8znScuT/RnAw=; b=vnMVPesnutIFnzh+ex70E3Xg4nDi+FPMk4SBSOHVUe/Xnums79kQlNYmtvazlBufHh 3PKFdZOoq9aomyeZYprQ4ZUx+p+f6yr0zUrNVDR1vTX/XT5eJ9bePaJHUZ0uMSK5xmvs oYjQII4QzoGNl+nXEZTPpblUp14ztvXMwu41o8shB56zG1X8kabNFhTlw+Opl1uHVbOx KPb79Lln7VUbLrYIGHfeQwhp0sCESThfSld41Vkf8CXsIpEJlN1re3rchSZQu4K2IIFZ Pw5Ys7kRlgzr6aRdmqYzx8g867UiqxJL92Kbl7UuTysFwDo1N0IAunY/PyPRP9DiPHxT lxdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f3si8588484plo.369.2019.02.26.06.43.25; Tue, 26 Feb 2019 06:43:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727519AbfBZOnA (ORCPT + 99 others); Tue, 26 Feb 2019 09:43:00 -0500 Received: from shelob.surriel.com ([96.67.55.147]:42856 "EHLO shelob.surriel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726965AbfBZOm7 (ORCPT ); Tue, 26 Feb 2019 09:42:59 -0500 Received: from imladris.surriel.com ([96.67.55.152]) by shelob.surriel.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gydwT-0002az-OQ; Tue, 26 Feb 2019 09:42:45 -0500 Message-ID: <63491909d5c7011b946a354000caace11d63cb84.camel@surriel.com> Subject: Re: [PATCH 5/5] mm/vmscan: don't forcely shrink active anon lru list From: Rik van Riel To: Andrey Ryabinin , Johannes Weiner Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Vlastimil Babka , Mel Gorman Date: Tue, 26 Feb 2019 09:42:45 -0500 In-Reply-To: References: <20190222174337.26390-1-aryabinin@virtuozzo.com> <20190222174337.26390-5-aryabinin@virtuozzo.com> <20190222182249.GC15440@cmpxchg.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-WS/NIoxTuxo0S9rJ9C/P" X-Mailer: Evolution 3.28.5 (3.28.5-1.fc28) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-WS/NIoxTuxo0S9rJ9C/P Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2019-02-26 at 15:04 +0300, Andrey Ryabinin wrote: > I think we should leave anon aging only for !SCAN_FILE cases. > At least aging was definitely invented for the SCAN_FRACT mode which > was the > main mode at the time it was added by the commit: > and I think would be reasonable to avoid the anon aging in the > SCAN_FILE case. > Because if workload generates enough inactive file pages we never go > to the SCAN_FRACT, > so aging is just as useless as with no swap case. There are a few different cases here. If you NEVER end up scanning or evicting anonymous pages, scanning them is indeed a waste of time. However, if you occasionally end pushing something into swap, it is very useful to know that the pages that did get pushed to swap had been sitting on the inactive list for a very long time, and had not been used in that time. To limit the amount of wasted work, only SWAP_CLUSTER_MAX pages are moved from the active_anon list to the inactive_anon list at a time. I suppose that could be gated behind a check whether or not the system has swap space configured, so no anon pages are ever scanned if the system has no swap space. --=20 All Rights Reversed. --=-WS/NIoxTuxo0S9rJ9C/P Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAlx1UGUACgkQznnekoTE 3oOZwwgAkmPl1r/i+agIxCVMrx4XQvkeXk9zU3Cem8xsvmsAcq62iaA/hfJKEukA N3I5NOYQp7ZqP0niwFBNt3koIerq/jahFHSdVEoF0GMdiV+p/Jykx4ntSU0IcEAq +HRSd2JpMO9XcZyJc/ZdRTyrMPQj/6YbYvfSULbRpBceZ3tY3bGZd0/5lgJjL82c YxqLNUiC7vS6lBZujMf+M5RE0IrhKkGewBs908aYQ1FY7HmYhqN4JzcTu6t4hDJ+ xKVdppUk6nhUTqPMv7RH8Gfg7px6XBkxGDTStuvHCQ/m35F6OxGpTRAPFa5iNFv1 +lqGz79wqx80ceDPB68CHqizXBoHpg== =5brM -----END PGP SIGNATURE----- --=-WS/NIoxTuxo0S9rJ9C/P--