Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp671114img; Tue, 26 Feb 2019 06:45:54 -0800 (PST) X-Google-Smtp-Source: AHgI3IYiTfJSrjFFyxD1ladNHm99UA57Bm85ggP9eRWOL3dkUUP58JsbtJKE6tagkmwv/TQX7t2X X-Received: by 2002:a63:8942:: with SMTP id v63mr24011030pgd.406.1551192354457; Tue, 26 Feb 2019 06:45:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551192354; cv=none; d=google.com; s=arc-20160816; b=XVLTB4MGvYEVM5s3VUKnS1mHIw83phvUFL4atcIJSYu3VW/a3QdlgMX5QS06UNECR7 oFpbmnP5RppP9tiuHk8T5Mq6eB9XC+myJSyJob5ketdnJmmqlLl8fCey46IAWDNXaOiA mNUfKlHBEo0Gt9CNrURfYqXQjPGr4hp3dnfxUxLbGeeKL8PQRQwjnVuKdCLORzqf8QTF xslHFge2h89SXwJug12Z6DjnLcnYQpeQevYdtjt2smifiofuxCFq+gMeaUbGKSS7mxIe as2vyE2kiWlhEbJKD7vLaiecog4vv19f7jcfd/17bz6lo2brAHAVeeGmkqyKF4N+DDWZ AI1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=FvqUS6HLcwbvGiWMYvMUjculPVb3zQRPYyerqmWMhBU=; b=WP8+Ip6fdQE8HshDRxauVAwIqHtVUog5FXM3+D4kmyo8QNXcWdnzuKDgppCYu0fgAQ 5Rqt3jrKuK2TqJp5MsVFV3l1tpCfyu4j3U+WdOTU+xaYawtOhivk+hR7n1/4S4fR2aAV ndTAaYmDwZRZlD1P91czZd7Pd3rj9iA8lOlvY7L5vFrpWk5JpaqTl9TAZ5PMOpO1ViWw 12+YNzItDaVc2J10wB3rTmLG3YJeO2WyH65UGYyqqcrnYpRpDkbqdGwUCVmGoNlqaOPd NBQSob8Yx8Lnh/P0wKKopg/USY3Q2O7th49bfVSbTpzWKgGak/qOtT9CpZ1Ng/h3Rh8u KvhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=04kC3EaQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e9si12275419pgk.173.2019.02.26.06.45.39; Tue, 26 Feb 2019 06:45:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=04kC3EaQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727616AbfBZOou (ORCPT + 99 others); Tue, 26 Feb 2019 09:44:50 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:53548 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726099AbfBZOot (ORCPT ); Tue, 26 Feb 2019 09:44:49 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1QEYQ60136144; Tue, 26 Feb 2019 14:44:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=FvqUS6HLcwbvGiWMYvMUjculPVb3zQRPYyerqmWMhBU=; b=04kC3EaQt2SnxjzBnrzcjHqIHgE3JzIvW9VFackxtKqLMFzVNhY7LPOJltg6I3Ci/yjk WuvVCVSYm697Dct7WN3/ZtDLGOG7AotYb4UifYHOvXvr0Qzzm4yKB8ZMUbBE8Y/+heK3 OSlJyLD+S6NvpFrvjtmkI9ZkyXPqc7hznnTdYJVIJvlgl1C0MZbspdyWQU4MAVWWW4uX /edF2WRC5sfwVlghGzsDwL08pRTPUcln1aXnvVpzItTJUnSArpgLEgSrlrrVqwnlLsd/ HTIl7g0Zsa9/R4w+iL8mi4BScKcBOxjnb6CETSaSCRQK5FHZfKkbayVmnPQ1aS0k1Ft3 Cg== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2qtxtrmvpa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Feb 2019 14:44:31 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1QEiUeV011074 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Feb 2019 14:44:30 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x1QEiQI3010451; Tue, 26 Feb 2019 14:44:27 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 26 Feb 2019 06:44:26 -0800 To: Marc Gonzalez Cc: SCSI , LKML , Jeffrey Hugo , Bjorn Andersson , Evan Green , Douglas Anderson , Alim Akhtar , Avri Altman , Pedro Sousa , Joao Pinto , Mark Brown , Liam Girdwood , Rob Herring , Bart Van Assche , Stanislav Nijnikov , Alex Lemberg , Ohad Sharabi , Venkat Gopalakrishnan , Subhash Jadavani , Yaniv Gardi , Gilad Broner , Raviv Shvili , Hannes Reinecke , Kyuho Choi , Martin Petersen Subject: Re: [PATCH v5 1/2] scsi: ufs: Do not disable vccq in UFSHC driver From: "Martin K. Petersen" Organization: Oracle Corporation References: <494cd639-89a7-8868-b63a-ea7cdcba9777@free.fr> Date: Tue, 26 Feb 2019 09:44:21 -0500 In-Reply-To: (Marc Gonzalez's message of "Mon, 11 Feb 2019 14:32:15 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9178 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=662 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902260107 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, > Commit 60f0187031c0 ("disable vccq if it's not needed by UFS device") > introduced a small power optimization as a driver quirk: ignore the > vccq load specified in the UFSHC DT node when said host controller > is connected to specific Flash chips (Samsung and Hynix currently). [...] > Revert the original patch, and clean up loose ends in the next patch. This commit isn't a revert. Why not? -- Martin K. Petersen Oracle Linux Engineering