Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp673936img; Tue, 26 Feb 2019 06:48:58 -0800 (PST) X-Google-Smtp-Source: AHgI3Ib+GyTi2z5IU+xJquRZF3jKvBkP7vyV13M/eW9TVDe2h7jMg6HpacTwr2qvrjSyyprOJbOH X-Received: by 2002:a63:40c1:: with SMTP id n184mr23681739pga.225.1551192538376; Tue, 26 Feb 2019 06:48:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551192538; cv=none; d=google.com; s=arc-20160816; b=XuEioPIGEfprDCqRrMz6kHQVYxzL4RT4urUuokqraRxM+M85Af9OH3yYBDKi07D55b 9K7uwnZp5LU4xk6rgL3WX3pY5Ae0BTtyP5s3C3XP7qv8RmRLSpAXwxrED7QzIaxPoJG5 Be16zRuGf9NnRiAuDG+2HkN2VfGdz+8tNdlHXEFxP5pNpwwEapX+ZbiKMjKFBHDs1n2r GENlIxVFNsVY3/WkGU0V3WBtczrHQPrhBX3tiWfCMLcZZfa/vKuCyP8xy7A39f2Q+8Vx IEhnLvNohcbCf0IUM1nVLbIXUpzo5NXm+sTmxnnJuQ3dydZXpNrE31Y7a2hXP1/dnm39 wasg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=0IVSeZsAA4A5sRHJfJtez1+UdjEpuG4AR3WolkXCNzQ=; b=byG0a8MGEOCYvQRrYXixlrNQaMZQci6FSGIL6DdB1Yju5aj57vR11VhPUEEl8UFl97 wO0yNQeWA5LulTUUS2Uw1Tv4Hh9VRvs7r0l//jq/cxE2OFVBOz2CALIiDBpfrWxrCNc5 sjkEYz8q3bP93iL1n5T5yvDrz1mP9+p+LafY7VDCL9Ngwx+GcpJVQcv2uYmdw1qPUGXb 5kRwzXJuefu5Ne4XRPfB/VZbS+yssR0SJ4k1F3knk5cyBh9Ym1jEepYpE5emGuCCZtNm ST8Is5OmJt7ziphr16/tWA8FxmcdhTb8jGpY0+ydEDfaMUwCx7+cN9hAtYpDUPSs7mX+ WCLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y16si12319669pll.83.2019.02.26.06.48.43; Tue, 26 Feb 2019 06:48:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727768AbfBZOqy (ORCPT + 99 others); Tue, 26 Feb 2019 09:46:54 -0500 Received: from smtp3-g21.free.fr ([212.27.42.3]:11514 "EHLO smtp3-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726965AbfBZOqw (ORCPT ); Tue, 26 Feb 2019 09:46:52 -0500 Received: from [192.168.108.68] (unknown [213.36.7.13]) (Authenticated sender: marc.w.gonzalez) by smtp3-g21.free.fr (Postfix) with ESMTPSA id D70B813F89E; Tue, 26 Feb 2019 15:45:58 +0100 (CET) Subject: Re: [PATCH v5 1/2] scsi: ufs: Do not disable vccq in UFSHC driver To: "Martin K. Petersen" Cc: SCSI , LKML , Jeffrey Hugo , Bjorn Andersson , Evan Green , Douglas Anderson , Alim Akhtar , Avri Altman , Pedro Sousa , Joao Pinto , Mark Brown , Liam Girdwood , Rob Herring , Bart Van Assche , Stanislav Nijnikov , Alex Lemberg , Ohad Sharabi , Venkat Gopalakrishnan , Subhash Jadavani , Yaniv Gardi , Gilad Broner , Raviv Shvili , Hannes Reinecke , Kyuho Choi References: <494cd639-89a7-8868-b63a-ea7cdcba9777@free.fr> From: Marc Gonzalez Message-ID: Date: Tue, 26 Feb 2019 15:45:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/02/2019 15:44, Martin K. Petersen wrote: > Hi Marc, > >> Commit 60f0187031c0 ("disable vccq if it's not needed by UFS device") >> introduced a small power optimization as a driver quirk: ignore the >> vccq load specified in the UFSHC DT node when said host controller >> is connected to specific Flash chips (Samsung and Hynix currently). > > [...] > >> Revert the original patch, and clean up loose ends in the next patch. > > This commit isn't a revert. Why not? What do you mean?