Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 26 Feb 2019 16:01:28 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Sasha Levin <sashal@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Russell King <rmk+kernel@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 4.20 129/183] net: sfp: do not probe SFP module before
 were attached
Message-ID: <20190226150128.GB28178@kroah.com>
References: <20190225195054.748060397@linuxfoundation.org>
 <20190225195116.455060281@linuxfoundation.org>
 <20190226142919.GG10616@sasha-vm>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190226142919.GG10616@sasha-vm>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 26, 2019 at 09:29:19AM -0500, Sasha Levin wrote:
> On Mon, Feb 25, 2019 at 10:11:42PM +0100, Greg Kroah-Hartman wrote:
> > 4.20-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Russell King <rmk+kernel@armlinux.org.uk>
> > 
> > [ Upstream commit b5bfc21af5cb3d53f9cee0ef82eaa43762a90f81 ]
> > 
> > When we probe a SFP module, we expect to be able to call the upstream
> > device's module_insert() function so that the upstream link can be
> > configured.  However, when the upstream device is delayed, we currently
> > may end up probing the module before the upstream device is available,
> > and lose the module_insert() call.
> > 
> > Avoid this by holding off probing the module until the SFP bus is
> > properly connected to both the SFP socket driver and the upstream
> > driver.
> > 
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> This one got fixed by 87454b6edc1b0143fdb3d9853285477e95af74a4 .

Thanks for catching this, I'll go queue this up now.

greg k-h