Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <333cc78c-7537-7898-d753-17352df893aa@gmail.com>
In-Reply-To: <333cc78c-7537-7898-d753-17352df893aa@gmail.com>
From:   Jouke Witteveen <j.witteveen@gmail.com>
Date:   Tue, 26 Feb 2019 17:04:50 +0100
Message-ID: <CAJ2ouawAZPNRE+DYPmD42UWZPCXba5BH-NtfZ_-RzLNa6F5OBQ@mail.gmail.com>
Subject: Re: thinkpad_acpi: Battery quirk for Thinkpad 11e (4th gen)
To:     Ken Milmore <ken.milmore@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Feb 24, 2019 at 3:58 PM Ken Milmore <ken.milmore@gmail.com> wrote:
> Setting charge thresholds seems to basically work, but one thing worth
> mentioning is that charge_start_threshold and charge_stop_threshold
> appear to be tied together; AFAICT setting one also sets the other to
> the same value. The battery does seem to start charging whenever it
> falls below the common threshold, I have it set at 80% and it has kept
> the battery floating around 79%.

I observe the same behavior on my Thinkpad 13. Maybe there is a bug in
the driver, but it could also be a bug in the firmware.

> diff -uprN linux-source-4.19~/drivers/platform/x86/thinkpad_acpi.c linux-source-4.19/drivers/platform/x86/thinkpad_acpi.c
> --- linux-source-4.19~/drivers/platform/x86/thinkpad_acpi.c     2019-02-24 13:27:29.341331227 +0000
> +++ linux-source-4.19/drivers/platform/x86/thinkpad_acpi.c      2019-02-24 13:09:28.710982438 +0000
> @@ -9619,6 +9619,7 @@ static const struct tpacpi_quirk battery
>         TPACPI_Q_LNV3('R', '0', 'B', true), /* Thinkpad 11e gen 3 */
>         TPACPI_Q_LNV3('R', '0', 'C', true), /* Thinkpad 13 */
>         TPACPI_Q_LNV3('R', '0', 'J', true), /* Thinkpad 13 gen 2 */
> +       TPACPI_Q_LNV3('R', '0', 'K', true), /* Thinkpad 11e gen 4 */

Personally, I would add the line below the 11e gen 3.

>  };
>
>  static int __init tpacpi_battery_init(struct ibm_init_struct *ibm)