Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp778103img; Tue, 26 Feb 2019 08:26:38 -0800 (PST) X-Google-Smtp-Source: AHgI3IZiUyAnTpGXHMQfoI0zUaSsqlz8iLdSVbQIZJFl4KOkjQCGXp4i0hwo83cEniC/KK8QBj9h X-Received: by 2002:a63:1021:: with SMTP id f33mr20789882pgl.392.1551198398753; Tue, 26 Feb 2019 08:26:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551198398; cv=none; d=google.com; s=arc-20160816; b=Z5OzBkCQCwSLnVNC5gvXRw8yKXtKMBznmr8T3jENvsrOt2Tod1o0WBmVmTQlesZsJH V2XoBtJ+bJwTF3+VAyhZluRpqc21NjoSao1/aduHx6RhaJoFbjXeZIwG6JTbF/LE9UE2 VkdHkF7n1f2IiQgsFn+czt8svmde5vFV0eGtxZjYgLP5eK4B1wl759FjT51MJwlmLhdB yeL7hebI82vjvXfSXAGi4OBPct+3aYYYVwmKkTMRU2sNjILGBtEkTGl25nVo8Q15h/AY N67wZYgErYfKnGIOr2B945RltkpiaQGwuofkb4eo3ciZbjdLLApJHGOjehZNM3bGBuus uVbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=yY/z+WYED42RN5eR6YxI3QlzXtLmjRlPVmo9chHlpY4=; b=huOfyiz2PVF+rmZSnqFEr4pTm7dWT5GX/nR4bACzLzCy9BpvWOoh2OSxtdwzFT9Zn7 ORFtuKE9ffOyNFQqYna4MQQ3QXG8LQTtxlp7Ro1EmBFkL1g0cY450rBVoYb04Agl+1YY 7+YozJc8XiUWdv+5v4RN8YHmXZMRMkqV7ddIeAaGfuNTIhHvzKle02aQZrxZrx9qkmRd 7NZqiBC1wUTe002RLZ758bp7ChEcDU7oVKvNLJsaRZfE0nAxr4NDvoZeFbVQZwc3pbe8 20mScq6dEABwjav3scJzR/0EA8s6LCb1f/Z9n2tlWWQSzWm1mPwkO81AiZ4d3+ly4u4G DIdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b66si13073319pfj.106.2019.02.26.08.26.23; Tue, 26 Feb 2019 08:26:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728456AbfBZQYx (ORCPT + 99 others); Tue, 26 Feb 2019 11:24:53 -0500 Received: from www62.your-server.de ([213.133.104.62]:56848 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727108AbfBZQYx (ORCPT ); Tue, 26 Feb 2019 11:24:53 -0500 Received: from [78.46.172.2] (helo=sslproxy05.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gyfXH-0006gC-2t; Tue, 26 Feb 2019 17:24:51 +0100 Received: from [178.197.249.32] (helo=linux.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gyfXG-000JQh-S4; Tue, 26 Feb 2019 17:24:50 +0100 Subject: Re: [PATCH] bpf: decrease usercnt if bpf_map_new_fd() fails in bpf_map_get_fd_by_id() To: zerons , ast@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1551190537-28694-1-git-send-email-sironhide0null@gmail.com> <564058e0-1432-676e-2f83-c8694911d8e5@iogearbox.net> <288b6db2-b14a-4f85-b89c-d873f0f6fcd8@gmail.com> From: Daniel Borkmann Message-ID: Date: Tue, 26 Feb 2019 17:24:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <288b6db2-b14a-4f85-b89c-d873f0f6fcd8@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.2/25372/Tue Feb 26 11:34:09 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/2019 03:58 PM, zerons wrote: > On 2/26/19 22:44, Daniel Borkmann wrote: >> On 02/26/2019 03:15 PM, zerons wrote: >>> [ Upstream commit c91951f15978f1a0c6b65f063d30f7ea7bc6fb42 ] >> >> Thanks for the fix! What do you mean by "upstream commit" above in this context? > > This patch is based on that commit, I thought I should mention this. > Sorry for the confusion. Ah, no. Usually that line is placed into stable commits that are cherry-picked to point to the original commit sha in the mainline tree. In any case, I didn't find c91951f15978, hence my question. Anyway, for normal patch submissions in future, please don't add it into the log, we'll remove it this time. Thanks, Daniel