Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp937345img; Tue, 26 Feb 2019 11:08:12 -0800 (PST) X-Google-Smtp-Source: AHgI3IaaukdukyG5Ypz605gE5VieLl/uS3jg3s3A+df7wl2CvdrErwwc5BTzefQAIZ8UuJlZ0z8B X-Received: by 2002:aa7:918b:: with SMTP id x11mr20843907pfa.228.1551208092512; Tue, 26 Feb 2019 11:08:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551208092; cv=none; d=google.com; s=arc-20160816; b=lSKXe2UN3r7bGOWO9Ojxf7AQTXYKo74xfgDZHQEab370UJtRHQoFGk+46rldzNVdei fFOZvReiADKX+1mWbtmCtUE6Bb99N9yyPjlLxce/wUJmQFvj/rCY5nWBd58DtOk5720H ilpgwUpzFjwkLPWIFyRARCG6epG8HrGB8JDgVH0uWEbCNfrKZSOcyOoZ4RH/bj2k9aHH amIoVYRNAh++DDM5hlYa8S5TSnzGU3/w22KjznrsaCWZwr8AbMl7YyaN43lUaEVGummA KQKdFJTspJ7uL8PiiZqnRsOykQOqLXIBGbSjD1dqLS+mYgT6/YhNiwb5s9C0Z3g9tcbv TV0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fzPfbX4O9+ukKDctqeu2GuWRrlJzV6NaLJxsLRKGzcQ=; b=ETKsUZ3UdGhQnNUz+q/8jeWwXjC/y45v0fQvECYE+jSxVicUqwqdhi4hQMUn496Y5r Xf7mKDJIQJrMhoxypVD/pSytndpptYvvoH8Rkz5kjAtCq51nFcCIIpvGp1fDXduEv49P ksYTt+7nQnAgJqihE79HVD9RLLG3WIVyTVxfrBzCSh3gMMXtJ0y19ARe6AxoQX88PT28 Octjlbs4yMpmNYEBOHrrHjpIjv18IAuWV0zy6urGwj+JpduMV3xIugCil8r5ILZ1dTuQ Xobu4gY31j11zhtyArRFzADNaBcdenCYugPAU17IuXvhtwRN6r4WYkQJTbcliqT98TwR hCbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=u5BGJ8BL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p91si13222146plb.69.2019.02.26.11.07.56; Tue, 26 Feb 2019 11:08:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=u5BGJ8BL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728658AbfBZTHE (ORCPT + 99 others); Tue, 26 Feb 2019 14:07:04 -0500 Received: from merlin.infradead.org ([205.233.59.134]:56138 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727731AbfBZTHE (ORCPT ); Tue, 26 Feb 2019 14:07:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fzPfbX4O9+ukKDctqeu2GuWRrlJzV6NaLJxsLRKGzcQ=; b=u5BGJ8BLdn94aNl1UZVCCFSfk sydmXIbRj0G9lwFiiXfl+s8fQL1XI4uosccGXfOnPZIHKtTJtYHhPDWBM7m6Gs0waUuD7wC9bAfWw hC9cI3BnNWUN4VbxIeYWC12ckeRyjMexj43sjzQZF7wKyP4Theqc7GK0idL2Vs/X2cvN2Qmuo9jza bVcgq5dcqunnbNCrRcyDaUD0M/tg/NXee+uYMVPOFBdQM8kXRvb73RfmqpDArsFR5kNTiJm/PTx5w JtHQW+Nqf8ixqSifKXPp7IKhAM1B92JfbSbZbVUME6gn19ZL+pMnq26g81qZHpiJH7nQF1Xu34g26 83mrZcfbA==; Received: from [188.207.104.89] (helo=worktop.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gyi4C-0008FC-8y; Tue, 26 Feb 2019 19:07:00 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id D85AB984351; Tue, 26 Feb 2019 20:06:58 +0100 (CET) Date: Tue, 26 Feb 2019 20:06:58 +0100 From: Peter Zijlstra To: Len Brown Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Zhang Rui , Len Brown , linux-pm@vger.kernel.org Subject: Re: [PATCH 07/14] powercap/intel_rapl: Simplify rapl_find_package() Message-ID: <20190226190658.GS2861@worktop.programming.kicks-ass.net> References: <4dd94a34999d6db4ced7a0759c02f7cd93729dc4.1551160674.git.len.brown@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4dd94a34999d6db4ced7a0759c02f7cd93729dc4.1551160674.git.len.brown@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 26, 2019 at 01:20:05AM -0500, Len Brown wrote: > -static struct rapl_package *find_package_by_id(int id) > +static struct rapl_package *rapl_find_package(int cpu) > { > + int id = topology_physical_package_id(cpu); > struct rapl_package *rp; Which you'll change to topology_physical_die_id() in the next patch. If you respin the series again, could we pick a better name?