Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp966193img; Tue, 26 Feb 2019 11:39:21 -0800 (PST) X-Google-Smtp-Source: AHgI3IbTa0CEbBd2qFgzO9Us05b+7c53vxbi4XadRkhMdSbGHlDH1V4NsqGw/7gJJPTzhtrRUijx X-Received: by 2002:a65:410a:: with SMTP id w10mr25357785pgp.206.1551209961508; Tue, 26 Feb 2019 11:39:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551209961; cv=none; d=google.com; s=arc-20160816; b=av0s0cmawTmlspyT2xA7htkC7KPBw3bE+J/SWLFwSvPMmKHDXKIImYsTrmlSwEISyV 9dOgnaMJ7snnQcpmy1t1fm1dEQaMHaBVxVUD0TasfEZvD8iBMc4VhTMSIsayvzZlLk/E dX18QXJzy6VQe0FV9XRofj9KR2ujJAHPv3IguM0S7NL7z2no0okZ41uh7H1EitbqsWHV TKclzP/enLfNY/cZDCeel5rVpkBhtKuque7jqSQ39bHS5Q0IQLnmv8u1gQuOpzodjwUi nYtJiS439fguQMLN8asoNAc5pOyzJMklivBeMtMe5XtTJO2NAKA1Z29Vg3nLEgApZG0j MMZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Zxy0XxA1MxzsropNeklSR3wb+dlQlnhChJjlQro53Yk=; b=Aj/6/V4Kplg8gD8yTV75fCxudK8QK1+m9VtWhmd9aMj86OXsZEC39yVSyiLi6zfDlM 8SYHRbh7WXxSK21Kdp2fBM6UdqcxpjB1+FIGlNStPM/be5laExAiGngl2rqYNDr0MGMl oLZ3VymGW9hZ13BvDqC2BVIFHmxNo6LdAbF5idchAfT2417je3/D/g9sUJLjGDyAiSG4 m1wQPQcWX/gRS8IaWCf8KH+aSXXqwu6HG5DwSzf9+34QRUMQlADNh9/wxDG7h9Udq68d 6AOn8mAfNkBnjcVHN+3VccRypZywYEz+ROVp1f7KI3wF+qg/cOys6WxvYKfHAj6rHk8z ja4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ujvWRXMg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g9si13637924pfd.234.2019.02.26.11.39.06; Tue, 26 Feb 2019 11:39:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ujvWRXMg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729188AbfBZThA (ORCPT + 99 others); Tue, 26 Feb 2019 14:37:00 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:40620 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728963AbfBZTgf (ORCPT ); Tue, 26 Feb 2019 14:36:35 -0500 Received: by mail-pf1-f196.google.com with SMTP id h1so6719843pfo.7 for ; Tue, 26 Feb 2019 11:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Zxy0XxA1MxzsropNeklSR3wb+dlQlnhChJjlQro53Yk=; b=ujvWRXMgJdu1SG4HYPw1wKyEkMT7mYayCL5beQCpVSQc2sbYmc+5d3qG3bGcXJZuIy g6btJvd2T1GwQq4QioFb7yZguBI140NCIA7ohfvtEm4Bf42GaK2JAGY9xvRAdOh9iu2E +DwxlaJZo7ccCcHyKOysRdPiDuxIbynPTnkufVZHlHmRs51B98z0MbngyyqsBZ6BXZQA x2+Aw6ShDGzbCy4g0m0DmnjIhb7IW0GaOiNQT6TIclDijWVqsvVBuvk64Pz2E17y92Kd YUvFTxDKvh1WdD4q4YjmnAX7re5LibMDj5PZyDmrcIsJX6wIM0wIvK2R5bgbxNWHoXx8 LxXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Zxy0XxA1MxzsropNeklSR3wb+dlQlnhChJjlQro53Yk=; b=HcS69B3+YD908awcT6Q3X0P4E2Wz8imWI0PrzGrEskIbeSG1kMQjGefzikd+itLkft BZSBRZ2NodAM6Dih3eO4VPjRr7GpUTtFCClSxxJUdGMFIZa2ZTVu0wfP0Kx/86aiysuY Pq/iIwvyNzjySDBbZ5eMOxpRlwU/k8Mr04Hl5kOiTGtSdMjItQHnzJm2C5uXgyFEhDXo Gm5Vr70gifLAUfReETsYD0030eqVBFl75YWYs7TlY4FN28MFHlpqhrEn6OoLkepxxvmC pcHExMZo6msUHrljnA4rnWeFYcp/IxYT7/eU99OGvBxWVS0/NJ6KfqCMcYiQYUN1CBuA MIgw== X-Gm-Message-State: AHQUAuaj5Lqel5SZRGIcTnd620FUhKL2DxMAL+dNxIupA9SuAvReENxr fCaPpYhkwxfH9E744n6G+z4= X-Received: by 2002:a63:2ad4:: with SMTP id q203mr26606392pgq.43.1551209794912; Tue, 26 Feb 2019 11:36:34 -0800 (PST) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id l79sm28951220pfb.102.2019.02.26.11.36.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Feb 2019 11:36:34 -0800 (PST) From: Andrey Smirnov To: dri-devel@lists.freedesktop.org Cc: Andrey Smirnov , Archit Taneja , Andrzej Hajda , Laurent Pinchart , Chris Healy , Lucas Stach , linux-kernel@vger.kernel.org Subject: [PATCH 6/9] drm/bridge: tc358767: Simplify error check in tc_aux_linx_setup() Date: Tue, 26 Feb 2019 11:36:06 -0800 Message-Id: <20190226193609.9862-7-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190226193609.9862-1-andrew.smirnov@gmail.com> References: <20190226193609.9862-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tc_poll_timeout() can only return -ETIMEDOUT, so checking for other errors is not necessary. Drop it. No functional change intended. Signed-off-by: Andrey Smirnov Cc: Archit Taneja Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Chris Healy Cc: Lucas Stach Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org --- drivers/gpu/drm/bridge/tc358767.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index ea30cec4a0c3..54ff95f66e30 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -569,11 +569,10 @@ static int tc_aux_link_setup(struct tc_data *tc) ret = tc_poll_timeout(tc->regmap, DP_PHY_CTRL, PHY_RDY, PHY_RDY, 1, 1000); - if (ret == -ETIMEDOUT) { + if (ret) { dev_err(tc->dev, "Timeout waiting for PHY to become ready"); return ret; - } else if (ret) - goto err; + } /* Setup AUX link */ tc_write(DP0_AUXCFG1, AUX_RX_FILTER_EN | -- 2.20.1