Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp1047529img; Tue, 26 Feb 2019 13:12:12 -0800 (PST) X-Google-Smtp-Source: AHgI3IYgJI+/0P8roDP9qxZ6Z7nBmsel1l0uQ7xPmogvHv7+yo2QmprJ/Dfi8P5WHCWOKcqV4xWa X-Received: by 2002:a17:902:6bc7:: with SMTP id m7mr28516009plt.106.1551215532290; Tue, 26 Feb 2019 13:12:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551215532; cv=none; d=google.com; s=arc-20160816; b=De61EDgDXzjzSbK4CjiyM1KAkpRBrNG2ZjsKIMOLiyzBsWztOOpZou6FwoiFEV//Ta mSiNFKJBq+j2M79XhjhUXnCr3LZITywHP9qYUPicWxl1gq/bM6fhwAAz6YNKa3WU2ey/ 5tRew+PW+5kvBEIYD4VaEqxOqyQIKy3Esn5VkqCtdcq+9IIdEpV7yiDMjziza0PFKnXs /BnIe9Fd4d9q0G2f6mM5bdHi2+1IG1P5i83MXZUTTmS6Cq1A2J4DYITFS055OVbY3Emo YuCwefMURWKGw5RjI/dEPvwDtr02TMVagwD/c+oKWivyI409B3kBCYQFTnFLDsm7ge32 G1Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=vqn5xeXHz4o/Av3EPiyID6FO61P3niCXIqush6ZbzRg=; b=CPoD+SRcgw6kRQ7I01qmzJdFcx9IDl+XMhoJJGMYfBbVVMfLCxbJKD5LMTI5BO7PEx Ke1jcDyunSeAuoAuSFy7FFJEQFG3EFbY2c5lHXc7/FJBskr8diRJ7IkIQyYgvErDpikQ nyW4Hpt2w7bGz8w5EQQBrRbAEQx+IVeheKuLiUG7pZ8KxQ4e8qVW3422fkvndlZBFR9o ZlkryiKbAfjX7VSENGSQv7Kchb301p+R7Lij9L6uxbeg4zZcyjsOskv/C0asKNjwl96c OCGFMAirZqX/5n/bxNiB1FJPJZ8N+/OolEZYJjgRI9HQOVqJAHhqeh/pVNKbJpehlGSB paOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=daQMLvWj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cn6si14574790plb.242.2019.02.26.13.11.52; Tue, 26 Feb 2019 13:12:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=daQMLvWj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729044AbfBZVLR (ORCPT + 99 others); Tue, 26 Feb 2019 16:11:17 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:44909 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727823AbfBZVLR (ORCPT ); Tue, 26 Feb 2019 16:11:17 -0500 Received: by mail-wr1-f68.google.com with SMTP id w2so15537607wrt.11 for ; Tue, 26 Feb 2019 13:11:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vqn5xeXHz4o/Av3EPiyID6FO61P3niCXIqush6ZbzRg=; b=daQMLvWjgQfTvZQWjCi8VCLIYQnxrOTOf2ZmjT+6z9o8iDF3aPTAOIc/VzJpeRiFVC ZQf08kCHnvw4zTZFrWLxEAh4K7hIz/1IXDQZWPiGEI9w0hgW1p6kTn0/Q/NyMwzfF2oW eJVjbiVZTY+B98yNec3rb4n7NGq8BalqkFQlpGyX1WNME5cLMMsow3nIbr8GEWXGceUA XPQiXQWy5R9UYpmOvDsBBNLQ1aeHUybfZak4tmZN/yC6C7XWtPbQZzqkJIM/RMGJfxAS eRrD9zI2zwAh3SqU210pnzfRvJjzQPbwmRvlhdtUTK+uGx5DSp/pkkPeTlf0DQlR75oR 2trw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vqn5xeXHz4o/Av3EPiyID6FO61P3niCXIqush6ZbzRg=; b=UrGsPPNFwiCxJnPDomKJOCRtbZ4mNZiOeirbOYNSqdEiH53ilxMSMvJ4djxzjELQG5 bDzUBVcshKG7MTc1DfFPISRsZySfqgzp8mut1/ixsHU4eMnfjCNptX/f7Jt+b7NrCom4 9P7/evUBKgv12KNvPu2TmNnyAM+V0b0L9OGoIYOPAs6du7hVtJ45TvnavKGb2rOiajyP xPxFGEg1XqWjdnhIB+pzCfRCX7ZD2xbsoB1xqviuAUKN9VFUHX2HDI13SFBLzn+ImEc9 Jw5XjlTLViVXgR7xse0kcRjsrvZqlKdBVDpx6EKGEsb4S+BQi5ns+fypiUKkeKyIJ+cj tr7A== X-Gm-Message-State: AHQUAub5lS+6cJi8BRAN5e4G7cI2Dqczv8m7c6LXHzBi/fzVrlfvw2ub vLIZxiAIhPHz4F0/z4vehGiyNeght0nRpKVwCkZo X-Received: by 2002:adf:e5cc:: with SMTP id a12mr19229338wrn.130.1551215475293; Tue, 26 Feb 2019 13:11:15 -0800 (PST) MIME-Version: 1.0 References: <20190226194806.34fc23b5@xhacker.debian> In-Reply-To: <20190226194806.34fc23b5@xhacker.debian> From: Bjorn Helgaas Date: Tue, 26 Feb 2019 15:11:03 -0600 Message-ID: Subject: Re: [PATCH 0/5] PCI: dwc: support remove To: Jisheng Zhang Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 26, 2019 at 5:55 AM Jisheng Zhang wrote: > > Currently, the PCI dwc host users don't support the remove, but nothing > prevent us from supporting it. To achieve this goal, we need to ensure > we can do necessary clean up work. > > Jisheng Zhang (5): > PCI: dwc: fix dw_pcie_free_msi() if msi_irq is invalid > PCI: dwc: free the page for MSI irq in dw_pcie_free_msi() > PCI: dwc: free msi in the error code path of dw_pcie_host_init() > PCI: dwc: use devm_pci_alloc_host_bridge() to simplify the code > PCI: dwc: save root bus for driver remove If you post a v2 of this series, please: Capitalize the first word of each subject, e.g., "PCI: dwc: Fix dw_pcie_free_msi() if msi_irq is invalid" s/irq/IRQ/ s/msi/MSI/