Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp1123550img; Tue, 26 Feb 2019 14:46:31 -0800 (PST) X-Google-Smtp-Source: AHgI3IaxjCQjZoXMGzy9LrXvbYu3H3E/W6NaAwE3dZJB8i3ovmaCkK8LTFKo6SPU697ckQHJGUG4 X-Received: by 2002:a63:2ad4:: with SMTP id q203mr27351532pgq.43.1551221191528; Tue, 26 Feb 2019 14:46:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551221191; cv=none; d=google.com; s=arc-20160816; b=QBsiO5b+gZUudQI8s174IKDyb5spgo/JJH4XpbqHADl3zAQzMkvRAXTMTFJcr9CDxT i+MO7QAYcQ1IaiwA9ZFJew6p4G5G5l0i+5RAMujDxbC29X0euS3I/e91NmRmRQXkCO5a d5BeV0TFFhOScI6sg+aY+PS3YnlzMUfuxgPj7agOGavHxAJEkrCQc12xSn/O0EYKtK8T FEoP73jyK0eSjbHaEHVGiH8fZBI8uQmCom2Z8ZmcQwFfyHXNLVi1AO7qWf1/zWmGjPBO OGi+U+NobKXOczYSuTteX3A/O5qlxYqK2S2gy/VjPCIbqknKsX6j4ARbnFsEomTFb4Dd 1OCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=0ut73UDslynVWeuAjENGBhnuJ/IEtfKj53ulOP+jPn8=; b=I8Oqijhi2Zu9RYe+1qdoplc/YxjHfyNVaeQdHnQsSNHnQMKHKXab9cD7wsEocyunK9 I4To9jCedGmyuyjstOX246WiDEgPCBDWvJSn3g2KYOvMn59M4nLLzPWUbX1gId1l+BUZ 0u8D8T3qLl+EsiPp6o/T00cbVBp7HDihtfUsImDHbw/vEgS1bdke/pkMOb1m7X1vlaPc H7AhwlFxiYpq9nLTECfU52760fm2WF9YircBN4oVzy0XGX7iQrfXuH8rUGdBmkV2iuI1 y0Jbp2OZ34gd+0nqe77BPIdqFFdcwnHOVU4BWrVxmT6Zx/sBnDVMBnAPabJFvDLllwH6 T82w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si3194682plq.315.2019.02.26.14.46.15; Tue, 26 Feb 2019 14:46:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729248AbfBZWpx (ORCPT + 99 others); Tue, 26 Feb 2019 17:45:53 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:33900 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728791AbfBZWpw (ORCPT ); Tue, 26 Feb 2019 17:45:52 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CA64014F2E69A; Tue, 26 Feb 2019 14:45:51 -0800 (PST) Date: Tue, 26 Feb 2019 14:45:51 -0800 (PST) Message-Id: <20190226.144551.1264975286059315553.davem@davemloft.net> To: haiyangz@microsoft.com, haiyangz@linuxonhyperv.com Cc: sashal@kernel.org, linux-hyperv@vger.kernel.org, kys@microsoft.com, sthemmin@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH hyperv-fixes] hv_netvsc: Fix IP header checksum for coalesced packets From: David Miller In-Reply-To: <20190222182503.12160-1-haiyangz@linuxonhyperv.com> References: <20190222182503.12160-1-haiyangz@linuxonhyperv.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 Feb 2019 14:45:52 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang Date: Fri, 22 Feb 2019 18:25:03 +0000 > From: Haiyang Zhang > > Incoming packets may have IP header checksum verified by the host. > They may not have IP header checksum computed after coalescing. > This patch re-compute the checksum when necessary, otherwise the > packets may be dropped, because Linux network stack always checks it. > > Signed-off-by: Haiyang Zhang Applied and queued up for -stable.