Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp1141823img; Tue, 26 Feb 2019 15:09:22 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ3qsz63iYanRkgfF8YRTRSG68TJcAw4xQUeLqWbwIdNUJSAFxYvQn7OwfKKrb21sKGVML4 X-Received: by 2002:a63:480c:: with SMTP id v12mr27339725pga.115.1551222562777; Tue, 26 Feb 2019 15:09:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551222562; cv=none; d=google.com; s=arc-20160816; b=LdihTVqlL/wgAfVYbfbS8Y8c/RYWieoyw9bL4E/jhnBwfxbJvYx+3yDAuJfNHVGM0o T7nluc9mjZLnu9yF0ALmoWOXg5waH2jkGl5jb81gs72g8V9LeFCFrcLK+Vrjo5UHONA2 sPUAQ2ZzuWXPzc+sNUj1S48t1lfdSNX47XmZZYIy82HWd3/eC/olDUoA05+IdgUnk2lf O/P3WDBtNdyp0PIS9PwQjRVXruAiz8CGl85ILPXwoCKw4KOW3a98mwqyQnBO7SmCOcQ3 uW9vn1GnQk1bv47jSvIeQr8Ulvd/BJYLpzoh/plmaT/+IvmaFjeBR6zQ1n0bdIimpdgp gXUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KtH8YR8boDh/kFz1GRhF//TXEVdCzcoFIHHXCarlfc4=; b=S0Lhk3RJ30BhhfFFHZhnSs/RB6nH7iH5WjRcd4mSLCRhBZUiZOVPIs64kqG1uPB8nX SePF82Ivs4a0f7pxY0Z+NXJCLJyIksQJ9iJH2iqc/7/TWLYFQKA0560XLuUDLH43N4pL T97WRhSs2JoU7bt6KGE25yM0wBi1WK6fVdkcPX4PL1WIBF6e83fkv19Qix97Vn3Fn3H5 z6FN+CT0lItN7Gj07/YRh1gJQRSxy7MXIG2NqrKABCnZK90ogdhNhUqxPK/zRnr2TL5r FV/Flqeq4PVWBAo88kpnAy+p7rJh8vsY+IFhpXZCRQck2gPPKHrhEO/CKvzNtvH9fTLX NiOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=ywXTDDJ+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v6si12491599pgs.206.2019.02.26.15.09.07; Tue, 26 Feb 2019 15:09:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=ywXTDDJ+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729373AbfBZXHv (ORCPT + 99 others); Tue, 26 Feb 2019 18:07:51 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:58518 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728766AbfBZXHv (ORCPT ); Tue, 26 Feb 2019 18:07:51 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1QN4hQt191453; Tue, 26 Feb 2019 23:07:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=KtH8YR8boDh/kFz1GRhF//TXEVdCzcoFIHHXCarlfc4=; b=ywXTDDJ+9PL6p7HMdSiuoZmX6q4G/nkhtacmd9Yut7q+4vGkYlqezV5kw7P5cet8D64G aHECJqVxlWTAZ88yA3hQNfSOnkwvsTNRYYWXfFLfwNYmmvpqivJ7xKZLV333CTQKSL1N lkjz3+OkpggCvSm+Ipiq4UWESkyiJc58XH/BvanvWj0TfzUt6DTr4xWy7GI7nxt6VYS+ QZ1h1UYtZtfAXfgX+huMFska8XsvrwT8mNlQIh0dBPdhmEnCs4ScUD0/6uT6TGPg68Gz s/n09CY6/qAPR2zBcQ1YjcwWZDcC1zddrdY4FXzah50rMlzCWcrUHSuclBlBokxPRj2c bw== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2qtxtrqjke-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Feb 2019 23:07:29 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1QN7Mdu015611 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Feb 2019 23:07:22 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x1QN78VO017915; Tue, 26 Feb 2019 23:07:08 GMT Received: from ca-dmjordan1.us.oracle.com (/10.211.9.48) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 26 Feb 2019 15:07:07 -0800 Date: Tue, 26 Feb 2019 18:07:29 -0500 From: Daniel Jordan To: "Huang, Ying" Cc: Daniel Jordan , Andrea Arcangeli , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , "Paul E . McKenney" , Minchan Kim , Johannes Weiner , Tim Chen , Mel Gorman , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Michal Hocko , David Rientjes , Rik van Riel , Jan Kara , Dave Jiang , Aaron Lu , Andrea Parri Subject: Re: [PATCH -mm -V8] mm, swap: fix race between swapoff and some swap operations Message-ID: <20190226230729.bz2ukzlub3rbdoqp@ca-dmjordan1.us.oracle.com> References: <20190218070142.5105-1-ying.huang@intel.com> <87mumjt57i.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mumjt57i.fsf@yhuang-dev.intel.com> User-Agent: NeoMutt/20180323-268-5a959c X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9179 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=794 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902260155 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 26, 2019 at 02:49:05PM +0800, Huang, Ying wrote: > Do you have time to take a look at this patch? Hi Ying, is this handling all places where swapoff might cause a task to read invalid data? For example, why don't other reads of swap_map (for example swp_swapcount, page_swapcount, swap_entry_free) need to be synchronized like this?