Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To:     Julia Lawall <julia.lawall@lip6.fr>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        "Sergei Shtylyov (sergei.shtylyov@cogentembedded.com)" 
        <sergei.shtylyov@cogentembedded.com>
Subject: RE: question about drivers/phy/renesas/phy-rcar-gen2.c
Thread-Topic: question about drivers/phy/renesas/phy-rcar-gen2.c
Thread-Index: AQHUu458FqHVOGKcBkGy/69gWAAvIKXx6SwwgAADUQCAAQwzAA==
Date:   Wed, 27 Feb 2019 01:06:25 +0000
Message-ID: <TY2PR01MB481259F0AFBF6DEF9565792CD8740@TY2PR01MB4812.jpnprd01.prod.outlook.com>
References: <alpine.DEB.2.21.1902030759010.19281@hadrien>
   <TY2PR01MB4812FA6549BA23233D9670CBD87B0@TY2PR01MB4812.jpnprd01.prod.outlook.com>
 <alpine.DEB.2.20.1902261000420.3499@hadrien>
In-Reply-To: <alpine.DEB.2.20.1902261000420.3499@hadrien>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
received-spf: None (protection.outlook.com: renesas.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5cb4f592-66f3-45d7-3d8f-08d69c4fcbff
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 01:06:25.6714
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB3097
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

> From: Julia Lawall, Sent: Tuesday, February 26, 2019 6:01 PM
>=20
> On Tue, 26 Feb 2019, Yoshihiro Shimoda wrote:
>=20
> > Hello,
> > (Sergei made this code, so I added his email as CC)
> >
> > I'm sorry for the delayed response.
> >
> > > From: Julia Lawall, Sent: Sunday, February 3, 2019 4:03 PM
> > >
> > > Hello,
> > >
> > > I was wondering whether phy-rcar-gen2.c would use dynamically allocat=
ed
> > > device nodes?
> >
> > I'm sorry, but what is "dynamically allocated device nodes"?
>=20
> Device nodes for which there will be a meor leak if one doesn't put
> of_node_put.

Thank you. I understood it.

> julia
>=20
> >
> > Best regards,
> > Yoshihiro Shimoda
> >
> > >  If so, it looks like the following code could cause a
> > > use-after-free, due to not incrementing th reference count:
> > >
> > > 	for_each_child_of_node(dev->of_node, np) {
> > > 		struct rcar_gen2_channel *channel =3D drv->channels + i;
> > > 		u32 channel_num;
> > > 		int error, n;
> > >
> > > 		channel->of_node =3D np;

IIUC, since the channel->of_node will be used for comparing the pointer
in rcar_gen2_phy_xlate(), it is not use-after-free.
However, the for_each_child_of_node() in rcar_gen2_phy_probe() will return
without of_put_node() at error paths. So, I'll submit a bugfix patch later.

Thank you very much for your report!

Best regards,
Yoshihiro Shimoda

> > > 		...
> > > 	}
> > >
> > > On the other hand, if the reference cound it incrememnted, preventing
> > > memory leaks in the case where the probe function fails would entail =
some
> > > complex rewriting of the code, so I thought it would be better to ask
> > > first.
> > >
> > > thanks,
> > > julia
> >