Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ran Wang <ran.wang_1@nxp.com>
To:     Rob Herring <robh@kernel.org>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Yang Li <pku.leo@gmail.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 1/2] usb: dwc3: Add avoiding vbus glitch happen during
 xhci  reset
Thread-Topic: [PATCH v3 1/2] usb: dwc3: Add avoiding vbus glitch happen during
 xhci  reset
Thread-Index: AQHUzfHmauKj0nbPoU2toyXsYrER/KXy7LfA
Date:   Wed, 27 Feb 2019 02:35:15 +0000
Message-ID: <AM5PR0402MB2865656822F6CA28AF9E50E5F1740@AM5PR0402MB2865.eurprd04.prod.outlook.com>
References: <20190226070016.27372-1-ran.wang_1@nxp.com>
 <20190226163948.GA8854@bogus>
In-Reply-To: <20190226163948.GA8854@bogus>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a915b37-2129-463a-1dac-08d69c5c34d5
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 02:35:15.6229
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2770
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Wednesday, February 27, 2019 00:40
> To: Ran Wang <ran.wang_1@nxp.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Yang Li
> <pku.leo@gmail.com>; linux-usb@vger.kernel.org; devicetree@vger.kernel.or=
g;
> linux-kernel@vger.kernel.org; Ran Wang <ran.wang_1@nxp.com>
> Subject: Re: [PATCH v3 1/2] usb: dwc3: Add avoiding vbus glitch happen du=
ring
> xhci reset
>=20
> On Tue, 26 Feb 2019 06:59:21 +0000, Ran Wang wrote:
> > When DWC3 is set to host mode by programming register DWC3_GCTL, VBUS
> > (or its control signal) will turn on immediately on related Root Hub
> > ports. Then the VBUS will be de-asserted for a little while during
> > xhci reset (conducted by xhci driver) for a little while and back to no=
rmal.
> >
> > This VBUS glitch might cause some USB devices emuration fail if kernel
> > boot with them connected. One SW workaround which can fix this is to
> > program all PORTSC[PP] to 0 to turn off VBUS immediately after setting
> > host mode in DWC3 driver(per signal measurement result, it will be too
> > late to do it in xhci-plat.c or xhci.c).
> >
> > Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> > ---
> > Changes in v3:
> >   - None
> >
> > Changes in v2:
> >   - Correct typos
> >   - Shorten the name to snps,host-vbus-glitches
> >
> >  Documentation/devicetree/bindings/usb/dwc3.txt |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
>=20
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.

Got it, thanks for telling me this. So if I need to update patch 2/2 in nex=
t version,
I still need to attach this 1/2 patch with adding tag 'Reviewed-by' to it, =
am I right?

>=20
> If a tag was not added on purpose, please state why and what changed.

OK

Regards,
Ran