Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Diana Madalina Craciun <diana.craciun@nxp.com>
To:     Christophe Leroy <christophe.leroy@c-s.fr>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc/fsl: Fix the flush of branch predictor.
Thread-Topic: [PATCH] powerpc/fsl: Fix the flush of branch predictor.
Thread-Index: AQHUzf+5VIZw7d5mQk2/6tvrH4vMMg==
Date:   Wed, 27 Feb 2019 06:47:59 +0000
Message-ID: <VI1PR0401MB2463466309756C7D038F0DB7FF740@VI1PR0401MB2463.eurprd04.prod.outlook.com>
References: <dccb392cd3e2b1825608576ecf2487cc5d84466d.1551205086.git.christophe.leroy@c-s.fr>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b633792-5fb6-4b0e-9960-08d69c7f8342
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 06:47:59.5462
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Diana Craciun <diana.craciun@nxp.com>=0A=
=0A=
Thanks for fixing it!=0A=
=0A=
On 2/26/2019 8:18 PM, Christophe Leroy wrote:=0A=
> The commit identified below adds MC_BTB_FLUSH macro only when=0A=
> CONFIG_PPC_FSL_BOOK3E is defined. This results in the following error=0A=
> on some configs (seen several times with kisskb randconfig_defconfig)=0A=
>=0A=
> arch/powerpc/kernel/exceptions-64e.S:576: Error: Unrecognized opcode: `mc=
_btb_flush'=0A=
> make[3]: *** [scripts/Makefile.build:367: arch/powerpc/kernel/exceptions-=
64e.o] Error 1=0A=
> make[2]: *** [scripts/Makefile.build:492: arch/powerpc/kernel] Error 2=0A=
> make[1]: *** [Makefile:1043: arch/powerpc] Error 2=0A=
> make: *** [Makefile:152: sub-make] Error 2=0A=
>=0A=
> This patch adds a blank definition of MC_BTB_FLUSH for other cases.=0A=
>=0A=
> Fixes: 10c5e83afd4a ("powerpc/fsl: Flush the branch predictor at each ker=
nel entry (64bit)")=0A=
> Cc: Diana Craciun <diana.craciun@nxp.com>=0A=
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>=0A=
> ---=0A=
>  arch/powerpc/kernel/exceptions-64e.S | 1 +=0A=
>  1 file changed, 1 insertion(+)=0A=
>=0A=
> diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/e=
xceptions-64e.S=0A=
> index 4549ce8d4637..49381f32b374 100644=0A=
> --- a/arch/powerpc/kernel/exceptions-64e.S=0A=
> +++ b/arch/powerpc/kernel/exceptions-64e.S=0A=
> @@ -338,6 +338,7 @@ ret_from_mc_except:=0A=
>  #define GEN_BTB_FLUSH=0A=
>  #define CRIT_BTB_FLUSH=0A=
>  #define DBG_BTB_FLUSH=0A=
> +#define MC_BTB_FLUSH=0A=
>  #define GDBELL_BTB_FLUSH=0A=
>  #endif=0A=
>  =0A=
=0A=
=0A=