Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To:     Bjorn Helgaas <bhelgaas@google.com>
CC:     Jingoo Han <jingoohan1@gmail.com>,
        Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/5] PCI: dwc: support remove
Thread-Topic: [PATCH 0/5] PCI: dwc: support remove
Thread-Index: AQHUzcoXCJUfCkpNIEa0Hsr7++V4qaXyk/uAgACfQAA=
Date:   Wed, 27 Feb 2019 06:48:07 +0000
Message-ID: <20190227144102.40d52f11@xhacker.debian>
References: <20190226194806.34fc23b5@xhacker.debian>
        <CAErSpo4uC6WMt-RNxn6_XG9Lcy+jA0X2bLF3cpVDWC9Sh6AbaA@mail.gmail.com>
In-Reply-To: <CAErSpo4uC6WMt-RNxn6_XG9Lcy+jA0X2bLF3cpVDWC9Sh6AbaA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a14d1dcb-10a5-43ec-d3ba-08d69c7f87b3
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);SRVR:BYAPR03MB4102;
x-ms-traffictypediagnostic: BYAPR03MB4102:
x-microsoft-exchange-diagnostics: =?us-ascii?Q?1;BYAPR03MB4102;23:CSXcrprNpJsEj4tUmYYH1IXoeEgzRqSPMAS6i1mYH?=
 =?us-ascii?Q?sOLa5J4nW39FR0uWsmT412jeuLEOfw3/31oQQrEluKvVVU4efK9g7FQWuDuA?=
 =?us-ascii?Q?3LXiZcf8Ll9LzWAKBTwZeJJYz2cOLwTr0Wtv/DYqzUwXS2VIf+M7ycT2+veU?=
 =?us-ascii?Q?0E9JwrBcYrWor6gCt3CgluZqINoC3RR4jo4RnPCEU7M/JhQpDWsX9eVHh1YS?=
 =?us-ascii?Q?ei8ZDdLxFzfFDFn41xHmgQGamIsRx7/3D1EFm55HDzsME90WzmscagOVnRRx?=
 =?us-ascii?Q?OQGxtyhuapoTYNndU0cv656O7t3RT7e7dC1kGigddI7QVKj7RVBGzCeuZt8h?=
 =?us-ascii?Q?oTD4mUP8eaLXeL8dZmd6lbqdH1A3yhHgMa5PTr1KukLq8vy2pk2uS6jmmCNh?=
 =?us-ascii?Q?nWexdHF/OVz+EIc4EQG0uM1nPrkEn+ihAeXayzcP8xZsF9ExuCk4OrZbCHZt?=
 =?us-ascii?Q?tQaHctglTehp+MGCdmO9EzfVg3Q+pg1JppKdG2IK9awixQ95HR0vg4ryLsgP?=
 =?us-ascii?Q?EZB13XJKGm3+HEq7EFWAebrmgArHsDHufurweQkY9cb6lFGkS/6oYuSGU4AF?=
 =?us-ascii?Q?CdhccT+ifec5+yXYP14OWicgYPQp7EKgda2BsldrB3E/rtzhuqFMXPjdSD+a?=
 =?us-ascii?Q?28kwqp7ooZCk277Y7ueJg+fxPcqevT8qK0BiNacatMISaL2TsCTPMtfGWplt?=
 =?us-ascii?Q?XzA2t8ulSO8fF3A/FUo0eh2CcapbRF63DSRFQF34hfrsxhsHwny7vQjA2v1D?=
 =?us-ascii?Q?e9uirDFywIHI0GwxtdP5nUL5u1iKjdzS9u9NRIOm+4satmCsFCakNxBHNBoF?=
 =?us-ascii?Q?57Fkk5AYZUq1gYcID6Y64Rz5fYN1xuOBAc4utlUYQ5yvZFs4ifkAyEJZFnW+?=
 =?us-ascii?Q?1akpbAvSPw6UhDKsmUwuMQQ/I2AyMEtd9Xnnk3stpgUJaNrEQw3Ur2eOqaiK?=
 =?us-ascii?Q?mhZpHVkCyRDvk8apcqIo+aP59uk8i3974FW6KfB7aDIsSaxi32svYhboq3rq?=
 =?us-ascii?Q?v9jG6skCt5CjMA+iDsr8dYj31G1qr1kqnvTjJHd6SGp+xyHDNB27+RUP9xhC?=
 =?us-ascii?Q?je5FOJ/pNeKhNj3iR1Eu8Yo4kbMm6Iqe6oeWF7+mFSZkA8aJdl8Oz7sE67io?=
 =?us-ascii?Q?yqf+BELH5dCbhBrXHMkjkiEHb8AO/bAd1ScJbkA1YnAKsiQirjnZ3xbGuwbc?=
 =?us-ascii?Q?9PZYZMj1ryJgRnPCMn/+VrUFC2Xq4fPP68V6O//bnRPKut7sY5WhVujoC9kf?=
 =?us-ascii?Q?R7UhA/P51uM1meRKpiwA7w/HbC+gjKZ0ZxwULvJ8pFmVwBi2xeZNpRCyNWvZ?=
 =?us-ascii?Q?DChR6jZEVSPN2y12RxOEZQUPKYoDVFfpsuVuGnQLfr4?=
x-microsoft-antispam-prvs: <BYAPR03MB4102214B58EE5E028C9C6B46ED740@BYAPR03MB4102.namprd03.prod.outlook.com>
x-forefront-prvs: 0961DF5286
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(366004)(39860400002)(376002)(346002)(396003)(51914003)(199004)(189003)(6506007)(8676002)(106356001)(105586002)(11346002)(102836004)(26005)(316002)(81156014)(81166006)(229853002)(6486002)(54906003)(71200400001)(6436002)(256004)(71190400001)(186003)(478600001)(14454004)(72206003)(68736007)(7736002)(99286004)(4744005)(446003)(486006)(6916009)(53936002)(52116002)(305945005)(6116002)(97736004)(1076003)(9686003)(53546011)(6246003)(476003)(86362001)(50226002)(5660300002)(25786009)(76176011)(2906002)(4326008)(3846002)(8936002)(386003)(6512007)(66066001)(39210200001);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR03MB4102;H:BYAPR03MB4773.namprd03.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:0;MX:1;
received-spf: None (protection.outlook.com: synaptics.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 3si6A1m2GIEhihCtXC1IffMVjtR6Oat/sEe8ecLtflenGroBhivDk4fRA7aXVqmX9tghmg89QYTJP1YZHLdPUVqo9XUNEhxFp+CvAUB8cKfQaZdkL2DsJVtSLE0Ra38/cEIX2ijnuilHVuYwdelEImhuuG+l1d7T4TLQQimIp1i0+C+9Hi94MaP84skXUXhUrz+ZSZt+TG4Ok7otTW/JK5qxJA6Ay9v/caKod3fsrMaNIwlBl/ZIgXMOelIIY/0GGMP0E+ClRRSh+D6f23YLSo6CaHRVnoS16LEPbGYoi1fMcYb0YeEWRkVtasTErm8NDeU/xibUuiPYlBrHLnix3mFUZpFHOR2DeUU9LogPB3T+3HJRin0hq/AjWw51uyQgTVd/m6IHUCy8hn7oAePrwyDCkExDMh9KolAp6OSP4qw=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EFF2C701EA8CBC48AE6FF1926A402813@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: synaptics.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a14d1dcb-10a5-43ec-d3ba-08d69c7f87b3
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 06:48:05.0428
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-id: 335d1fbc-2124-4173-9863-17e7051a2a0e
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4102
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 26 Feb 2019 15:11:03 -0600 Bjorn Helgaas wrote:

>=20
>=20
> On Tue, Feb 26, 2019 at 5:55 AM Jisheng Zhang
> <Jisheng.Zhang@synaptics.com> wrote:
> >
> > Currently, the PCI dwc host users don't support the remove, but nothing
> > prevent us from supporting it. To achieve this goal, we need to ensure
> > we can do necessary clean up work.
> >
> > Jisheng Zhang (5):
> >   PCI: dwc: fix dw_pcie_free_msi() if msi_irq is invalid
> >   PCI: dwc: free the page for MSI irq in dw_pcie_free_msi()
> >   PCI: dwc: free msi in the error code path of dw_pcie_host_init()
> >   PCI: dwc: use devm_pci_alloc_host_bridge() to simplify the code
> >   PCI: dwc: save root bus for driver remove =20
>=20
> If you post a v2 of this series, please:
>=20
> Capitalize the first word of each subject, e.g., "PCI: dwc: Fix
> dw_pcie_free_msi() if msi_irq is invalid"
> s/irq/IRQ/
> s/msi/MSI/

Thanks for the review. Will do when post a v2. I'm still trying to
collect more code review comments.

Thanks