Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Alastair D'Silva" <alastair@d-silva.org>
To:     "'Andrew Donnellan'" <andrew.donnellan@au1.ibm.com>,
        "'Alastair D'Silva'" <alastair@au1.ibm.com>
Cc:     "'Greg Kurz'" <groug@kaod.org>,
        "'Frederic Barrat'" <fbarrat@linux.ibm.com>,
        "'Arnd Bergmann'" <arnd@arndb.de>,
        "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
        <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
References: <20190227045741.21412-1-alastair@au1.ibm.com> <20190227045741.21412-2-alastair@au1.ibm.com> <8c0300fc-4319-bd66-a47e-4ffda6ac795c@au1.ibm.com> <156e01d4ce6e$ee42d9f0$cac88dd0$@d-silva.org> <a36b088b-b8d7-8725-50db-6aad58672784@au1.ibm.com>
In-Reply-To: <a36b088b-b8d7-8725-50db-6aad58672784@au1.ibm.com>
Subject: RE: [PATCH 1/5] ocxl: Rename struct link to ocxl_link
Date:   Wed, 27 Feb 2019 19:04:31 +1100
Message-ID: <158101d4ce73$11ff4550$35fdcff0$@d-silva.org>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHHd7z5h6oO3uW69oxVqiBFDB4gBAHhAfo8A1gpEmwCDmo8kwH9d6PwpcPNgSA=
Content-Language: en-au
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> -----Original Message-----
> From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Sent: Wednesday, 27 February 2019 6:55 PM
> To: Alastair D'Silva <alastair@d-silva.org>; 'Alastair D'Silva'
> <alastair@au1.ibm.com>
> Cc: 'Greg Kurz' <groug@kaod.org>; 'Frederic Barrat'
> <fbarrat@linux.ibm.com>; 'Arnd Bergmann' <arnd@arndb.de>; 'Greg Kroah-
> Hartman' <gregkh@linuxfoundation.org>; linuxppc-dev@lists.ozlabs.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/5] ocxl: Rename struct link to ocxl_link
>=20
> On 27/2/19 6:34 pm, Alastair D'Silva wrote:>>> diff --git
> a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c index
> >>> e6a607488f8a..16eb8a60d5c7 100644
> >>> --- a/drivers/misc/ocxl/file.c
> >>> +++ b/drivers/misc/ocxl/file.c
> >>> @@ -152,7 +152,7 @@ static long afu_ioctl_enable_p9_wait(struct
> >>> ocxl_context *ctx,
> >>>
> >>>    		if (status =3D=3D ATTACHED) {
> >>>    			int rc;
> >>> -			struct link *link =3D ctx->afu->fn->link;
> >>> +			void *link =3D ctx->afu->fn->link;
> >>
> >> This doesn't look like a rename...
> >
> > That corrects the type to what the member (and prototype for
> ocxl_link_update_pe) declare it as.
> >
> > The struct link there is bogus, it shouldn't even compile (since the =
intended
> struct link is defined in a different compilation unit), but instead =
picks up a
> different definition of 'struct link' from elsewhere.
> >
>=20
> Given there's only a handful of struct links defined across the entire =
kernel,
> I'm going to guess that the definition it's picking up is in fact the =
ocxl one.
>=20

Unlikely, since that's never in a header. It wasn't caught since it was =
assigned to/from a void*.

> I think the better solution here is to move struct ocxl_link into
> ocxl_internal.h, change ocxl_fn::link to be struct ocxl_link * rather =
than void
> *, and update the function signature for ocxl_link_update_pe() as =
well.
=20
Not move it, but we could have an opaque declaration there.

--=20
Alastair D'Silva           mob: 0423 762 819
skype: alastair_dsilva     msn: alastair@d-silva.org
blog: http://alastair.d-silva.org    Twitter: @EvilDeece