Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp1681020img; Wed, 27 Feb 2019 03:41:13 -0800 (PST) X-Google-Smtp-Source: AHgI3IYGLjbzTEbQVHXRhvpWp87A5QfIJpuvHzImIBEITvRMz7td1zQgtFMW5H1rSkSUaa4eL04G X-Received: by 2002:a17:902:1744:: with SMTP id i62mr1674130pli.43.1551267673292; Wed, 27 Feb 2019 03:41:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551267673; cv=none; d=google.com; s=arc-20160816; b=s1rILqKX9J35XaHav6lpI8DdKN7J/axwZcE3NeLE9w0Pt+qBvYk8sYjTb88x8cZF2T +j8Vr+dGqZGmkVpXGjZ9gt8TS8HdUSEm4TKU5fgiTgqzgqkM8dp85R2LdPJH0LGruSY5 QmGy38FafxlMFZtaP47koeJXEsvo49v1IHflkVqBLjQW/vYL4T4YIsKmR6JxbQ3EKBnl m8UxpR1X7tbcvCv4s/ddBi/FlB1Fnm9rdENxsR/psv5+hP6TBTuPY1mWkNz5mZXFdcel 8+2Aj0vtuau7bsAPzTzajXxV+2MFxCwsy+UjiI1H1kvbNx+lnDCa03yiiJ4TZ6P+FYXN PMMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=vxyrsFoXye06ySs5+Eq2/3kLhu+Nglc3DPfN88ZKCCI=; b=Wt1mbBIqpY2YCFt0t69pxotZYm7JxEUyjMw6NLFJrJRnvQrKxloGqUGlIDeOH4N4r7 gmJ3Mcvr1miOL7k3c1zBDX9T7/h9/NuMl0v2YAh7fOcbSKo5IEXbf2E8+1y4CM1yaHOW RtwuQJIQgHROGKMEzkGTqekTVT38Xr7vaidovzDazMnzUi2aiPoZxCYnkn19hAxq+BGn vOoXXi6MkxT/vQ5t1tgWPDyZhGWd/qFknKZh2hJTANdAtJDgAPAWCvdRvkr8w91X6wHz EbGm/ZvQ4AB0sGVidymM5hoxSZB81i1yRvB53D8pZod7o2Pg+JYtjdhwgpBZVY7Rm+wa HG9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=m06nZvHL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r6si15070254plo.269.2019.02.27.03.40.56; Wed, 27 Feb 2019 03:41:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=m06nZvHL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728462AbfB0LjL (ORCPT + 99 others); Wed, 27 Feb 2019 06:39:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:51170 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725927AbfB0LjL (ORCPT ); Wed, 27 Feb 2019 06:39:11 -0500 Received: from devbox (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABECE20C01; Wed, 27 Feb 2019 11:39:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551267550; bh=W+gQquKt0qM0wI3W5Fbfeh192JvhRmWyaa89JadvxvA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m06nZvHLvocjOH1w/cCzaikYoynNhS4CWmmDPaLiGap5DwFZRMFoIJk6cqD0j4qdJ 5cRXy73G36ipO9y04MLFj6C1Zfc/TzZxgjLc2sL+lAC624clIQYI5DRT8Vn/8VdhMD u87xFFjkao+SYiKDOYQPOGp+YHKkmEIXpl77v65E= Date: Wed, 27 Feb 2019 20:39:06 +0900 From: Masami Hiramatsu To: Peter Zijlstra Cc: Joel Fernandes , Steven Rostedt , Linus Torvalds , linux-kernel@vger.kernel.org, Andy Lutomirski , Ingo Molnar , Andrew Morton , Changbin Du , Jann Horn , Kees Cook , Andy Lutomirski , Alexei Starovoitov , Nadav Amit Subject: Re: [RFC PATCH 0/4] tracing/probes: uaccess: Add support user-space access Message-Id: <20190227203906.c4f2e1bf1def44f32e37758e@kernel.org> In-Reply-To: <20190227080034.GJ32494@hirez.programming.kicks-ass.net> References: <155110348217.21156.3874419272673328527.stgit@devbox> <20190226213850.GA219025@google.com> <20190227164104.5f53f029a7fec898204e9b67@kernel.org> <20190227080034.GJ32494@hirez.programming.kicks-ass.net> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Feb 2019 09:00:34 +0100 Peter Zijlstra wrote: > On Wed, Feb 27, 2019 at 04:41:04PM +0900, Masami Hiramatsu wrote: > > > > IMHO, checking in access_ok() inside it is reasonable, but as it > > commented, it is for "if pagefaults are enabled.". What we need another > > access_ok() for the case when pagefaults are disabled, that is what PeterZ > > suggested in below mail. > > > > https://lore.kernel.org/lkml/20190225150603.GE32494@hirez.programming.kicks-ass.net/T/#u > > FWIW, feel free to carry that patch with your other changes that require > it. > > You can add my SoB if you write the Changelog ;-) OK, I'll send v3 patch including your fix :) Thank you! -- Masami Hiramatsu