Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp1695946img; Wed, 27 Feb 2019 03:58:45 -0800 (PST) X-Google-Smtp-Source: AHgI3IbVX842lrn/ee0ENVrQn3WtLQhVK7G1RQV/8NgtEcRs5eZzfs0pk5dMQ6mZv7jVuW51Nuus X-Received: by 2002:a17:902:282b:: with SMTP id e40mr1771814plb.111.1551268725411; Wed, 27 Feb 2019 03:58:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551268725; cv=none; d=google.com; s=arc-20160816; b=VrNKn2AalOJjNI1azhygJjp+Y2SVXY7Piv12O51RH+nJ1WEbBG2Qcv547XX4Y8TAAY 1ysUDRLNptn8KBKyIyPWm+hvLDf9NIVaU6Y8YGyjg+a+hRz8gq5scVJC5YxkAkmUfyWq RXJ8KKTodJjVad2gEwc2f5YGslLmMAe74cZRt8X9hi3x7RE8qSlV6THtX4Ij8eraFT7h uPYkNs5mMoLYEg8NlmH2NsTVEWNW82wvkBiChRINdcZGhH3YVxtyJ7ALmUfPyk6fY0FO xFd1b1hx2iUv+6inSXYd/wZmZXxzYX9/A8OyoDHooFFkUvTp9k4Oj6FQTiJHUlcYnGxY OfVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from; bh=FktWpcsltLwLgmyaJovIFHfrMl2gRZlI30eSQpb/cFw=; b=tTQ4GFu704jYn2euNmooah1U8b+XYhPCCqZkUcSMMM5eGBJLaZxLse8pNSnYjFvvP3 yKieHZl/IqTcVwnhIZxIX1kvio6EgC02DT4QKt70Ir7L2XKGZvu8tbh1oYHX1IP+fc9u wxAFMKFkwZaNBBL5g03VyYR4PTnDR4FuYdh7+dl5xS95HPh4IEJYvEzlIZrIR9NeL1QX aufGVjYQeygR1v9rPQCLrtOUXhAv88RmIphYud6nIWWrYwX17xH9OovVOLFVoLLcOyCX A2xDwxH0Z57+y2zZom0FWbmFEe2BS8JlZynEwNdtcrndfqCkEEr+HYv+bIvoIEodqVD/ 6K/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 26si15359128pfr.9.2019.02.27.03.58.29; Wed, 27 Feb 2019 03:58:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729905AbfB0L5T convert rfc822-to-8bit (ORCPT + 99 others); Wed, 27 Feb 2019 06:57:19 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:38842 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725927AbfB0L5S (ORCPT ); Wed, 27 Feb 2019 06:57:18 -0500 Received: by unicorn.mansr.com (Postfix, from userid 51770) id EB5D315632; Wed, 27 Feb 2019 11:57:16 +0000 (GMT) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: set driver_info for SIM5218 and compatibles References: <20190226170710.12709-1-mans@mansr.com> <20190227083342.GJ4747@localhost> Date: Wed, 27 Feb 2019 11:57:16 +0000 In-Reply-To: <20190227083342.GJ4747@localhost> (Johan Hovold's message of "Wed, 27 Feb 2019 09:33:42 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johan Hovold writes: > On Tue, Feb 26, 2019 at 05:07:10PM +0000, Mans Rullgard wrote: >> The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4 >> of which are serial ports. The fifth is a network interface supported >> by the qmi-wwan driver. Furthermore, the serial ports do not support >> modem control signals. Add driver_info flags to reflect this. >> >> Signed-off-by: Mans Rullgard >> --- >> drivers/usb/serial/option.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c >> index fb544340888b..af4cbfecc3ff 100644 >> --- a/drivers/usb/serial/option.c >> +++ b/drivers/usb/serial/option.c >> @@ -1066,7 +1066,8 @@ static const struct usb_device_id option_ids[] = { >> .driver_info = RSVD(3) }, >> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */ >> { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */ >> - { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */ >> + { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */ >> + .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) }, >> /* Quectel products using Qualcomm vendor ID */ >> { USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)}, >> { USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20), > > Could you please provide the output of usb-devices (or lsusb -v) for > this device? lsusb -v: Bus 001 Device 003: ID 05c6:9000 Qualcomm, Inc. SIMCom SIM5218 modem Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 0 bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize0 64 idVendor 0x05c6 Qualcomm, Inc. idProduct 0x9000 SIMCom SIM5218 modem bcdDevice 0.00 iManufacturer 3 SimTech, Incorporated iProduct 2 SimTech SIM5360 iSerial 0 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 138 bNumInterfaces 5 bConfigurationValue 1 iConfiguration 1 SimTech Configuration bmAttributes 0xe0 Self Powered Remote Wakeup MaxPower 500mA Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 2 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 255 Vendor Specific Subclass bInterfaceProtocol 255 Vendor Specific Protocol iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 32 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x01 EP 1 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 32 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 0 bNumEndpoints 2 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 255 Vendor Specific Subclass bInterfaceProtocol 255 Vendor Specific Protocol iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x82 EP 2 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 32 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x02 EP 2 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 32 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 2 bAlternateSetting 0 bNumEndpoints 2 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 255 Vendor Specific Subclass bInterfaceProtocol 255 Vendor Specific Protocol iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x83 EP 3 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 32 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x03 EP 3 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 32 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 3 bAlternateSetting 0 bNumEndpoints 3 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 255 Vendor Specific Subclass bInterfaceProtocol 255 Vendor Specific Protocol iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x84 EP 4 IN bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 5 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x85 EP 5 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 32 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x04 EP 4 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 32 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 4 bAlternateSetting 0 bNumEndpoints 3 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 255 Vendor Specific Subclass bInterfaceProtocol 255 Vendor Specific Protocol iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x86 EP 6 IN bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 5 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x87 EP 7 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 32 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x05 EP 5 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 32 Device Qualifier (for other device speed): bLength 10 bDescriptorType 6 bcdUSB 2.00 bDeviceClass 0 bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize0 64 bNumConfigurations 1 can't get debug descriptor: Resource temporarily unavailable Device Status: 0x0000 (Bus Powered) -- M?ns Rullg?rd