Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 27 Feb 2019 12:38:21 -0500
From:   Sasha Levin <sashal@kernel.org>
To:     Mike Snitzer <snitzer@redhat.com>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 4.20 42/77] dm: fix clone_bio() to trigger
 blk_recount_segments()
Message-ID: <20190227173821.GK10616@sasha-vm>
References: <20190215020855.176727-1-sashal@kernel.org>
 <20190215020855.176727-42-sashal@kernel.org>
 <20190215034909.GB17226@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20190215034909.GB17226@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 14, 2019 at 10:49:09PM -0500, Mike Snitzer wrote:
>On Thu, Feb 14 2019 at  9:08pm -0500,
>Sasha Levin <sashal@kernel.org> wrote:
>
>> From: Mike Snitzer <snitzer@redhat.com>
>>
>> [ Upstream commit 57c36519e4b949f89381053f7283f5d605595b42 ]
>>
>> DM's clone_bio() now benefits from using bio_trim() by fixing the fact
>> that clone_bio() wasn't clearing BIO_SEG_VALID like bio_trim() does;
>> which triggers blk_recount_segments() via bio_phys_segments().
>>
>> Reviewed-by: Ming Lei <ming.lei@redhat.com>
>> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>Please no, I later effectively reverted this change with commit
>fa8db4948f522 ("dm: don't use bio_trim() afterall")

I've dropped it, thank you.

>(As and aside, I really shouldn't have to defend against stable@ bots
>picking up a commit, like 57c36519e4b949f, that wasn't marked for
>stable@.)

Is it the case that this commit isn't appropriate for stable for some
reason, or was it just buggy?

--
Thanks,
Sasha