Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 27 Feb 2019 10:38:37 -0800 (PST)
Message-Id: <20190227.103837.668255833945043179.davem@davemloft.net>
To:     steven.price@arm.com
Cc:     linux-mm@kvack.org, luto@kernel.org, ard.biesheuvel@linaro.org,
        arnd@arndb.de, bp@alien8.de, catalin.marinas@arm.com,
        dave.hansen@linux.intel.com, mingo@redhat.com, james.morse@arm.com,
        jglisse@redhat.com, peterz@infradead.org, tglx@linutronix.de,
        will.deacon@arm.com, x86@kernel.org, hpa@zytor.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Mark.Rutland@arm.com, kan.liang@linux.intel.com,
        sparclinux@vger.kernel.org
Subject: Re: [PATCH v3 20/34] sparc: mm: Add p?d_large() definitions
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190227170608.27963-21-steven.price@arm.com>
References: <20190227170608.27963-1-steven.price@arm.com>
        <20190227170608.27963-21-steven.price@arm.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Steven Price <steven.price@arm.com>
Date: Wed, 27 Feb 2019 17:05:54 +0000

> walk_page_range() is going to be allowed to walk page tables other than
> those of user space. For this it needs to know when it has reached a
> 'leaf' entry in the page tables. This information is provided by the
> p?d_large() functions/macros.
> 
> For sparc, we don't support large pages, so add stubs returning 0.
> 
> CC: "David S. Miller" <davem@davemloft.net>
> CC: sparclinux@vger.kernel.org
> Signed-off-by: Steven Price <steven.price@arm.com>

Sparc does support large pages on 64-bit, just not at this level.  It
would be nice if the commit message was made more accurate.  Other than
that:

Acked-by: David S. Miller <davem@davemloft.net>