Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp2118491img; Wed, 27 Feb 2019 10:39:56 -0800 (PST) X-Google-Smtp-Source: AHgI3IYNV46dFsyieqo4p72S0DmGSNH73zRvFr5BShSUatfMo7d7vBaPaI8ad1nMT5Qi4fp4MT+7 X-Received: by 2002:a17:902:509:: with SMTP id 9mr3528032plf.94.1551292796198; Wed, 27 Feb 2019 10:39:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551292796; cv=none; d=google.com; s=arc-20160816; b=JQCLbmZeW0M0cOSjqk4z1yBsdEVEbLSWACpbgvY58c5hCk4OuKNSMUEmPIoPzlBqMb d7kyo9F1ZOc7VDLyQhUdDd1oIJAxCJ7tMyqtbqJg9YeGOgEkDCutP3KsPejv9bGzW58f /o4d4Wdh81kXSvrYbmX4tucrg9Q+e62dzYFOoyuyq4AacQyb+KL2BaD+QsEDkEr+7Tyu T+0Ko6EmpmRrFHacAuLlXhXZpOJ4KVwM0CRLgejEUkfffuCihtGLn2n6YXCa1CWVNAdN sG/3iB53RbuuqJ0PYeb1okVPWkPjQuIP1J7EX70Hh7SW/nORD6XDJNAq/3cB5+ea9GC5 fVRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:cc:to:from:subject; bh=LVe0sg66UKpiK11QzXB4kan2KjByYKK04TgHTkxSMg4=; b=z7WYWMLgQAsRWV04cJv5GLcvL6oZ2eSgmctCPv9t1EWS9WNlta1XTo/5Gpk8WNnH+2 Nex/udcRIK3G/wEc2LUnrLfueGPrbh3DP7QnKe2xm01gjplZ3txymwz04hpxih1Qdm1/ 80ZmxKZhELLbzrfd74ryXuWjOEB3Bz6likkawmoncZXadJpMmslIjqEtEUprXlpbaj+h o5GhZTaUqnZwfv8+0UkmAzP2Fae8ztQiUr3jlDcXppfMnVmfcuu+X2WvoIfIY35r9D2z j1zomcxphE0NDQmQg3fKVb5rYMG0YIF9qtHpHO4FyG5itDWEJFiXYpo9tnxOtIsV5HTZ kB0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cy1si17561646plb.429.2019.02.27.10.39.42; Wed, 27 Feb 2019 10:39:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729434AbfB0SiL (ORCPT + 99 others); Wed, 27 Feb 2019 13:38:11 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60308 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726894AbfB0SiK (ORCPT ); Wed, 27 Feb 2019 13:38:10 -0500 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1RITPun016232 for ; Wed, 27 Feb 2019 13:38:09 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qwwcufykh-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 27 Feb 2019 13:38:08 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Feb 2019 18:38:07 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 27 Feb 2019 18:38:05 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x1RIc4Qh32047282 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Feb 2019 18:38:04 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 085A2A4064; Wed, 27 Feb 2019 18:38:04 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4125DA405B; Wed, 27 Feb 2019 18:38:03 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.106.105]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 27 Feb 2019 18:38:03 +0000 (GMT) Subject: Re: [PATCH v2 5/5] selftests/ima: loading kernel modules From: Mimi Zohar To: shuah , linux-kselftest@vger.kernel.org Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Petr Vorel Date: Wed, 27 Feb 2019 13:37:52 -0500 In-Reply-To: References: <1551223620-11586-1-git-send-email-zohar@linux.ibm.com> <1551223620-11586-6-git-send-email-zohar@linux.ibm.com> <19d494c6-ecb1-b884-2d23-5f556b3ec05b@kernel.org> <1551276893.10911.23.camel@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19022718-0020-0000-0000-0000031C0659 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19022718-0021-0000-0000-0000216D7446 Message-Id: <1551292672.10911.68.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-27_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=741 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902270125 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >>> +get_secureboot_mode > >>> +if [ $? -eq 0 ]; then > >>> + log_skip "secure boot not enabled" > >>> +fi > >>> + > >>> +# get the kernel config > >>> +get_kconfig > >>> + > >> > >> get_kconfig() will be good candidate as a kselftest common > >> function. Is that possible? > > > > Sure, where would it go?  get_kconfig calls log_skip.  I didn't see > > any common logging functions.  Petr suggested defining a set of common > > logging functions.  Did you want to only make "log_skip" a common > > function or the other logging functions log_pass, log_fail, log_info > > as well? > > > > We can do this as a separate effort in the interest of getting these > in the interest of getting these in. > > We have common functions in ksefltest.h for c and we don't have them > for tests scripts. We might be able to collect common routines such > as get_kconfig into a common .sh and include in tests. If you have time > to do this, that will be great. It can be done as a separate effort. Ok.  For now, I'm waiting for some review/ack's. Mimi