Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 27 Feb 2019 10:40:28 -0800
From:   Stephen Hemminger <stephen@networkplumber.org>
To:     Harini Katakam <harinik@xilinx.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nicolas Ferre <nicolas.ferre@atmel.com>,
        David Miller <davem@davemloft.net>,
        Michal Simek <michal.simek@xilinx.com>,
        Harini Katakam <harini.katakam@xilinx.com>,
        Harini Katakam <harinikatakamlinux@gmail.com>
Subject: Re: Request for suggestion on net device re-naming/re-ordering
 based on DT alias
Message-ID: <20190227104028.707a75e2@shemminger-XPS-13-9360>
In-Reply-To: <CAFcVEC+8P25MKWhizUUEuamikaZYUOjpppV=59=W3POTEfQqXw@mail.gmail.com>
References: <CAFcVEC+8P25MKWhizUUEuamikaZYUOjpppV=59=W3POTEfQqXw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 27 Feb 2019 17:24:03 +0530
Harini Katakam <harinik@xilinx.com> wrote:

> Hi,
>=20
> We've had some users requesting control over net device name order
> when multiple ethernet devices are present on a system. I've tried a
> few solutions to this and looked it up on forums. But I apologize if
> I have missed something.
>=20
> I know that the current system allocates eth<n> as per probe order
> but that is obviously not stably controlled by user (tried DT
> re-ordering and defer probe). One solution is to use DT alias names
> to write to (net_device)->name as follows:
> Devicetree:
> aliases {
>    ethernet0 =3D &mac1;
>    ethernet1 =3D &mac0;
> };
> Driver probe:
> +       /* Read ethernet DT alias id and assign to right device name*/
> +       id =3D of_alias_get_id(np, "ethernet");
> +       if (id < 0) {
> +               dev_warn(&pdev->dev, "failed to get alias id (%u)\n", id);
> +               return id;
> +       }
> +       snprintf(dev->name, sizeof(dev->name), "eth%d", id);
> +
>=20
> These three drivers seem to have something similar for mdio/phy bus IDs:
> drivers/net/ethernet/broadcom/genet/bcmmii.c:409: id =3D
> of_alias_get_id(dn, "eth");
> drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:43: plat->bus_id =3D
> of_alias_get_id(np, "ethernet");
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:404:
> plat->bus_id =3D of_alias_get_id(np, "ethernet");
>=20
> Drawback: This approach will break if alias is not provided for one
> of the interfaces on board. Not to mention, there could be systems
> with multiple ethernet makes (for ex. Cadence macb and Xilinx axienet)
> If one of the drivers does not have an alias read mechanism, it is
> possible to have clashing ID assignments. Is there any way this
> solution can be changed to be stable/acceptable?
>=20
> One other alternative I've tried is netdev kernel bootargs but this
> device name was not being picked by the kernel:
> https://www.kernel.org/doc/html/v4.19/admin-guide/kernel-parameters.html
> netdev=3D <mac1=E2=80=99s interrupt id>, <mac1=E2=80=99s base address>, e=
th0
> netdev=3D<mac0=E2=80=99s interrupt id>, <mac0=E2=80=99s base address>, et=
h1
>=20
> Could you please suggest any alternatives?
> Thanks!
>=20
> Regards,
> Harini

Device naming is a hard problem, and there is no perfect solution.

Device tree should be providing hints to userspace policy for naming, not
trying to do it in the kernel.=20
See: https://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkIn=
terfaceNames/