Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp2231822img; Wed, 27 Feb 2019 12:48:04 -0800 (PST) X-Google-Smtp-Source: AHgI3IZCkEllLwM6dZwz2Y1iQRZ+9sUWGkGr2ey6RY/+OgXI3z5HbtKX0jjGC/3sgGEys1wxGZtk X-Received: by 2002:a17:902:c81:: with SMTP id 1mr4156564plt.155.1551300484534; Wed, 27 Feb 2019 12:48:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551300484; cv=none; d=google.com; s=arc-20160816; b=FLULC9RNx0o2gAys7dmOp0fc76igoqVO8PauubYCLFhVKOKtRhLFbNmibLtRLMMeX3 WNMhXLtbyzE32B+rLDxKU81G+Bbvg9UEsjuxPrg/Kn4VNWVoIwt8CrN3+XGMDFyWKF9J Q2iNlrdce2m+sNb5hV3tTkhUBItzgTrTCL6Jvv2PFSj/t/aL003kpUjX4nUm92Qt2wfs /AJkvSvOEQBmcIlJqA/RWY9O//eZO5HkqLP+UC+7N/2o71CK7w5xWM0X2IZhaevTTT3i QDdbntBPqjXYb2V1Ru3pnxzRtkdSfoSgbzP6ME6wbR9JXQ91gKV+zVvOPeP+tUFQr08x GA/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=fysy4W1JsLJNGtNiqBcR+gaIGLkCCRdCGseNbvSiG5A=; b=P/bV0fUg+dx8ii8TLWQ+J2i7TMbEyabN0X2wMIzkfGpmJ8M78/pDweU2LWnkAMzzAP v172CAx0npR/9rjlPJMcOnUhsibVvS9D6SrfNIRycnOEAa2JvkxDbnkZAbdMUqcdDJwe pHMGokmQkIHQ8PefQNjQMT5N7wC5/OD1RK7VQhrx9xskLSry/cYJqdIYt/QyoBPlWoxK +c7roSf3gQrEmt3DmAY7S75LaBdjMsC5KHtHD0Ag2RNR4mPmjU5qFjpuYcTtk53y5hIg OLcXtLoSt1n2mSvsjoaQJPUJBeGfwf1BPMDKqWkoze1hI2S4rg5AauOAW2tJloADGEEK Lwew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=X0dP0ili; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s8si12893249pfm.41.2019.02.27.12.47.48; Wed, 27 Feb 2019 12:48:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=X0dP0ili; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730342AbfB0UrZ (ORCPT + 99 others); Wed, 27 Feb 2019 15:47:25 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:2174 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729291AbfB0UrY (ORCPT ); Wed, 27 Feb 2019 15:47:24 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 27 Feb 2019 12:47:31 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 27 Feb 2019 12:47:22 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 27 Feb 2019 12:47:22 -0800 Received: from [10.26.11.186] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 27 Feb 2019 20:47:12 +0000 Subject: Re: [PATCH V15 14/18] block: enable multipage bvecs To: Marek Szyprowski , Ming Lei , Jens Axboe CC: , , , Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , , Alexander Viro , , , David Sterba , , "Darrick J . Wong" , , Gao Xiang , Christoph Hellwig , , Coly Li , , Boaz Harrosh , Bob Peterson , , Ulf Hansson , "linux-mmc@vger.kernel.org" , 'Linux Samsung SOC' , Krzysztof Kozlowski , Adrian Hunter , Bartlomiej Zolnierkiewicz , linux-tegra References: <20190215111324.30129-1-ming.lei@redhat.com> <20190215111324.30129-15-ming.lei@redhat.com> <6c9ae4de-c56f-a2b3-2542-da7d8b95601d@samsung.com> From: Jon Hunter Message-ID: <0dbbee64-5c6b-0374-4360-6dc218c70d58@nvidia.com> Date: Wed, 27 Feb 2019 20:47:09 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <6c9ae4de-c56f-a2b3-2542-da7d8b95601d@samsung.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1551300451; bh=fysy4W1JsLJNGtNiqBcR+gaIGLkCCRdCGseNbvSiG5A=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=X0dP0iliVFercVqWdMyW/NR2Nhm0eLApUzdqUyISSWUx2H+DKhUu/OKtqWe2+3ZuT au4eOklUFmE4Gr2obXchzT8IXOfMhcyX4FkEsLxzHW0xgKT/h6CV7784HRm5efp90O La7tft6R64o+psxbqoi6GCRY4KpDinbyuM578z8ZIBlOABzOuvOkGz6q77lXYGVw0F i4IUbygeJkCCpZ0U5/kCdyLBwxOPIqZvceHCPKG8aMbmcU8ubwJyoq9ClYgVHYmDHM dxcWgdcM3oW54O+MFPY5/ZPt1Zh31nOGXIQBPU0L01WBNStNQbbLPLk/T1RrJziyxj hseLr65aHTomg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/02/2019 08:42, Marek Szyprowski wrote: > Dear All, > > On 2019-02-15 12:13, Ming Lei wrote: >> This patch pulls the trigger for multi-page bvecs. >> >> Reviewed-by: Omar Sandoval >> Signed-off-by: Ming Lei > > Since Linux next-20190218 I've observed problems with block layer on one > of my test devices (Odroid U3 with EXT4 rootfs on SD card). Bisecting > this issue led me to this change. This is also the first linux-next > release with this change merged. The issue is fully reproducible and can > be observed in the following kernel log: > > sdhci: Secure Digital Host Controller Interface driver > sdhci: Copyright(c) Pierre Ossman > s3c-sdhci 12530000.sdhci: clock source 2: mmc_busclk.2 (100000000 Hz) > s3c-sdhci 12530000.sdhci: Got CD GPIO > mmc0: SDHCI controller on samsung-hsmmc [12530000.sdhci] using ADMA > mmc0: new high speed SDHC card at address aaaa > mmcblk0: mmc0:aaaa SL16G 14.8 GiB I have also noticed some failures when writing to an eMMC device on one of our Tegra boards. We have a simple eMMC write/read test and it is currently failing because the data written does not match the source. I did not seem the same crash as reported here, however, in our case the rootfs is NFS mounted and so probably would not. However, the bisect points to this commit and reverting on top of -next fixes the issues. Cheers Jon -- nvpublic