Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] x86/stacktrace: export save_stack_trace_tsk_reliable
From:   Joe Lawrence <joe.lawrence@redhat.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
        x86@kernel.org, Jiri Slaby <jslaby@suse.cz>,
        Josh Poimboeuf <jpoimboe@redhat.com>
References: <20190227211748.9545-1-joe.lawrence@redhat.com>
 <alpine.DEB.2.21.1902272219160.1644@nanos.tec.linutronix.de>
 <07491738-dfdb-deb4-7e25-f1c173dda773@redhat.com>
Message-ID: <873cd5ca-1f88-499e-e8ed-9a93f42d8239@redhat.com>
Date:   Wed, 27 Feb 2019 18:20:14 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <07491738-dfdb-deb4-7e25-f1c173dda773@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/27/19 5:25 PM, Joe Lawrence wrote:
> On 2/27/19 4:31 PM, Thomas Gleixner wrote:
>> On Wed, 27 Feb 2019, Joe Lawrence wrote:
>>
>>> The ppc64le implementation of save_stack_trace_tsk_reliable() is
>>> exported, so do the same with x86.
>>
>> And what's the in tree module user of this? I can't find one and just
>> because PPC has an export with no user is not a convincing argument to add
>> another one. The proper solution is to remove the unused PPC export.
>>
> 
> Good point.
> 
> For that matter, I do see in-tree modules making use of
> save_stack_trace, but who is calling save_stack_trace_tsk (exported by
> most arches) and save_stack_trace_regs (exported by openrisc, powerpc,
> s390)?

Well, at least for save_stack_trace_tsk there is the out-of-tree kpatch 
core module[1].  (Kpatch drops that call if the kernel provides 
livepatch functionality.)

[1] https://github.com/dynup/kpatch/blob/master/kmod/core/core.c#L275

-- Joe