Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp288925img; Wed, 27 Feb 2019 22:33:52 -0800 (PST) X-Google-Smtp-Source: AHgI3IZcSOP5hLPqEIbNhiyNtHCTCIf8oBMWZ2IgPEl4OHGeb1ezpYfHHiSf5jIEqYx5gfjxQE+D X-Received: by 2002:a63:2d43:: with SMTP id t64mr6846725pgt.155.1551335631962; Wed, 27 Feb 2019 22:33:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551335631; cv=none; d=google.com; s=arc-20160816; b=LY4cRIe+u/YSEcrWfbw5ZYTFovOLEGlnerpn1+60FkEI+jXvvqSu/2Uk/iVIHMWraW pJ8/NaQh0bugVOApdrnLHOLmz61ejumTgx3KPCPgJLKjmd+g3tzWUzaba+ksNan5jpqT 50IpSjBVJ+vWsj4vjni3fvkaWcdeqdav7qoPYsbHmO1uIL8FKqGZS9CtGDKGCWwZKwjB lNHCy7kWI53WYpKOTXssGJEQdIagk4r78gIBrwI22jPMd6xGgyyobzB34NL+1mJNFWvi Rd5K1Rp9MtAtj8QVbFBfcz24lPp+wecUrnIE2/5uDVxLFhf9WaU+Fg2F2LWEV3fW4dAh h9Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=2FJtf9CY/ieacfavNoXMGwnuaJywfXoxlRROJ39/Vg0=; b=gDraXV28gRi6zT/3VNv7ZnTGDURtSCgSQNqySbg5sPmhbQGtBJf5QNs1h4XHluTvah dOeftObS1YwBafNXlfiE/PmKUQckZibU8dTOWEPbSojUul0yQyWMgMoNq++q5Lnd9+BF TTtHyQj4COglZCWVoE/b86jBLP2VDrOsj60V8JfcI4Ha5AFHWZqetmbcmedRPalCxRLO qZq6/GfxefD7vbs7aW2DYsS3Yar4vNX6SMLLaGQCVS4QV8Ekjh9KhLKdFKjV7NnV4ZhL OyN+tEkU+D/0muI7d02dc2CC03aoMW+s62n2Y0ykxW0FBENM2aXMdLqpBMUNuTsipKrU decA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y186si16486959pgd.315.2019.02.27.22.33.36; Wed, 27 Feb 2019 22:33:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730799AbfB1GcA (ORCPT + 99 others); Thu, 28 Feb 2019 01:32:00 -0500 Received: from bmailout3.hostsharing.net ([176.9.242.62]:57815 "EHLO bmailout3.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbfB1GcA (ORCPT ); Thu, 28 Feb 2019 01:32:00 -0500 Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (not verified)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id DC724100D940C; Thu, 28 Feb 2019 07:31:57 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 81416D6B92; Thu, 28 Feb 2019 07:31:57 +0100 (CET) Date: Thu, 28 Feb 2019 07:31:57 +0100 From: Lukas Wunner To: Alexandru Gagniuc Cc: bhelgaas@google.com, austin_bolen@dell.com, alex_gagniuc@dellteam.com, keith.busch@intel.com, Shyam_Iyer@Dell.com, okaya@kernel.org, "Rafael J. Wysocki" , Oza Pawandeep , Mika Westerberg , Benjamin Young , Frederick Lawler , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v3] PCI: portdrv: Report degraded links via link bandwidth notification Message-ID: <20190228063157.rl2lywgian2ij5m4@wunner.de> References: <20190227205840.26898-1-mr.nuke.me@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190227205840.26898-1-mr.nuke.me@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 27, 2019 at 02:58:17PM -0600, Alexandru Gagniuc wrote: > A warning is generated when a PCIe device is probed with a degraded > link, but there was no similar mechanism to warn when the link becomes > degraded after probing. The Link Bandwidth Notification provides this > mechanism. > > Use the link bandwidth notification interrupt to detect bandwidth > changes, and rescan the bandwidth, looking for the weakest point. This > is the same logic used in probe(). > > Signed-off-by: Alexandru Gagniuc Reviewed-by: Lukas Wunner