Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261815AbUCPX0m (ORCPT ); Tue, 16 Mar 2004 18:26:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261819AbUCPX0m (ORCPT ); Tue, 16 Mar 2004 18:26:42 -0500 Received: from fw.osdl.org ([65.172.181.6]:12003 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261815AbUCPX0k (ORCPT ); Tue, 16 Mar 2004 18:26:40 -0500 Date: Tue, 16 Mar 2004 15:28:43 -0800 From: Andrew Morton To: mason@suse.com, daniel@osdl.org, linux-kernel@vger.kernel.org, linux-aio@kvack.org Subject: Re: 2.6.4-mm2 Message-Id: <20040316152843.667a623d.akpm@osdl.org> In-Reply-To: <20040316152106.22053934.akpm@osdl.org> References: <20040314172809.31bd72f7.akpm@osdl.org> <1079461971.23783.5.camel@ibm-c.pdx.osdl.net> <1079474312.4186.927.camel@watt.suse.com> <20040316152106.22053934.akpm@osdl.org> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i586-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 17 Andrew Morton wrote: > > I'm thinking that the right thing to do here is to change submit_bh() > callers and ll_rw_block() to run set_page_writeback(bh->b_page) when they > start the buffer writeout and to do the run-around-the-buffer_heads thing > at I/O completion. A page may have a mix of writeback and dirty+non-writeback buffers. It appears that the page-level writeback code will handle this correctly. But it requires that the page lock be held when we run set_page_writeback(), so that tears that. hmm. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/