Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp486949img; Thu, 28 Feb 2019 03:03:24 -0800 (PST) X-Google-Smtp-Source: AHgI3IZp72GuKkSsaDQ8L03Wb0jkTFa5huAd2grn+9UPAQ1tVcZtIwj0G63b8E8oBslEjzB8lKPd X-Received: by 2002:a62:76d4:: with SMTP id r203mr1945990pfc.15.1551351803705; Thu, 28 Feb 2019 03:03:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551351803; cv=none; d=google.com; s=arc-20160816; b=wRHPARoAWa/gGXJhRX5nNV/HR/Iiiyn+oninFOq4l5zTZlVCSBDAY289zV4BeJdJYL VJ8KX3PYpCm9R0SrLsyxB9yjJKo4eucot68gCE7jrUhYwJRnGJTAXbyksqoRpSgOy93q FegJATqPFvNGBP3XjHhApj+uUwEHD5znSgWdK7g6e9oVhPsYgoJVBXvRquPZoh8LNfjf fXyMHr5QQFjW6ECICF6cF0U2cz0xvHB2XmZ1J855jwJmrUPNvqKDbRDF/mutm4dE7stl JH12DeSQ8TnzDVvqSthf0IS2sqE9CI3DEwDADNuFaYR7GgISoq6nKLS0w70OXBZzfWOZ WtmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date; bh=SR8BLnIRhATdmob1mxT7+21ONN62AKOflIkM5kdw0Lc=; b=eOgzHnRyfSpOhwZqSUZ0kQnzVQY0nSAYbAbIWztBDh4x+hzPO9SJx31nGNvCaoBOIB vMPkdgurz3nIwi7JK7kmAPm4LFUuTO+/RSeZtXOVnm4BYtk/AnCVB9sVwE9G7afPXeYi 3k3CEZoZAGJSu47tIAOmRypBqquZGtv5DHXooxJ1HxVs5jrZQVxFprPrxaVfX4CGSziY JQMHN01+gVbi/Zv4Qq5/qwO/T+LJOL4ODwSyEU5afS7vBu3iA+FcCb4m29DusBBodjhK Jhtekn7tQ8C/AyqaduObMO2lLyaRuqu0qycifZvJgwMctqxluRuz84/XrI09X3iR8tk1 I/ZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u15si19537981pfc.265.2019.02.28.03.03.07; Thu, 28 Feb 2019 03:03:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731911AbfB1IGy (ORCPT + 99 others); Thu, 28 Feb 2019 03:06:54 -0500 Received: from terminus.zytor.com ([198.137.202.136]:39939 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730263AbfB1IGy (ORCPT ); Thu, 28 Feb 2019 03:06:54 -0500 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x1S86g5w2955309 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 28 Feb 2019 00:06:42 -0800 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x1S86gog2955306; Thu, 28 Feb 2019 00:06:42 -0800 Date: Thu, 28 Feb 2019 00:06:42 -0800 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Tony Jones Message-ID: Cc: hpa@zytor.com, acme@redhat.com, mingo@kernel.org, s1seetee@linux.vnet.ibm.com, tonyj@suse.de, tglx@linutronix.de, tzanussi@gmail.com, linux-kernel@vger.kernel.org Reply-To: s1seetee@linux.vnet.ibm.com, mingo@kernel.org, acme@redhat.com, hpa@zytor.com, tzanussi@gmail.com, linux-kernel@vger.kernel.org, tonyj@suse.de, tglx@linutronix.de In-Reply-To: <20190222230619.17887-5-tonyj@suse.de> References: <20190222230619.17887-5-tonyj@suse.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf script python: Add Python3 support to failed-syscalls-by-pid.py Git-Commit-ID: 9b2700efc57f46fe63beee5f64fcfe2746936b4e X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,BAYES_00, FREEMAIL_FORGED_REPLYTO,T_DATE_IN_FUTURE_96_Q autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 9b2700efc57f46fe63beee5f64fcfe2746936b4e Gitweb: https://git.kernel.org/tip/9b2700efc57f46fe63beee5f64fcfe2746936b4e Author: Tony Jones AuthorDate: Fri, 22 Feb 2019 15:06:08 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 25 Feb 2019 17:16:48 -0300 perf script python: Add Python3 support to failed-syscalls-by-pid.py Support both Python2 and Python3 in the failed-syscalls-by-pid.py script There may be differences in the ordering of output lines due to differences in dictionary ordering etc. However the format within lines should be unchanged. The use of 'from __future__' implies the minimum supported Python2 version is now v2.6 Signed-off-by: Tony Jones Cc: Tom Zanussi Link: http://lkml.kernel.org/r/20190222230619.17887-5-tonyj@suse.de Signed-off-by: Seeteena Thoufeek Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/scripts/python/failed-syscalls-by-pid.py | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/tools/perf/scripts/python/failed-syscalls-by-pid.py b/tools/perf/scripts/python/failed-syscalls-by-pid.py index cafeff3d74db..3648e8b986ec 100644 --- a/tools/perf/scripts/python/failed-syscalls-by-pid.py +++ b/tools/perf/scripts/python/failed-syscalls-by-pid.py @@ -5,6 +5,8 @@ # Displays system-wide failed system call totals, broken down by pid. # If a [comm] arg is specified, only syscalls called by [comm] are displayed. +from __future__ import print_function + import os import sys @@ -32,7 +34,7 @@ if len(sys.argv) > 1: syscalls = autodict() def trace_begin(): - print "Press control+C to stop and show the summary" + print("Press control+C to stop and show the summary") def trace_end(): print_error_totals() @@ -57,22 +59,21 @@ def syscalls__sys_exit(event_name, context, common_cpu, def print_error_totals(): if for_comm is not None: - print "\nsyscall errors for %s:\n\n" % (for_comm), + print("\nsyscall errors for %s:\n" % (for_comm)) else: - print "\nsyscall errors:\n\n", + print("\nsyscall errors:\n") - print "%-30s %10s\n" % ("comm [pid]", "count"), - print "%-30s %10s\n" % ("------------------------------", \ - "----------"), + print("%-30s %10s" % ("comm [pid]", "count")) + print("%-30s %10s" % ("------------------------------", "----------")) comm_keys = syscalls.keys() for comm in comm_keys: pid_keys = syscalls[comm].keys() for pid in pid_keys: - print "\n%s [%d]\n" % (comm, pid), + print("\n%s [%d]" % (comm, pid)) id_keys = syscalls[comm][pid].keys() for id in id_keys: - print " syscall: %-16s\n" % syscall_name(id), + print(" syscall: %-16s" % syscall_name(id)) ret_keys = syscalls[comm][pid][id].keys() - for ret, val in sorted(syscalls[comm][pid][id].iteritems(), key = lambda(k, v): (v, k), reverse = True): - print " err = %-20s %10d\n" % (strerror(ret), val), + for ret, val in sorted(syscalls[comm][pid][id].items(), key = lambda kv: (kv[1], kv[0]), reverse = True): + print(" err = %-20s %10d" % (strerror(ret), val))