Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp529310img; Thu, 28 Feb 2019 03:47:16 -0800 (PST) X-Google-Smtp-Source: AHgI3IbnOianvBG+KLyTHUyl/11U8XsBaKirb5M5SrhUFllA1+axaow/qa5mvXjZX/tuk1hTrzB+ X-Received: by 2002:a65:42c6:: with SMTP id l6mr5752240pgp.344.1551354436220; Thu, 28 Feb 2019 03:47:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551354436; cv=none; d=google.com; s=arc-20160816; b=xK7Up2MH/q5AmUN58AKgekg91ZiRzolAG0k4v/P0tBd6YQdDZFFd9jozqXjGIh0DR6 jU29xwwbymUIh5i+732QJbZcUxV72BPoUUUVLIZwExxKJSlR2ydJtE0cVcne/0CpvXj/ Ps6AHBbgKN4EEqeo5vkQb4bfiQxyt0sJUiYr2d1BW4VmU8846mGU35zFQjsWQ8h1l3qU rkbpAID2//YGfEejOg8VXSlSxnKlOo1jOa/pVBGNWGcHndc9OjNLjx5IZ6wfHDVRk9s5 yrcfF/+aQlPMfmWtedWrOMmcHivo4+h/+9cQWmbJVo3Irg33FmBKv3BFXpIAnDNZ2iqG AA/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=LtMdzsReUUFSdAWcFspo9gkFYAAv1bEvSZQYF3L2Di0=; b=VYDYnPP/Ipewxu9E0s08q19afgRna5qNeLRcClYZ3C4D2IRqUz8pwrFJuf3+UORaP3 WU6sm9rlLsOve3pZQpFUMhsSkMD9mmqoagkx3A3MwtCbiiJoDR4hRO5Qp3AbblV8Wuiy rh7Zv5kiMiGN79zbZZFFY9biNiB9kXNU95kDJKReZArFKZ4ZtBtwOJvluNYE4w62Oh8c TfVMPH4QcwQrw2fI0FQlJG1Cra9qZN1y8GCBpSaQUFuPOswV1rB0ik9UCk6ghceydNBR WMY1Dkbr56YLTX0hxkY+pZKm3CJTi4sDlUtKFt6JxLzWR3WIeqYShhsTJ5oSe5aQpalb eRhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b="V0l/qLtp"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e6si16645468pgc.252.2019.02.28.03.47.01; Thu, 28 Feb 2019 03:47:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b="V0l/qLtp"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732236AbfB1Jrk (ORCPT + 99 others); Thu, 28 Feb 2019 04:47:40 -0500 Received: from merlin.infradead.org ([205.233.59.134]:43046 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbfB1Jri (ORCPT ); Thu, 28 Feb 2019 04:47:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LtMdzsReUUFSdAWcFspo9gkFYAAv1bEvSZQYF3L2Di0=; b=V0l/qLtplGAi2NyWnjZxw1LDD W1J4LYjixJvqwupWiLq5HNF5e4WlQvO2vc1lzXSfqk5oeeixWls6di/iqA30ViXlzLSMyp26QQUIf Kimq7wo23sKGAeDwvm5TvEDEmSVlsRvErM4NrHR5pbvtH/rde/2DaEJxlZFKzl7eMyY34g6qJUTU4 xJ396aCBMEmqNs1Mt7YZEeZ0r266BzpNQ0SEKibyJhPmKUZj6nwCfvJAzdDonnqqXpzdFcc6nRK17 Mce9qw5AWBDvOpUakgYgoMWJt2egkCtcwoXfUApmanclHn1LsXZehPmrCzX/Dq3ayQ41IlkVurhKZ gsX74K81A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzIHu-0000bB-9H; Thu, 28 Feb 2019 09:47:34 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 10238202CF5F8; Thu, 28 Feb 2019 10:47:33 +0100 (CET) Date: Thu, 28 Feb 2019 10:47:33 +0100 From: Peter Zijlstra To: Ketan Patil Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, snikam@nvidia.com, bnihalani@nvidia.com, byan@nvidia.com, sgurrappadi@nvidia.com, treding@nvidia.com, talho@nvidia.com Subject: Re: [PATCH] sched/cputime: Remove unnecessary assignment statement Message-ID: <20190228094733.GY32494@hirez.programming.kicks-ass.net> References: <1551248002-27303-1-git-send-email-ketanp@nvidia.com> <20190227103230.GM32494@hirez.programming.kicks-ass.net> <9bce6378-2221-f358-dc97-f15ee7ab546b@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9bce6378-2221-f358-dc97-f15ee7ab546b@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? On Thu, Feb 28, 2019 at 03:12:13PM +0530, Ketan Patil wrote: > The coverity tool has detected this issue as an unused value, since > the code assigns the value to utime variable and then after the jump, the > value of utime again gets updated, hence the previous value is not at all > useful and this patch removes that first assignment. Not a security issue then; just tell coverity to shut up.